Commit Graph

2545 Commits

Author SHA1 Message Date
Danny Tuppeny
8ccc9a45c9 Add flutter doctor support for VS Code (#14463)
Looks in default install locations on Mac, Linux and Windows for VS Code. If found, looks in default extension location to see if Dart Code is installed.

If VS Code is not installed, nothing is reported. If VS Code is installed without Dart Code, a warning is shown.
2018-02-07 10:49:54 -08:00
Ian Hickson
a441a4030f
Fix the channel-switching logic (#14507) 2018-02-07 09:56:45 -08:00
Danny Tuppeny
efb88a0380 Reject requests for hot reload if a hot reload is already in progress. (#14494)
* Reject requests for hot reload if a hot reload is already in progress.

Fixes #14184

* Implement TODO, verifying further hot reloads complete sucessfully.

* Fix year on new file.

* Add missing type annotations to fix lints

* Add run_machine_concurrent_hot_reload to manifest for CI

* Reformat document

... but undo things that cause lints (like single-line ifs)

* Extract std stream transformations

* Make inProgressHotReload private

* Disallow all types of reload while hot reload in progress

* Simplify code handling in-progress hot reloads
2018-02-07 08:58:23 -08:00
Greg Spencer
66febf2663
Add semantics traversal order example (#14174) 2018-02-06 14:13:08 -08:00
Greg Spencer
14309b9311
Adds the semantic node traversal API. (#14060)
This adds an API for defining the semantic node traversal order.

It adds a sortOrder argument to the Semantics widget, which is a class that can define a list of sort keys to sort on. The keys are sorted globally so that an order that doesn't have to do with the current widget hierarchy may be defined.

It also adds a shortcut sortKey argument to the Semantics widget that simply sets the sortOrder to just contain that key.

The platform side (flutter/engine#4540) gets an additional member in the SemanticsData object that is an integer describing where in the overall order each semantics node belongs. There is an associated engine-side change that takes this integer and uses it to order widgets for the platform's accessibility services.
2018-02-06 13:24:16 -08:00
Alexandre Ardhuin
2e80bf1db7
unnessary parenthesis (#14475) 2018-02-06 09:00:11 +01:00
Chris Bracken
cad61b1817
Mark iOS App ID param as required (#14480)
Previously, the iOS ApplicationPackage subclasses did not mark the
bundleID constructor parameter as @required. This is passed up to the
ApplicationPackage constructor as the id parameter which is already
marked @required and is asserted to be non-null.
2018-02-05 18:11:33 -08:00
Chris Bracken
024cebf8f3
Fix mismatched bracket in Xcode failure diagnostic (#14478)
When diagnosing a failed Xcode build, if neither the development team
(for automatic provisioning) nor the provisioning profile (for manual
provisioning) is set, display the appropriate error message. Previously,
this method would not output the appropriate error message if a
only a development team was set.
2018-02-05 18:11:07 -08:00
Alexandre Ardhuin
3c379aaf43
whitespace cleanup (#14458) 2018-02-05 22:20:21 +01:00
Alexandre Ardhuin
c02b6a8bcf
some whitespace cleanup (#14443) 2018-02-02 23:27:29 +01:00
Jason Simmons
d5149d4457
Toolchain support for Android ARM64 targets (#14394) 2018-02-01 15:14:48 -08:00
jcollins-g
26102c9120
Condense and summarize doctor output without --verbose (#14173)
* Flatten change out from lots of merges and temporary hacks for #7224

* Expand fakes to cover cases where doctor passes

* -v != --verbose

* Cosmetic touchups

* delint

* Clean up summary line, add a switch for review comments

* Review comments

* nit

* review comment

* review comments
2018-02-01 10:27:55 -08:00
jcollins-g
c81a5ed09a
fix rare flutter_tools logging crash in daemon mode (#14401)
* Populate AnsiTerminal in context for daemon launches

* Strip out AnsiTerminal additions to context since they are no longer needed
2018-02-01 09:30:53 -08:00
Alexandre Ardhuin
841d5d7bd5
prefer_const_declarations on local variables (#14358) 2018-02-01 07:51:26 +01:00
jensjoha
5ccd5a1e75 [kernel/flutter] Improve speed of first hot reload (#13699)
* [kernel/flutter] Improve speed of first hot reload

* [kernel/flutter] Improve speed of first hot reload

* Revert "[kernel/flutter] Improve speed of first hot reload"

This reverts commit f3dc133878.

* Revert "[kernel/flutter] Improve speed of first hot reload"

This reverts commit f7bcb082b0.

* Revert "Revert "[kernel/flutter] Improve speed of first hot reload""

This reverts commit 73c7a1a8e8.

* [kernel/flutter] Improve speed of first hot reload

Do so by not evicting unnecessary paths (while still evicting paths
that was changed between the generation of the package file and the
initial upload).

* Fix grammar in method name

* Fix bad merge

* Add method to super class
2018-01-31 07:39:58 -08:00
Vyacheslav Egorov
340d9e00cf
Fix various strong mode issues. (#14284) 2018-01-31 08:21:32 +01:00
Ian Hickson
3001b3307d
Try to make transitioning channels actually work. (#14353)
* Try to make transitioning channels actually work.

* Update upgrade.dart
2018-01-30 11:37:15 -08:00
Alexander Markov
a0ffbe29ff
Add tracing to print front-end command (#14340) 2018-01-30 08:52:04 -08:00
Todd Volkert
1859e82a3d
Extensibility improvements to flutter_tools (#14299)
* Make the current command injected into the AppContext, allowing
  other classes to inject the current command.
* Introduce `AssetBundleFactory`, an injected factory class for
  spawning instances of `AssetBundle`. This allows other run contexts
  to use custom asset bundling logic.
* Clean up RunCommand by removing a 'packages' argument that duplicated
  a global argument by the same name (and for the same purpose).
  Duplicate arguments are confusing and error-prone.
2018-01-29 09:40:28 -08:00
xster
0c01028351
Update Flutter Gallery Xcode project to a publishable state (#14309) 2018-01-29 01:14:03 -08:00
Martin Kustermann
b2c65e7653
Update path to app.so when using aot compilation to shared library on android (#14302)
This was overlooked in 5e18c07614
2018-01-27 14:21:58 +01:00
Chris Bracken
6854e81bdb
Fix host engine lookup for iOS simulator builds (#14304)
When running with --preview-dart-2, host variant of the engine is
required. Simulator builds, like device builds, should resolve
host_RUNTIMEVARIANT_OPTVARIANT, not host_RUNTIMEVARIANT_sim_OPTVARIANT.
2018-01-26 17:31:49 -08:00
Ian Hickson
64e2e00d6f
Attempt to make flutter compatible with more git versions (#14273)
Fixes https://github.com/flutter/flutter/issues/14232

(I haven't tested this with older versions of git, I'm just going on
what @jason-simmons wrote in the bug.)
2018-01-26 16:59:56 -08:00
Yegor
4c21bf103a
warn about hard-coded version constraints in the upgrade script (#14291) 2018-01-26 12:41:09 -08:00
Todd Volkert
c11f174946
Mark FlutterManifest.createFromString() as visible for testing only. (#14276) 2018-01-26 11:35:38 -08:00
Ian Hickson
014a2255df
Nicer error message for TLS errors (#14285)
Also some trivial improvements to style.
2018-01-26 11:09:23 -08:00
Vyacheslav Egorov
c23509e9fd
Unpin test and upgrade packages (#14282)
* Unpin package:test and upgrade packages

* Update packages/flutter/test/foundation/stack_trace_test.dart

* Also add packages/flutter_tools/test/data/asset_test/font/.dartignore to ensure that update-packages --force-upgrade does not crash.
2018-01-26 10:40:03 -08:00
Vyacheslav Egorov
ae72cea001
Fix an incorrect variable name in Dart 2 flutter test code (#14283)
The code was attempting to delete temporaryDirectory while it should have been deleting tempBundleDirectory
2018-01-25 19:33:24 -08:00
Alexandre Ardhuin
10f721c8a5
use const instead of final with const declarations (#14253) 2018-01-25 19:28:22 +01:00
Ian Hickson
97b9579e55
Random cleanup across the tree (#14221) 2018-01-25 09:46:48 -08:00
Jason Simmons
e0e291011e
Delete test/data/asset_test/main/.packages (#14252)
(this will be generated by flutter update-packages)
2018-01-25 09:39:54 -08:00
Chris Bracken
d3705f3ea9
Add android workflow test (#14260)
Adds unit tests for AndroidWorkflow.runLicenseManager().
2018-01-24 22:27:24 -08:00
Chris Bracken
74478d186c
Extract MockAndroidSdk and static utility method (#14258)
AndroidSdk and AndroidStudio depends relatively heavily on filesystem
access to locate installed tools. Testing code that relies on either of
these classes benefits from a utility method to generate a
legitimate-looking Android SDK directory layout for testing.
2018-01-24 20:40:25 -08:00
Chris Bracken
1058cff395
Add version check for doctor --android-licenses (#14249)
flutter doctor --android-licenses requires Android sdkmanager version 26
or later. When sdkmanager is not available (SDKs earlier than v25),
direct users to SDK upgrade instructions. When it's installed but not
v26 or later, emit instructions to run sdkmanager --update.
2018-01-24 20:01:11 -08:00
Chris Bracken
538ba522ee
Move common process/IO-related mocks to mocks.dart (#14255)
Moves MockProcess, MockStdio and a few other useful mocks from
packages_test.dart to common/mocks.dart. These are useful for testing
code with interactive IO.

This adds a new constructor to MockProcess to provide additional flexibility.
2018-01-24 17:16:30 -08:00
Michael Goderbauer
84580b545a
Make Assets more robust across platforms (#14246) 2018-01-24 13:16:23 -08:00
Chris Bracken
9654659c72
Add AndroidSdk.sdkManagerPath, sdkManagerVersion (#14247)
Convenience getters for the the path to the Android SDK manager and the
currently installed version of the tool.

Pre-factoring to support better checks around the --android-licenses
command, which uses a feature of the SDK manager that is unsupported in
older versions of the tool.
2018-01-24 12:38:08 -08:00
Alexander Aprelev
7c2fe34fbb
Run 'flutter test --preview-dart-2' in strong mode (#14188)
* Default to strong for 'flutter test --preview-dart-2' mode

* Remove empty line

* Dont init to null

* Break up line to make it more readable

* Add missing type annotation
2018-01-22 10:26:01 -08:00
Michael Goderbauer
733bd04904
Fix custom fonts on Windows (#14191)
Fixes https://github.com/flutter/flutter/issues/13870.
2018-01-22 10:00:27 -08:00
Devon Carew
159db5ca44
pass through preview-dart-2, strong, ipv6 in daemon mode (#14200)
* pass through preview-dart-2, strong, ipv6 in daemon mode

* ws change to kick the windows bot
2018-01-20 14:43:23 -08:00
Alexander Aprelev
a92110a265
Clean up build directory before copying freshly produced build artifacts over. (#14081) 2018-01-20 11:11:44 -08:00
Ian Hickson
38ce59f039 [G] Revert "Exclude flutter doctor IDE validators in CI environments" (#14196)
* Revert "Bump async, http, and vm_service_client packages (#14136)"

This reverts commit 7ffcce84a2.

* Revert "Exclude flutter doctor IDE validators in CI environments (#13816)"

This reverts commit 3258c54618.
2018-01-19 20:47:23 -08:00
Sam Rawlins
7ffcce84a2 Bump async, http, and vm_service_client packages (#14136) 2018-01-19 14:59:16 -08:00
Ali Bitek
3258c54618 Exclude flutter doctor IDE validators in CI environments (#13816) 2018-01-19 14:45:10 -08:00
Alexander Aprelev
e910ce7ece
Fix local import paths. (#14183)
This is in attempt to resolve build failure on Windows.
2018-01-19 07:05:28 -08:00
Alexander Aprelev
a50b465c99
Add --preview-dart-2 to 'flutter test' (#14135) 2018-01-19 06:17:28 -08:00
jcollins-g
460dd00b72
Make automated_tests mostly ignore extraneous error messages (#14170)
* Ignore extraneous error messages outside of one skipped test

* Fix analysis error
2018-01-18 14:06:35 -08:00
Ian Hickson
9e42e4b88f
New release process (#14061)
Generate the "version" file from git tags.
Remove the old VERSION file and mentions of versions in pubspec.yaml files.
Replace the old update_versions.dart script with a new roll_dev.dart script.
Update "flutter channel".
Update "flutter upgrade", including making it transition from alpha to dev.
Update "flutter --version" and "flutter doctor".
2018-01-18 07:59:06 -08:00
Mikkel Nygaard Ravn
4353297079
Change default organization name to example.com in project templates (#14116) 2018-01-18 09:21:24 +01:00
xster
0efc06ca45
Disable cocoapods stats in Podfile template (#13945) 2018-01-17 18:17:04 -08:00
Michael Goderbauer
a67df9e1d1
Fix crash during artifact download (#14147) 2018-01-17 16:08:19 -08:00
Michael Goderbauer
bf7cc09625
Moar tests on Windows (#14148) 2018-01-17 16:08:07 -08:00
Ian Hickson
18c60d3301
Fix import statements in flutter_tools (#13911) 2018-01-17 10:17:52 -08:00
jcollins-g
a6e5de2176
Make artifact downloading more robust for flaky networks, take two (#14084)
* Revert "Revert "Make artifact downloading more robust for flaky networks" (#13995)"

This reverts commit 33d8a03545.

* Use subdirectories to organize cached files

* Fix unauthorized import
2018-01-16 08:07:37 -08:00
Vyacheslav Egorov
d9fd4d6f49
Make sure to pass strong mode options down to gen_snapshot (#14118) 2018-01-16 15:38:29 +01:00
Alexander Aprelev
09a6df7461
Clean up output directory before copying over new files (#14085)
* Clean up output directory before copying over new files

* Use standard clean task command
2018-01-14 18:24:07 -08:00
Jason Simmons
e11cf5c94c
Use a safe codec to read Skia SKP screenshot files when checking for errors (#14086)
If the downloaded file is an actual SKP and not an error report, then the
default UTF-8 codec will fail to decode the SKP content
2018-01-12 17:54:49 -08:00
Sam Rawlins
ce939564fa Bump json_rpc_2 dependency (#14051) 2018-01-12 16:23:51 -08:00
Chris Bracken
6a42ed3f55
Decode syslog-encoded iOS logs (#14075)
Apple encodes syslog entries using a 7-bit encoding where input UTF-8 bytes
are encoded as follows:
1. 0x00 to 0x19: non-printing range. Some ignored, some encoded as <...>.
2. 0x20 to 0x7f: as-is, with the exception of 0x5c (backslash).
3. 0x5c (backslash): octal representation \134.
4. 0x80 to 0x9f: \M^x (using control-character notation for range 0x00 to 0x40).
5. 0xa0: octal representation \240.
6. 0xa1 to 0xf7: \M-x (where x is the input byte stripped of its high-order bit).
7. 0xf8 to 0xff: unused in 4-byte UTF-8.

As there doesn't appear to be a system tool to decode these strings, we
implement here in Dart. If we're unable to decode a string (e.g.
decoding results in an invalid UTF-8 string), we fall back to emitting
the log line as-is.
2018-01-12 15:12:26 -08:00
Sam Rawlins
e8b666249a Bump collection dependency to 1.14.5 (#14048) 2018-01-12 14:33:26 -08:00
Alexander Aprelev
a48185a6ad
When targeting iOS sim in preview-dart-2, always compile. (#14059)
Fixes https://github.com/flutter/flutter/issues/14058.
2018-01-11 18:19:28 -08:00
Alexander Aprelev
e2e3c5df05
Reland 9534082fc0 with fix for incremen… (#14040)
* Reland 9534082fc0 with fix for incremental compilation.

When in incremental mode, awaiting exitCode won't work because compiler is not expected to exit after compilation.
Instead listen for stdout stream closing and report error if outputFilename has not been received.

* Fix lints
2018-01-11 14:33:50 -08:00
Alexander Aprelev
bedf987fc8
Pipe strong mode option for iOS simulator. (#14002) 2018-01-11 14:08:28 -08:00
Alexander Aprelev
991765780b
Fix handling --preview-dart-2 for ios (#14016)
* Fix handling --preview-dart-2 for ios

* final var
2018-01-11 13:24:51 -08:00
Devon Carew
ccc0d29454
send 'reloadRecommended' info to IDEs (#13996)
* send 'reloadRecommended' info to IDEs

* rename hint ==> hintMessage
2018-01-11 12:55:00 -08:00
Alexander Aprelev
5dc4ce85d9
Revert "Handle abnormal termination of frontend compiler. (#13982)" (#14037)
This reverts commit 9534082fc0.

Causes hot_mode_dev_cycle__preview_dart_2_benchmark test timeout.
2018-01-10 19:54:08 -08:00
Alexander Aprelev
9534082fc0
Handle abnormal termination of frontend compiler. (#13982)
* Check frontend_server exit code.

When frontend_server completes abnormally, flutter tools has to stop and let user know.

* Add tests
2018-01-10 17:51:08 -08:00
Leaf Petersen
ab874da7be
Roll Dart SDK to 2.0.0-dev.16.0, along with associated package updates (#13857)
Rolling the Dart SDK to 2.0, with associated package updates.  

https://groups.google.com/forum/#!topic/flutter-dev/E22RdKAYjs8
2018-01-10 14:31:28 -08:00
Michael Goderbauer
9e51a60299
Reland #13918 (#14023)
* Revert "Reverting package changes until I can figure out how to fix Windows. (#14007)"

This reverts commit 6fda8ee821.

* Make prepare_package run on Windows
2018-01-10 13:37:36 -08:00
Greg Spencer
6fda8ee821
Reverting package changes until I can figure out how to fix Windows. (#14007)
* Revert "Fixed output validation. (#14005)"

This reverts commit d84398db72.

* Revert "Update package prep script to do async process execution and emit output as it happens. (#13918)"

This reverts commit b7169c1d95.
2018-01-09 19:47:19 -08:00
Greg Spencer
b7169c1d95
Update package prep script to do async process execution and emit output as it happens. (#13918)
- Switches to async process execution, which now shows output as it happens instead of in chunks when the process completes
-  Now uses ProcessManager so that it may be mocked for the test.
- Adds in the download and install of mingit on Windows.
- Updated package dependencies because of added dependency on process package.
2018-01-09 17:42:42 -08:00
jcollins-g
33d8a03545
Revert "Make artifact downloading more robust for flaky networks" (#13995)
* Revert "Change github readme links to be served by github (#13929)"

This reverts commit fd516d9538.

* Revert " Rename SemanticsFlags to SemanticsFlag (#13994)"

This reverts commit 24e3f70536.

* Revert "Make artifact downloading more robust for flaky networks (#13984)"

This reverts commit 4d37e03e1d.
2018-01-09 12:15:58 -08:00
jcollins-g
4d37e03e1d
Make artifact downloading more robust for flaky networks (#13984)
* First version

* Add a clarifying comment

* Add verify to ZipDecoder.decodeBytes call

* Review comments

* Need OS Error for missing files

* FileSystemException, not OSError.
2018-01-09 10:30:42 -08:00
Ian Hickson
9114e2afd1
The dependency script wasn't catching quite all our transitive dependencies (#13954) 2018-01-08 21:39:33 -08:00
Jason Simmons
4954bbfaf9
Read properties files as UTF-8 in Gradle scripts (#13981)
Fixes https://github.com/flutter/flutter/issues/13972
2018-01-08 13:48:08 -08:00
P.Y. Laligand
1954ffcaf5
[fuchsia] dart_package is now dart_library. (#13979) 2018-01-08 13:16:46 -08:00
Alexander Aprelev
c3366a65e1
Set asset directory path only on first hot reload. (#13934) 2018-01-08 10:05:44 -08:00
Mikkel Nygaard Ravn
0a96f96c4f
Update and simplify Android templates (#13970) 2018-01-08 15:01:43 +01:00
Alexander Aprelev
86c6ce99a3
Remove pinning that became obsolete once we moved up to gradle 4.1 (#13963) 2018-01-06 13:42:11 -08:00
Alexander Aprelev
60c5fed12d
Pin connectivity and device_info to unbreak build. (#13959) 2018-01-05 23:52:54 -08:00
Alexander Aprelev
fdbbfc3b32
Pin url_launcher package to prevent major version upgrade (#13952)
* Pin url_launcher to 1.0.3

* Commit results of 'bin/flutter update-packages --force-upgrade'

* Added TODO
2018-01-05 22:54:44 -08:00
Alexander Aprelev
50a28785bd
Update dependencies to bring updated dependency on watcher-0.9.7+6 (#13949) 2018-01-05 21:19:03 -08:00
Alexander Aprelev
27c61eeb50
Explicitly report CFE output(when using --preview-dart-2) (#13936)
* Explicitly report CFE output(when using --preview-dart-2)

* Fix test so it looks at errorText

* Fix expected text
2018-01-05 18:51:35 -08:00
xster
e6e4406de8
Fix simulator not printing to console lines with ) (#13920)
* it's fixed

* Add test for simulator log reader
2018-01-05 11:34:05 -08:00
jcollins-g
e25d881046
Reduce the chances of bots reporting analytics (#13915)
* First version

* Prevent modification of .flutter during analytics test

* Pass in directory and override analyzer warning due to conditional import

* Review comments
2018-01-05 09:38:13 -08:00
Alexander Aprelev
8da5af55c5
Send RPC request to switch assets directory on hot reload. (#12872)
* Send RPC request to switch assets directory on hot reload.

This is needed to pick up updated assets that are expected to be picked up on hot reload.

* Assert assets directory is not null.

* Better multiple future wait

* Add type annotation
2018-01-04 14:27:25 -08:00
Greg Spencer
a04df5bc6b
Updates the package dependencies by running flutter update-packages --force-upgrade (#13906)
This simply updates the package dependencies by running flutter update-packages --force-upgrade.

I'm doing this with no other changes, because the last time I tried that, redness occurred. I want to isolate the problem to a "clean" update of the packages.

It looks like the plugins device_info, connectivity, and url_launcher haven't yet had their gradle configurations updated, so they fail when trying to build with the new gradle. I did not upgrade for those three packages only (in flutter_gallery) until we are ready to fix them (fixing them for master will break them for alpha users, so we need to do an alpha roll to do that).
2018-01-04 10:44:37 -08:00
Siva
426d6b0672
support for --strong option (#13859)
* Plumb a --strong option through to the front end server and the engine
so that we can run flutter apps in preview-dart-2 and strong mode

* - Address analyzer lint issues
*- correctly set up strong mode option in the case of AOT builds
2018-01-04 10:39:02 -08:00
Ali Bitek
7504ac9a04 Fix macOS build for Flutter plugins (#13814) 2018-01-04 10:28:02 -08:00
Mikkel Nygaard Ravn
b6796f426f
Inject plugins before evaluating Gradle project (#13827) 2018-01-02 08:24:21 +01:00
xster
4d2c2aaaa1
Revert pod install skip revert (#13774)
* Revert "Revert "Enable developers to run pod from terminal directly and skip pod install if possible. (#13374)" (#13770)"

This reverts commit 0759043e47.

* some nits on cocoapods code

* put back the FLUTTER_FRAMEWORK_DIR env variable
2017-12-27 07:30:31 -08:00
xster
0759043e47
Revert "Enable developers to run pod from terminal directly and skip pod install if possible. (#13374)" (#13770)
This reverts commit c6a17525e8.
2017-12-27 02:51:44 -08:00
KyleWong
c6a17525e8 Enable developers to run pod from terminal directly and skip pod install if possible. (#13374)
Avoids running pod install if .flutter-plugins and its flutter framework pod dependency didn't change
2017-12-27 01:27:15 -08:00
Alexander Aprelev
70b32e85a3 Use processManager.canRun instead of file existance check. 2017-12-22 17:00:24 -08:00
Alexander Aprelev
a6c963032e Fix gen_snapshot name, path for Windows.
Executables have '.exe' extension on Windows. We do have to specify extension for gen_snapshot since when running with local engine, we are looking for that exact file before launching it.
2017-12-22 17:00:24 -08:00
xster
36bd9ee0d4
update html on flutter_tools (#13744) 2017-12-21 19:13:18 -08:00
Greg Spencer
dd796853cc
Revert "Adding minzip to packaging steps for Windows (#13679)" (#13716)
This reverts commit 765191e7b4.
because the updated packages cause a gradle build problem.
2017-12-20 16:21:57 -08:00
Greg Spencer
765191e7b4
Adding minzip to packaging steps for Windows (#13679)
This adds our self-compiled copy of the MinGit executable (built from the flutter/git repo) to the archive when building an archive for Windows.

I also tweaked the internal API for prepare_package.dart so that there's a single entry point to build an archive.
2017-12-20 15:35:53 -08:00
Victor Choueiri
ba58111b7b Add .vscode/ to .gitignore template (#13697)
Adds .vscode/ to the .gitignore rules generated on flutter create.
2017-12-20 12:43:22 -08:00
Mikkel Nygaard Ravn
36bcdc4c7e
Fix Android templates (#13681) 2017-12-20 10:50:40 +01:00
Alan Russian
30720bd148 Change async stubbing to use thenAnswer. (#13521)
* Change async stubbing to use thenAnswer.

Mockito now prohibits calling thenReturn with Futures and Streams. dart-lang/mockito#79

* Update all Mockito deps to 3.0.0.

* Revert "Update all Mockito deps to 3.0.0."

This reverts commit e8ab9d37c3.

I did not correctly update the mockito dep, and there's no easy way to update to 3.0 alpha right now.

* Change thenAnswer((_) => to thenAnswer((invocation) =>

* Add Invocation type to thenAnswer lambdas
2017-12-19 13:13:57 -08:00
xster
ce75911f1a
Add flutter_assets and *.class to gitignore (#13664) 2017-12-19 10:21:59 -08:00
Mikkel Nygaard Ravn
d2d86e35c5
Bump test timeout threshold (#13661) 2017-12-18 23:04:07 +01:00
Sarah Zakarias
73552ecae2 Remove app.flx on iOS (#13648) 2017-12-18 18:58:44 +01:00
Sarah Zakarias
2ef379ad12
Remove app.flx from apk (#13647) 2017-12-18 14:33:35 +01:00
Chris Bracken
7fb78523e9
Require Xcode 9.0 or later for iOS builds (#13608) (#13622)
We now require Xcode 9.0, which ships with the iOS 11 SDK, for iOS
builds. This change does not affect the minimum supported iOS deployment
target, which remains iOS 8.

The iOS 11 SDK adds support for safe area insets, which model the status
bar, iPhone X home indicator, and symmetric horizontal insets to avoid
the iPhone X sensor housing when in landscape mode.

This re-lands flutter/flutter#13608 now that the devicelab Macs have
been updated to Xcode 9.
2017-12-15 18:13:10 -08:00
amirh
05dba60c63
keep recursing past directories with pubspec.yaml when gathering packages (#13573) 2017-12-15 12:21:03 -08:00
Chris Bracken
6728d4845d
Revert "Require Xcode 9.0 or later for iOS builds (#13608)" (#13612)
Our devicelab machines have not yet been upgraded to Xcode 9. Once this
has been done, I'll re-land this.

This reverts commit 0fac5f01a2.
2017-12-15 11:59:42 -08:00
Chris Bracken
0fac5f01a2
Require Xcode 9.0 or later for iOS builds (#13608)
We now require Xcode 9.0, which ships with the iOS 11 SDK, for iOS
builds. This change does not affect the minimum supported iOS deployment
target, which remains iOS 8.

The iOS 11 SDK adds support for safe area insets, which model the status
bar, iPhone X home indicator, and symmetric horizontal insets to avoid
the iPhone X sensor housing when in landscape mode.
2017-12-15 11:44:01 -08:00
amirh
becab558e1
flutter update-packages (#13571)
* flutter update-packages

* update plugin registrant for flutter_gallery
2017-12-14 10:07:51 -08:00
amirh
7d90bfc179
Pin the test package to 0.12.26 (#13546) 2017-12-14 08:52:56 -08:00
Phil Quitslund
3346c5c736
Update plugin test template. (#13516)
* Update plugin test template.

* Add flutter test run verification.

* Tweak and test runs for package projects.
2017-12-14 08:51:33 -08:00
Sarah Zakarias
5e18c07614
Reapply flutter_assets (#13567)
* Revert "Revert engine (#13547)"

This reverts commit ee65db11d4.

* Keep flaky mark
2017-12-14 17:27:25 +01:00
Sarah Zakarias
5c90c35f22
Write flutter_assets directory on Windows (#13564) 2017-12-14 16:08:31 +01:00
Mikkel Nygaard Ravn
5ae507a752
Revert "Refresh template instances (#13563)" (#13565)
This reverts commit 05d6b08ffe.
2017-12-14 15:38:39 +01:00
Mikkel Nygaard Ravn
05d6b08ffe
Refresh template instances (#13563) 2017-12-14 15:19:59 +01:00
Mikkel Nygaard Ravn
a2296aa8e3
Simplify project template (#13558) 2017-12-14 11:38:20 +01:00
Michael Goderbauer
e5846d962e
Verify that committed GeneratedPluginRegistrant are up-to-date (#13541) 2017-12-13 17:49:54 -08:00
Yegor
ee65db11d4
Revert engine (#13547)
* Revert "Include a directory with Flutter assets (#12944)"

This reverts commit 3af6b9cbf5.

* Revert "Upgrade project.pbxproj to include flutter_assets (#13011)"

This reverts commit 08128cb29b.

* Revert "Upgrade complex_layout project.pbxproj to include flutter_assets (#13544)"

This reverts commit 35f1a04195.

* mark complex_layout_ios__start_up as flaky
2017-12-13 16:25:25 -08:00
Sarah Zakarias
08128cb29b
Upgrade project.pbxproj to include flutter_assets (#13011) 2017-12-13 23:02:10 +01:00
Sarah Zakarias
3af6b9cbf5
Include a directory with Flutter assets (#12944) 2017-12-13 22:30:32 +01:00
Mikkel Nygaard Ravn
e5aac6928b
Support Android Gradle plugin v3.0.1 (#13492) 2017-12-13 12:16:22 +01:00
Mehmet Fidanboylu
951b85a12b
Increase coverage collection timeout to 2 minutes. Leafy is hitting the limits of the previous timeout of 30 seconds for tests that touch a lot of code in the app. (#13527) 2017-12-12 15:54:18 -08:00
Greg Spencer
6b8ceb9472
Make the create command call pub get online instead of offline. (#13505)
We thought it would be OK to call the create command offline-only, but it turns out that isn't a great idea because not all of the create template dependencies are cached by running flutter_tool.

This PR makes it go online by default when running pub get after creating a project, and adds an "--offline" flag to the create command so that offline users can use it offline if their cache is warm.
2017-12-11 21:21:41 -08:00
Ben Konyi
0ca1af7e4f Removed additional dead code. 2017-12-11 11:13:16 -08:00
Ben Konyi
90ad465f8e Removed dead code. 2017-12-11 11:13:16 -08:00
Ben Konyi
08c2e0771f Removed special cases for '.exe'. 2017-12-11 11:13:16 -08:00
Ben Konyi
bf33eb78c5 Enabling 'flutter test' for Windows (woohoo!). 2017-12-11 11:13:16 -08:00
Ben Konyi
3fe19d95c6 update_script 2017-12-11 11:13:16 -08:00
Matt Sullivan
51ab5f36c6 Fix template for the driver test file created by 'flutter create' (#13472) 2017-12-08 20:39:56 -08:00
Ian Hickson
186d1e9b0d
Have the framework in charge of scheduling frames. (#13344)
...instead of the engine.
2017-12-08 16:51:59 -08:00
Greg Spencer
aedee0df3d
Make create command use pub in offline mode. (#13462)
In order to allow offline usage of the create command we need to be able to tell pub not to try and contact the server to see if new versions are available. Since all the versions that create could want are pinned, it shouldn't need to check for new versions.
2017-12-08 15:32:10 -08:00
Zachary Anderson
927a143d79
[flutter_tools][plugins] generated registerWith guards against re-registration (#13384) 2017-12-08 09:38:02 -08:00
Yusuke Konishi
ca5ab1b42a Remove unnecessary error message when cocopods is not available (#13241)
* Remove unnecessary error message

* Add AUTHOR
2017-12-07 18:48:59 -08:00
Kevin Moore
64feb95ada
Revert "(cleanup) standardize on shouldRunPub and usesPubOptions() in commands (#13427)" (#13430)
This reverts commit 9315a79b11.

There is an unfortunate interaction with verifyThenRunCommand
2017-12-07 14:29:12 -08:00
Kevin Moore
9315a79b11
(cleanup) standardize on shouldRunPub and usesPubOptions() in commands (#13427) 2017-12-07 13:31:32 -08:00
Devon Carew
0350c9ecff
route device issue diagnostics to flutter doctor (#13346)
* route device issue diagnostics to flutter doctor

* review comments

* review comments
2017-12-07 09:32:23 -08:00
Jakob Andersen
e1018fab34
Make artifacts URLs configurable. (#13380)
Add support for configuring the base storage URL for Flutter's
artifacts. If FLUTTER_STORAGE_BASE_URL is set, use it instead of
storage.googleapis.com.

The pub server can be overridden by setting PUB_HOSTED_URL.
2017-12-07 16:30:23 +01:00
Greg Spencer
389e13f8b9
Fixing the pub get test so that it doesn't care what the flutter root looks like. (#13385) 2017-12-06 13:27:29 -08:00
Kevin Moore
13a6d40f90
flutter_tools: ensure the context value passed to pub is consistent (#13366)
Adds a class `PubContext` with a fixed set of allowed values
Make it clear these values should not be changed casually

Fixed one inconsistency already: update_packages vs update_pkgs
Provide more information for verify calls
Eliminate `ctx_` prefix.
2017-12-06 08:10:56 -08:00
Devon Carew
cbcdd03ef0
some wording tweaks to the doctor text (#13356) 2017-12-06 08:05:51 -08:00
Greg Spencer
f29ecba6de
Use .pub-cache from Flutter root, if it exists. (#13358)
The purpose of this PR is to make it so that when the user runs 'flutter', if they have a .pub-cache directory in their flutter root, we use that instead of the default location for the pub cache. Otherwise, it should act as before.

The eventual goal is to support a pre-populated flutter .zip/.tar.gz file that has everything the developer needs in one bundle. In order for that to actually work, we need to have the pub cache be self-contained, and not in the user's home dir.

Another advantage of this is that if you have multiple flutter repos that you're switching between, then the versions in the pub cache will remain static when you switch between them.

This is an attempt to re-land: #13248. Includes a fix for the test that makes it work on bots in the presence of PUB_CACHE being set, and no other changes.
2017-12-05 14:46:39 -08:00
Greg Spencer
c89cf6ccc6
Reverting my .pub-cache change to figure out why it's still failing. (#13355)
* Revert "Add tests."

This reverts commit 31bad961ff.

* Revert "Use .pub-cache from Flutter root, if it exists. (#13248)"

This reverts commit 72d6bcc3f7.
2017-12-05 12:51:18 -08:00
Greg Spencer
3174443e0e
Fix a problem with the flutter_tools/test/dart/pub_get_test.dart test. (#13354)
It turns out that when a PR build clones the flutter repo, it puts it into a directory called "flutter", and when the "real" build clones the flutter repo, it puts it into a directory called "build". This allowed the tests to succeed in my PR, but fail when I committed it.

This fixes the test so it doesn't depend on the cloned directory name.
2017-12-05 12:30:13 -08:00
Greg Spencer
72d6bcc3f7
Use .pub-cache from Flutter root, if it exists. (#13248)
The purpose of this PR is to make it so that when the user runs 'flutter', if they have a .pub-cache directory in their flutter root, we use that instead of the default location for the pub cache. Otherwise, it should act as before.

The eventual goal is to support a pre-populated flutter .zip/.tar.gz file that has everything the developer needs in one bundle. In order for that to actually work, we need to have the pub cache be self-contained, and not in the user's home dir.

Another advantage of this is that if you have multiple flutter repos that you're switching between, then the versions in the pub cache will remain static when you switch between them.
2017-12-05 12:02:14 -08:00
Martin Kustermann
3280f23452
Use only one message for NDK discovery, remove accidental newline (#13348) 2017-12-05 18:17:28 +01:00
Alexander Markov
a69af9902c
Pass --aot option to front-end server when generating kernel for AOT build (#13342) 2017-12-04 16:57:44 -08:00
Kevin Moore
c25608d83b
Provide more information in PUB_ENVIRONMENT for pub get/upgrade (#13307)
* Provide more information in PUB_ENVIRONMENT for `pub get/upgrade`

Should help diagnose and fix https://github.com/dart-lang/pub-dartlang-dart/issues/636
2017-12-01 16:20:06 -08:00
Phil Quitslund
acbc16afd4
Swift templates tweaks. (#13291)
Dropped optional semicolons.
2017-12-01 10:54:56 -08:00
Phil Quitslund
a4bc470fa5
Tweak access to linter internals in package validation. (#13297)
A more future-proof approach to accessing internal package name lint rule description details.

See: https://github.com/dart-lang/linter/issues/654
2017-12-01 10:54:24 -08:00
Chris Bracken
1d6bb3ccbf
Update quiver dependency to 0.26.2 (#13299)
Updates quiver from 0.26.0 to 0.26.2 to pick up strong-mode fixes.
2017-12-01 10:28:59 -08:00
Jakob Andersen
5174dbaff5
Download our own copy of gradle wrapper. (#13267)
Rather than depending on android.googlesource.com for hosting the gradle
wrapper, host our own copy on storage.googleapis.com (along with our
other artifacts).

Also added a script to repackage AOSP's version into ours, in case we
ever need to update it.

Addresses the gradle wrapper part of #11681.
2017-12-01 09:39:13 +01:00
Alexander Aprelev
5a1dcdb427
Fix --preview-dart2 option handling for ios profile/release. (#13285)
* Fix --preview-dart2 option handling for ios profile/release.

* Remove unused parameter
2017-11-30 17:17:39 -08:00
Yegor
e809511682
remove dependency on package:quiver/iterables.dart (#13281) 2017-11-30 15:09:39 -08:00
Alexander Aprelev
42ca92c756
Hide preview-dart-2 flag. Show only in verbose (#13270) 2017-11-30 10:36:46 -08:00
Alexander Aprelev
4447c0aaf3 Add --preview-dart-2 option support for ios builds (#13251) 2017-11-29 18:11:34 -08:00
Mehmet Fidanboylu
b61cbc735e
Add capability to print engine dart sdk to flutter doctor (#13085)
* Add capability to print engine dart sdk to flutter doctor

* First round of review comments

* second round of comments

* Final review comments
2017-11-29 11:03:50 -08:00
Todd Volkert
137f0751b2
Add support for IOS_SIMULATOR_HOME environment variable in IOSSimulat… (#13236)
Add support for IOS_SIMULATOR_HOME environment variable in IOSSimulator.logFilePath

flutter_tools can be run on environments where the user's HOME directory
is not the root of the iOS simulators' configs. This change adds support
for such environments by allowing the caller to set the simulator root
directory via an environment variable.
2017-11-29 08:22:05 -08:00
Greg Spencer
909406ba25
Consolidating .gitignore files. (#13002)
This consolidates all of the non-template .gitignore rules into the top level .gitignore, to ignore common things more broadly, with less maintenance needed for the .gitignore files. Does not touch the templates, so that they still produce needed .gitignores as part of flutter create.
2017-11-28 17:06:57 -08:00
Greg Spencer
fc2f3b4f0f
Updated run configurations with catalog examples. (#13099) 2017-11-28 16:04:30 -08:00
xster
7ad69b38b0
Update xcode project template to 9.1 (#13193) 2017-11-28 15:49:00 -08:00
Todd Volkert
c182e0e517
Remove unused pushFile methods in ios classes (#13215) 2017-11-27 12:55:59 -08:00
Devon Carew
c25558d426
change 2 print calls to printStatus (#13206) 2017-11-27 08:13:24 -08:00
Devon Carew
d776f64f4e
tweaks to the cli args for flutter run (#13207) 2017-11-27 06:56:51 -08:00
Dwayne Slater
c7c3b606fc Show Android tombstone during native crash (#12923)
* Show Android tombstone during native crash

* Fix tombstone lines being missed on newer Android versions
2017-11-22 14:58:59 -08:00
Todd Volkert
e792c6bb5b
Add support for binding to IPv6 localhost in flutter run (#13136)
This allows `flutter run` to work on hosts that are IPv6-only.
2017-11-21 20:12:21 -08:00
Chris Bracken
d6a35ee356
Update dart:vmservice_sky to vmservice_io (#13138)
In 77af1e5eec, dart:vmservice_sky was
renamed to dart:vmservice_io.
2017-11-21 16:23:33 -08:00
Martin Kustermann
545ec9efb7
Add support for NDK discovery and add --prefer-shared-library option (#12788)
* Add support for NDK discovery and add --prefer-shared-library option

We would like to be able to use native tools (e.g. simpleperf, gdb) with
precompiled flutter apps.  The native tools work much better with *.so
files instead of the custom formats the Dart VM uses by default.

The reason for using blobs / instruction snapshots is that we do not
want to force flutter users to install the Android NDK.

This CL adds a `--prefer-shared-library` flag to e.g. `flutter build
apk` which will use the NDK compiler (if available) to turn the
precompiled app assembly file to an `*.so` file.  If the NDK compiler is
not available it will default to the default behavior.

* Rebase, add test for NDK detection, augment flutter.gradle with @Input for flag

* Use InMemoryFileSystem for test

* Remove unused import

* Address some analyzer warnings
2017-11-21 15:44:03 +01:00
Mikkel Nygaard Ravn
4676e1d724
Add support for iOS plugin class prefix (#13095) 2017-11-20 13:27:21 +01:00
Todd Volkert
928d2cc764
Add EBADF errno to list of ignorable errors in terminal.dart (#13077)
I get this error when piping an `echo` string to the stdin of
the flutter tool.

https://github.com/dart-lang/sdk/issues/29083
2017-11-17 15:45:27 -08:00
Greg Spencer
0259be90b8
Fix spelling errors in all the dartdocs. (#13061)
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.

This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
2017-11-17 10:05:21 -08:00
xster
d5d2cdfeef
A bunch of onboarding error detections (#12977) 2017-11-16 22:53:22 -08:00
Todd Volkert
f0e8819886
Extract Android SDK version from named platform dirs. (#13056)
Previously, we were mapping certain named platforms
(e.g. `android-stable`) to their corresponding version.
this had two problems:

1. The version could become out of date. For instance, we had
   mapped `android-stable` to version 24, but the stable version
   is now 27.
2. The list of possible named versions wasn't comprehensive.
   Some Android SDKs just list the platform as `stable`, or
   `experimental`, etc.

This change updates the platform version detection to use
the `build.prop` file that exists in the platform directory
(only for cases where the version number is not encoded into
the directory name).
2017-11-16 17:38:53 -08:00
xster
9a0d4cf75b
Add a Flutter version comparison function (#12959)
* add git version comparison function

* use [] in dartdoc

* Make method instance method
2017-11-14 18:50:15 -08:00
Greg Spencer
7adb720dcc
Fixed a typo that I forgot to push before committing ide-config change. (#12998) 2017-11-13 15:27:16 -08:00
Greg Spencer
2a26f29c9d
Switch to concurrency of two, to see if that is a good balance. (#13003) 2017-11-13 15:26:42 -08:00
Greg Spencer
e2b9f8906d
Turn on concurrency for coverage shard so that it runs in parallel to fix Travis timeouts. (#13001) 2017-11-13 13:20:38 -08:00
Greg Spencer
797b39e9b2
Creates a new flutter command 'ide-config' and removes *.iml and .idea from tree. (#12958)
Creates a new (hidden) flutter command 'ide-config' that will create and/or update
existing .iml files and some files under the .idea directory, as well as
removing existing *.iml files and the .idea directory.

It also:

 * Adds *.iml to the .gitignore
 * Removes existing .iml files from the repo, and moves them to the
   packages/flutter_tools/ide_templates/intellij directory.
 * Adds a flag to ide-config ('--update-templates') that will take any new .iml
   files in the flutter tree and add them to the existing templates.
     - If --overwrite is also specified, then all existing templates will also
       be overwritten with the contents from the flutter tree, and any that have
       been deleted from the flutter tree will also be removed from the
       templates.
 * Added new run configurations for all existing app targets that will now also
   be automatically added to IntelliJ.
 * Setting up the environment also includes setting the coding style guidelines
   and the git VCS.
 * Note that after this PR lands, Flutter developers will need to run it once to
   re-create the .iml files and configuration files that have been removed.

After this PR lands, .iml files will no longer appear in the untracked files
section for git.
2017-11-13 10:55:22 -08:00
Jakob Andersen
9be85b6b4b
Support IPv6-only hosts in vmservice_test.dart. (#12985)
If we fail to bind to IPv4 loopback, try IPv6. Some hosts only support IPv6,
causing the test in vmservice_test.dart to fail, since it couldn't find an
available port.
2017-11-11 21:33:40 +01:00
Mehmet Fidanboylu
96942bc797
Get rid of static version methods which ignore the AppContext (#12971)
* Get rid of static version methods which ignore the AppContext

* Review comments

* Review Comments

* Make branch behave the same as original implementation

* Fix tests
2017-11-10 17:31:18 -08:00
Yegor
870da175bc
remove unused forwardPort; truthier console messages (#12981) 2017-11-10 16:51:16 -08:00
xster
e94038154b
Print a warning when cocoapods specs repo is out of date (#12915) 2017-11-10 12:41:58 -08:00
Devon Carew
60af4ed725
tweak the text for the "elements didn't reload" message (#12826)
* tweak the text for the 'elements didnt reload' message

* review comments

* prefix items with a list char

* add a hostIsIde param instead of the isDaemonMode top-level function

* add a trailing comma
2017-11-10 11:34:34 -08:00
Zachary Anderson
f993cc36dd [flutter_tool] Fix fuchsia_reload command for new .packages location (#12825) 2017-11-10 10:10:07 -08:00
Alexander Aprelev
9ae893bd45
Use IKG for restarts, use IKG with ProtectedFileByteStore. (#12953)
* Use IKG for restarts, use IKG with ProtectedFileByteStore.

* Fix comment, add end of file newline.

* Remove unused import
2017-11-10 10:09:37 -08:00
Alexander Aprelev
edc0781420
Reset list of dirty assets to be evicted when we do restart (#12743) 2017-11-10 09:24:05 -08:00
Mikkel Nygaard Ravn
c936aa8cd4
One more timeout. Centralize definitions. (#12970) 2017-11-10 15:56:17 +01:00
Mikkel Nygaard Ravn
e3d5cbc929
Make timeout more robust (#12969) 2017-11-10 13:51:52 +01:00
Mikkel Nygaard Ravn
a836201a74
Raise timeout limit for tests that call pub (#12968) 2017-11-10 12:33:34 +01:00
Mikkel Nygaard Ravn
46b2d6462e
Update timeouts for flutter create tests (#12965) 2017-11-10 09:35:11 +01:00
Todd Volkert
454db9d47c
Re-organize flutter_tools code to better support proper layering. (#12957)
* executable.dart#main() depends on runner.dart#run()
* Refactor code such that non-commands don't depend on commands.

No code was actually changed in this PR - code was merely moved from
point A to point B.
2017-11-09 21:45:31 -08:00
Devon Carew
b6bd628bcd
address unused element issues and new warnings (#12890)
* address unused element issues and new warnings

* add a missing return
2017-11-08 14:06:55 -08:00
Alexandre Ardhuin
15601fe55c
Enable lint prefer asserts in initializer lists (#12903)
* enable lint prefer_asserts_in_initializer_lists

* enable --assert-initializer
2017-11-08 22:59:49 +01:00
Yegor
d4830fcf1b
smoke test VM service connection before returning VMService object (#12914) 2017-11-08 10:43:47 -08:00
xster
8f79643680
Error message for unregistered phone (#12911) 2017-11-07 13:23:43 -08:00
xster
c17099f474
Leave a version tag when creating project (#12846)
* Leave a version tag when creating project

* Generalize .version to .metadata
2017-11-03 10:07:57 -07:00
Ian Hickson
d402d40aa6
Up a timeout to reduce the number of flakes. (#12837) 2017-11-02 12:19:43 -07:00
Chris Bracken
83df7bdd0f
Update Dart package dependencies (#12829) 2017-11-01 15:28:46 -07:00
Ian Hickson
8fd20b5deb
Text Painting Fuzzer (#12813)
Various improvements (in particular a new painting fuzzer) to the text manual test.

Some additional documentation.

A fix to Stack to remove an LTR bias: make unpositioned children apply "alignment".

Some more debugging information on RichText and Text.

A fix to the flutter tool to not crash when an RPC call throws an exception.
2017-11-01 15:04:43 -07:00
Ian Hickson
e1174eb0f2
TextPainter RTL (#12791) 2017-10-31 10:39:34 -07:00
Jason Simmons
cb2cfac0eb
Check for presence of an asset directory before accessing it (#12790)
Fixes https://github.com/flutter/flutter/issues/12460
2017-10-30 17:04:30 -07:00
Jason Simmons
1affb4237a
Remove the diagnostic server from flutter_tools (#12771) 2017-10-30 15:53:04 -07:00
Adam Barth
21145144e9
Don't collect usage data during Fuchsia build (#12780)
Previously, the usage analytics would generate a write to the user's
HOME directory during the Fuchsia build. We're tightening down the
environment in which we run the Fuchsia build, and these writes are now
more obvious.

This patch removes the usage analytics during the Fuchsia build,
avoiding the write to the user's HOME directory.
2017-10-30 12:28:31 -07:00
Michael Thomsen
50db9478e3
Clarify how to unconfigure with flutter config (#12733) 2017-10-30 11:12:12 +01:00
Chris Bracken
acdbe45670
Report error on iOS non-release archive builds (#12773)
Archive builds for upload to iTunes Connect should always be built in
release mode, not doing so results in crash on startup.

Bug: https://github.com/flutter/flutter/issues/12086
2017-10-27 18:23:50 -07:00
Yegor
89a4a1384c unpin linter version, skip the broken 0.1.37 version (#12737) 2017-10-26 12:39:07 -07:00
Yegor
154f2e5402 Reapply #12700 but keep linter pinned at 0.1.35 (#12735)
* Revert "Revert "fix --force-upgrade script; upgrade to the latest package versions (#12700)" (#12729)"

This reverts commit 7f0d4f4caa.

* keep linter pinned at 0.1.35
2017-10-26 09:55:36 -07:00
Yegor
7f0d4f4caa Revert "fix --force-upgrade script; upgrade to the latest package versions (#12700)" (#12729)
This reverts commit 5b3575006e.
2017-10-25 17:08:08 -07:00
Yegor
5b3575006e fix --force-upgrade script; upgrade to the latest package versions (#12700)
* fix updrade script; upgrade to the latest package versions

* exclude special dependencies from transitive closure

* fix stack trace handling in flutter_test due to stack_trace change

* change type on _emptyStackTrace
2017-10-25 16:12:43 -07:00
Phil Quitslund
2b2b3ab516 Use a package URI in test template import. (#12723)
Use a `package:` import when referencing source under test in test template.

This is the prefered style and plays nice w/ automated refactoring.

See: https://github.com/flutter/flutter-intellij/issues/1429
2017-10-25 14:53:46 -07:00
Alexandre Ardhuin
28366002d9 enable lint prefer_foreach (#12674)
* enable lint prefer_foreach

* fix tests
2017-10-25 08:25:44 +02:00
Alexandre Ardhuin
872d83a3c5 enable lint prefer_conditional_assignment (#12694) 2017-10-25 08:18:26 +02:00
Alexandre Ardhuin
1fce14a31c enable lint prefer_single_quotes (#12665) 2017-10-22 18:11:36 +02:00
Jason Simmons
eb475bbb80 move dart_io_entries.txt to third_party/dart for AOT builds with a local engine (#12659) 2017-10-20 15:32:27 -07:00
Devon Carew
171b1b08c9 tweak the flutter create template to use the function shorthand for main() (#12654) 2017-10-20 10:46:07 -07:00
Devon Carew
a554401e79 update the flutter create template files (#12641) 2017-10-19 19:38:39 -07:00
Michael Goderbauer
1eed6dff34 Make clean command top level (#12616)
* Make clean command top level

Fixes https://github.com/flutter/flutter/issues/10783

* remove backwards
2017-10-19 11:23:42 -07:00
Chris Bracken
e965b69285 Improve libimobiledevice doctor messages (#12633)
The libimobiledevice suite of tools do not include version information.
A simple way to verify they meet our version requirements is to run
idevice_id -l, which will fail when older versions are run against iOS
devices with newer versions of iOS installed.

Unfortunately, idevice_id -l will also fail when libimobiledevice is up
to date, but the attached devices have never been paired with the host
machine in Xcode.

This patch updates the error message to help guide the user in such
situations.
2017-10-19 10:52:25 -07:00
Alexander Aprelev
c05da1e29d Stop syncing dart source files when in --preview-dart-2. (#12597)
Syncing source files is not needed when host sends kernel file to the device.
2017-10-19 07:16:15 -07:00
Alexandre Ardhuin
700dc9f752 enable lint avoid_function_literals_in_foreach_calls (#12607) 2017-10-19 08:16:16 +02:00
P.Y. Laligand
e938ceb086 Adjust to new location for the Dart project. (#12621) 2017-10-18 19:45:48 -07:00
Mihail Slavchev
af0afff111 Workaround a connection issue on iOS 11.0.x (#12444)
On iOS 11.0.x ideviceinfo fails with the following message
ERROR: Could not connect to lockdownd, error code -3

This workaround should also work for #12330
2017-10-18 15:25:49 -07:00
Adam Barth
f847272fc7 Make FLX construction atomic (#12604)
This patch also makes it possible to create FLX files with no extension.
Previously, the zip tool would add the ".zip" extension if the output file
lacked an extension.
2017-10-18 13:46:17 -07:00
Sarah Zakarias
f6135107bc Copy snapshot file into assets (#12523) 2017-10-18 14:52:36 +02:00
Alexander Aprelev
52fbcefed6 Link platform.dill only into app kernel file used for build aot. (#12571)
gen_snapshot loads all packages from single app kernel file.
2017-10-17 13:30:32 -07:00
xster
9ce3ba314e Add Cupertino icon fonts helper and dependency for default template (#12559)
* add CupertinoIcons

* Use new font name convention

* review
2017-10-16 18:59:28 -07:00
P.Y. Laligand
ad72c78342 Fix testing on Fuchsia. (#12563) 2017-10-16 10:58:39 -07:00
Alexander Aprelev
be1467e0cd Restructure hot mode test so it runs interactively. (#12519)
* Restructure hot mode test so it runs interactively.

This allows to add a benchmark for hot reload after actual source code change.

* Add curly braces, refactory copyRecursive
2017-10-13 20:06:35 -07:00
P.Y. Laligand
0999fca99d Update references to the engine project. (#12515) 2017-10-13 17:16:33 -07:00
Alexander Aprelev
6c6d08b9ee Keep incremental compiler state through full restart. (#12535)
* Keep incremental compiler state through full restart.

* Add todo

* Add todo
2017-10-13 15:18:24 -07:00
Ryan Macnak
07a4b4c426 Reapply "When parts of the program are changed in a hot reload, but not executed during the reassemble, warn that a restart may be needed." (#12490)
This reverts commit 5e7bcbacf8.

`flutter run --benchmark` was triggering a different quick bailout path in the VM than `flutter run`. The failure has been fixed upstream.
2017-10-12 15:58:40 -07:00
Alexander Aprelev
85e4f0526b Fix restart flow for preview-dart-2 mode. (#12496)
* Fix restart flow for preview-dart-2 mode.

Restart in preview-dart-2 needs to use kernel file and it has to be complete, rather than incremental kernel file.

* Add curly braces

* Do full compile on restart

* Roll engine to pick up changes to hot reload for preview-dart-2
2017-10-12 14:48:37 -07:00
Ryan Macnak
a4b29d6414 Pass --enable_mirrors=false when building script snapshots for the debug mode. (#12472)
The initial loading happens on the host, which was building a script snapshot and allowing imports of dart:mirrors. Hot reload happens on the device, which then notices the imports and issues a compile-time error. This change causes programs with imports of dart:mirrors to be rejected during the initial load.

Fixes https://github.com/flutter/flutter/issues/12440
2017-10-12 14:46:37 -07:00
Hans Muller
c3d56b1dad flutter_localization optional package (#12410) 2017-10-11 16:01:13 -07:00
Zachary Anderson
4c23397eda Remove dead --assert_initializer flag (#12441) 2017-10-06 14:54:14 -07:00
P.Y. Laligand
21b81d902d Disable Dart analysis in Fuchsia. (#12409)
Fuchsia will soon use a newer version of the Dart analysis server which Flutter code has not been adjusted for yet.
2017-10-06 10:47:52 -07:00
Alexander Aprelev
ac1546c794 Add hotReloadInitialDevFSSyncMilliseconds to track how long user have… (#12417)
* Add hotReloadInitialDevFSSyncMilliseconds to track how long user have to wait before being able to do first reload.

This stat is significantly different between existing and preview-dart-2 setting (for the latter, this stat is ~3x slower: 13s vs ~4s).

* Remove ws

* Cleanup timer-related code
2017-10-06 08:39:46 -07:00
Alexander Aprelev
c02850b4dc Force upgrade update packages with improved update process. (#12412)
* Force upgrade update packages with improved update process.

* Update packages

* Revert "Update packages"

This reverts commit a37de26d3f.
2017-10-05 20:59:08 -07:00
stevemessick
2b78675bd8 Update IDEA project files (#12391)
* Generate Android framework config

* Fix templates

* Moar templates fixing

* Minor tweaking
2017-10-05 12:56:49 -07:00
Alexander Aprelev
d5ba4df6af Skip over flutter sdk packages when upgrading dependencies. (#12405) 2017-10-04 17:50:10 -07:00
Ryan Macnak
5e7bcbacf8 Revert "When parts of the program are changed in a hot reload, but not executed during the reassemble, warn that a restart may be needed. (#12304)" (#12406)
This reverts commit 90028813a8.

This change caused a few bots to fail with 'JSON-RPC error 110: Extension error', which is odd because _getUnusedChangesInLastReload is not an extension.
2017-10-04 17:13:17 -07:00
Ryan Macnak
90028813a8 When parts of the program are changed in a hot reload, but not executed during the reassemble, warn that a restart may be needed. (#12304) 2017-10-04 16:32:30 -07:00
Devon Carew
02429cef84 Fix the doctor check for the flutter intellij plugin (#12389)
* update the intellij doctor check to support the m18 plugin version

* update to support multiple package names
2017-10-03 16:24:18 -07:00
stevemessick
b9f20dc335 Print "package" instead of "plugin" when creating a package. (#12387) 2017-10-03 16:06:33 -07:00
Alexander Markov
7153dea296 Add hidden options --extra-front-end-options and --extra-gen-snapshot-options to flutter tool (#12219)
This CL introduces 2 hidden options to 'flutter build aot' and 'flutter run' for passing arbitrary arguments to front-end server and to gen_snapshot tool when building and running flutter app in --profile or --release modes.

The ability to pass arbitrary options simplifies various experiments, as it removes the need to change defaults and rebuild flutter engine for every tested configuration.
2017-10-03 12:55:53 -07:00
gspencergoog
18f0d3aef7 Add framework support for system text scale factor. (#12180)
* Add framework-side support for system text scale factor.

* Rolling engine to e3404b81a53ba3180c7623a6f2190ebb28518f30
  Additional changes rolled in with engine change:
    libtxt: implementation of GetRectsForRange that processes a line at a time - e3404b8
    Provide an entropy source to the Dart engine (#4161) - e1aa867
    libtxt: search for fallback fonts that can match emoji and CJK characters - 8061df1
    Roll skia to e4679fa06a. (#4157) - 267e7a8
    Update buildroot to 53fea9aebb (#4160) - 02ea7ae
    Revert engine Dart roll. (#4158) - 14aab33
    Add support for system text scale factor. (#4124) - b2a7f4b
    Include _http into sky_engine libraries for analyzer (#4154) - b930f10
    libtxt: Remove postprocess_line and improve tracking of X offsets - 86f95f0
    libtxt: remove redundant line_widths (#4152) - 14bf515
    Roll dart to ade37f931e90b0fdb8fe16d6bf6f089545da55b6 (#4151) - 6f1264f
2017-10-02 14:18:18 -07:00
Ian Hickson
89566feeed Run pub with --trace (#12328)
See https://github.com/dart-lang/pub/issues/1714
2017-09-29 17:56:25 -07:00
Michael Thomsen
3f6b28dddb Add a check for gradle failing due to missing licenses (#12318)
* Add a check for gradle failing due to missing licenses

* Review feedback Jakob
2017-09-29 13:49:38 +02:00
Ian Hickson
e1fa035b69 Retry on failed download. (#12293) 2017-09-28 17:37:34 -07:00
Todd Volkert
ce59412cf2 Remove hard-coded "Runner" from iOS simulator logs filtering (#12306) 2017-09-28 13:11:16 -07:00