Matan Lurey
bf4ef7486b
Roll-foward: "Remove legacy platforms in .ci.yaml with 0 usages" ( #169882 )
...
This reverts commit 99f74987aahttp://go/flutter-cl/66120 to avoid future
failures.
2025-06-02 21:35:30 +00:00
auto-submit[bot]
99f74987aa
Reverts "Remove legacy platforms in .ci.yaml with 0 usages. ( #169783 )" ( #169799 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#169783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaks `Linux ci_yaml flutter roller`
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20ci_yaml%20flutter%20roller/19333/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {zanderso}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-05-30 23:35:47 +00:00
Matan Lurey
11bf180af0
Remove legacy platforms in .ci.yaml with 0 usages. ( #169783 )
2025-05-30 21:05:18 +00:00
Matan Lurey
cfd7c9cbfa
Mark Linux web_tool_tests as bringup due to being 10%+ flaky ( #169716 )
...
See https://github.com/flutter/flutter/issues/169574 .
2025-05-29 23:31:00 +00:00
Nicholas Shahan
422d8d2dad
[tests] Increase linux timeout and skip on others ( #169627 )
...
With this change the web.shard test suite runs all existing tests on all
platforms with the version of the web debug builds that is the flutter
tools default (does not support stateful hot reload).
The linux bot configuration will also run some of the tests using the
new web debug build (supports stateful hot reload). The timeout has been
increased for this configuration to allow the additional tests to run to
completion.
The mac and windows configurations skip all tests for the new web debug
builds.
In the future the new build output will become the flutter tools default
and the balance of where the tests tests are run will flip until the
ability to opt out of the new build output is removed.
This change is not ideal because we are still not fully testing all
features with the two versions of the web debug builds that are
available to users. If given the opportunity we should add additional
bot configurations to run all the tests with the output that supports
stateful hot reload.
Fixes: https://github.com/flutter/flutter/issues/169304
Issue: https://github.com/flutter/flutter/issues/169634
2025-05-29 19:00:57 +00:00
Mouad Debbar
8b18dde77f
Reduce some CI timeouts ( #169512 )
...
- `Linux docs_test`: Has been running consistently under 25m, while
timeout was set at 90m.
- `Linux coverage`: Has been running consistently under 1.2h (~75m),
while timeout was set at 120m.
2025-05-29 13:35:15 +00:00
Victoria Ashworth
6a15533bf0
Allow tests to use macOS 15.5 ( #169536 )
...
Part of https://github.com/flutter/flutter/issues/167824
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-28 15:55:00 +00:00
Mouad Debbar
db1c97a4af
Revert "Mark web_tool_tests_1_2 as bringup." ( #169361 )
...
Reverts flutter/flutter#168871
The timeout was [fixed](https://github.com/flutter/flutter/pull/169277 )
and some slow tests have been
[disabled](https://github.com/flutter/flutter/pull/169305 ). The builder
has been consistently green for the past 20+ runs:
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Windows%20web_tool_tests_1_2
Closes https://github.com/flutter/flutter/issues/168863
2025-05-23 17:36:08 +00:00
Danny Tuppeny
9ae249e0b1
Increase sub-task timeout for Mac web_tool_tests ( #169307 )
...
In my PR https://github.com/flutter/flutter/pull/169198 the Mac
web_tool_tests are timing out after around 45 minutes. The global
timeout has been set to 60 minutes but the sub-task timeout was lower.
This increases the sub-task timeout to match the global timeout (see
https://github.com/flutter/flutter/pull/169277 and
https://github.com/flutter/flutter/issues/169168 ).
2025-05-22 22:11:59 +00:00
Mouad Debbar
43b6bf67e9
Increase sub-task timeout for web_tool_tests_1_2 ( #169277 )
...
For more details, @flar did a great job explaining it in
https://github.com/flutter/flutter/issues/169168 .
This PR is a one-off fix for the `web_tool_tests_1_2` shard that has
been timing out and bringing the tree down with it. The shard was marked
`bringup` [here](https://github.com/flutter/flutter/pull/168871 ). After
increasing the sub-task timeout, let's watch it and if it becomes
consistently green, we will remove the `bringup` status.
Partial fix for https://github.com/flutter/flutter/issues/168863
(partial because I still want to remove `bringup` before I consider the
issue fixed)
2025-05-22 17:03:41 +00:00
Matan Lurey
9214ed12db
Remove unnecessary bringup: true for release-channel only Linux flutter_packaging. ( #168761 )
...
Annotated in https://github.com/flutter/flutter/pull/126281 .
I'm not sure this ever made sense - since it's only enabled on `beta`
and `stable` ... `bringup: true` does nothing.
2025-05-15 17:17:56 +00:00
Matan Lurey
94c661082c
Revert: "Run flutter_packaging builders on release candidates ( #168917 )
...
This reverts commit 567162a91c
2025-05-15 17:11:04 +00:00
Matan Lurey
6891d5cf00
Mark web_tool_tests_1_2 as bringup. ( #168871 )
...
Unblocks the tree (>10% failure rate in prod):
https://github.com/flutter/flutter/issues/168863 .
2025-05-14 22:20:07 +00:00
Flutter GitHub Bot
146a338036
Marks Mac_mokey run_debug_test_android to be unflaky ( #167634 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_mokey run_debug_test_android"
}
-->
The issue https://github.com/flutter/flutter/issues/161655 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_mokey%20run_debug_test_android%22 ).
This test can be marked as unflaky.
Co-authored-by: Matan Lurey <matanlurey@users.noreply.github.com>
Co-authored-by: Ben Konyi <bkonyi@google.com>
2025-05-14 20:24:00 +00:00
Matan Lurey
567162a91c
Run {Platform} flutter_packaging builders on release candidates. ( #168762 )
...
Closes https://github.com/flutter/flutter/issues/168745 .
2025-05-14 03:53:21 +00:00
Matan Lurey
f3fa8c2670
Remove docs_deploy_beta, fix docs_publish, add comments. ( #168754 )
...
Towards https://github.com/flutter/flutter/issues/168709 .
This will need to get cherry-picked into the `3.32-candidate` branch.
2025-05-14 03:51:25 +00:00
Flutter GitHub Bot
e5b3fc3aa0
Marks Mac_arm64_ios imitation_game_swiftui to be unflaky ( #163114 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64_ios imitation_game_swiftui"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20imitation_game_swiftui%22 ).
This test can be marked as unflaky.
2025-05-07 23:49:13 +00:00
Victoria Ashworth
a3e9379a87
Allow iOS devicelab tests to run on macOS 15.1 ( #168234 )
...
New devicelab bots were added to the pools:
https://github.com/flutter/flutter/issues/163002 . However, they are on
macOS 15.1. Allow these bots to be used by allowing macOS 15 to be used.
Specifying macOS 15.1 specifically because we plan to upgrade to newer
version of macOS 15 in the future:
https://github.com/flutter/flutter/issues/167676
I verified all bots are good to go:
- [x]
[flutter-devicelab-mac-50](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-50 )
- https://ci.chromium.org/b/8715949123404093697
- [x]
[flutter-devicelab-mac-51](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-51 )
- https://ci.chromium.org/b/8715948996142121377
- [x]
[flutter-devicelab-mac-52](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-52 )
- https://ci.chromium.org/b/8715948941926665041
- [x]
[flutter-devicelab-mac-53](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-53 )
- https://ci.chromium.org/b/8715948864280336145
- [x]
[flutter-devicelab-mac-54](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-54 )
- https://ci.chromium.org/b/8715944668313575425
- [x]
[flutter-devicelab-mac-55](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-55 )
- https://ci.chromium.org/b/8715948803357927393
- [x]
[flutter-devicelab-mac-56](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-56 )
- https://ci.chromium.org/b/8715943235735747409
- [x]
[flutter-devicelab-mac-57](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-57 )
- https://ci.chromium.org/b/8715702195501017153
- [x]
[flutter-devicelab-mac-58](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-58 )
- https://ci.chromium.org/b/8715702188356676017
- [x]
[flutter-devicelab-mac-59](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-59 )
- https://ci.chromium.org/b/8715702172189573265
- [x]
[flutter-devicelab-mac-60](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-60 )
- https://ci.chromium.org/b/8715702160439712753
- [x]
[flutter-devicelab-mac-61](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-61 )
- https://ci.chromium.org/b/8715702148815570433
- [x]
[flutter-devicelab-mac-62](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-62 )
- https://ci.chromium.org/b/8715702138014731537
- [x]
[flutter-devicelab-mac-63](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-63 )
- https://ci.chromium.org/b/8715948441393524945
- [x]
[flutter-devicelab-mac-64](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-64 )
- https://ci.chromium.org/b/8715702120175999281
- [x]
[flutter-devicelab-mac-65](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-65 )
- https://ci.chromium.org/b/8715702108188863617
- [x]
[flutter-devicelab-mac-66](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-66 )
- https://ci.chromium.org/b/8715688828119260401
- [x]
[flutter-devicelab-mac-67](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-67 )
- https://ci.chromium.org/b/8715702082037082849
- [x]
[flutter-devicelab-mac-68](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-68 )
- https://ci.chromium.org/b/8715702070384265201
- [x]
[flutter-devicelab-mac-69](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-69 )
- https://ci.chromium.org/b/8715702058744115521
- [x]
[flutter-devicelab-mac-70](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-70 )
- https://ci.chromium.org/b/8715702046612264657
- [x]
[flutter-devicelab-mac-71](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-71 )
- https://ci.chromium.org/b/8715702036987261777
- [x]
[flutter-devicelab-mac-72](https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-72 )
- https://ci.chromium.org/b/8715688823094725361
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-07 15:14:08 +00:00
MarkZ
7aa6e1b86f
Extending timeouts for DDC macrobenchmarks ( #168409 )
...
Dart2JS runs these benchmarks in ~12 min, so it's unsurprising that DDC
takes ~3x longer. It turns out the tests just take forever to run on the
test infra (minutes locally on Macbook Pro). One benchmark in particular
takes 8+ minutes (`bench_material3_components`).
2025-05-06 23:41:08 +00:00
Victoria Ashworth
397d3e1185
Update mac_ios tests to run on either arm64 or x86 ( #168341 )
...
We have more arm64 bots than x86, but most of our tests are on
`mac_ios`, which is filtered to `x86`. This PR removes that filter and
allows tests to run on either arch.
Fixes https://github.com/flutter/flutter/issues/168236 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-06 18:16:01 +00:00
jesswrd
9cd0c083c7
Bumping framework Template Defaults to Android 16 (API 36) ( #166464 )
...
Updating framework to Android 16 (API 36). This involves updating
template versions to:
`compilesdk` 36
AGP 8.9.1
gradle 8.11.1
They are the recommended minimum versions outlined in the android docs
[here](https://developer.android.com/build/releases/gradle-plugin ).
Note: I will bump `targetsdk` in a different PR. Infra changes may be
necessary when bumping `targetsdk`, so rolling it back would be easier
if the change is in a separate PR.
Partially Addresses https://github.com/flutter/flutter/issues/163071
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-05 23:46:34 +00:00
Matan Lurey
e7a4ef0d8a
Only build and download Fuchsia artifacts on master ( #168154 )
...
Closes https://github.com/flutter/flutter/issues/168089 .
/cc @zanderso
2025-05-01 19:06:32 +00:00
Matan Lurey
5da19ccfbc
Move backfill: "false" out of properties, make it a boolean. ( #167820 )
...
Towards https://github.com/flutter/flutter/issues/167755 .
Cocoon supports both formats at the moment, so this a NOP.
2025-04-25 17:26:07 +00:00
Flutter GitHub Bot
0c19a5071b
Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be unflaky ( #167632 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
dynamic_path_stroke_tessellation_perf__timeline_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20dynamic_path_stroke_tessellation_perf__timeline_summary%22 ).
This test can be marked as unflaky.
Co-authored-by: Matan Lurey <matanlurey@users.noreply.github.com>
2025-04-23 21:36:21 +00:00
Flutter GitHub Bot
3ec8d19e10
Marks Linux analyzer_benchmark to be unflaky ( #167630 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux analyzer_benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/161306 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20analyzer_benchmark%22 ).
This test can be marked as unflaky.
Co-authored-by: Matan Lurey <matanlurey@users.noreply.github.com>
2025-04-23 21:16:09 +00:00
Flutter GitHub Bot
b33f8e8037
Marks Linux_pixel_7pro integration_ui_driver to be flaky ( #167639 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro integration_ui_driver"
}
-->
Issue link: https://github.com/flutter/flutter/issues/167638
2025-04-23 20:24:35 +00:00
Flutter GitHub Bot
80e6328f93
Marks Mac_mokey run_release_test to be unflaky ( #167635 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_mokey run_release_test"
}
-->
The issue https://github.com/flutter/flutter/issues/153830 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_mokey%20run_release_test%22 ).
This test can be marked as unflaky.
2025-04-23 20:24:34 +00:00
Flutter GitHub Bot
b6f22513b4
Marks Windows_arm64 plugin_test_windows to be unflaky ( #167636 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 plugin_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/163122 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20plugin_test_windows%22 ).
This test can be marked as unflaky.
2025-04-23 20:23:00 +00:00
Loïc Sharma
08a59c2802
[iOS] Hide keyboard on hot restart ( #167013 )
...
This hides the keyboard and text input context menu if you hot restart
your iOS app.
Before | After
-- | --
<video
src="https://github.com/user-attachments/assets/7ca5dbfe-a809-478c-9b36-4c168527b176 "
/> | <video
src="https://github.com/user-attachments/assets/d1a48c16-f171-4d22-baa4-5c40488d055b "
/>
Part of https://github.com/flutter/flutter/issues/10713
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-22 23:33:02 +00:00
LouiseHsu
6f14c960ec
Fix codesigning for Mac_arm64_ios imitation_game_flutter ( #167307 )
...
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64_ios%20imitation_game_flutter
The swiftui benchmark has been failing in bring up because the project
wasnt getting correctly codesigned. Also, fixes the fact that I flipped
the naming of imitation_game_flutter and imitation_game_swiftui 😶🌫️
Also removes extraneous targets from the project
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_arm64_ios%20imitation_game_flutter/14/overview
Tested with `led`, proof that it's working post this PR ^
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-18 21:02:51 +00:00
Flutter GitHub Bot
619d985931
Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky ( #167259 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
static_path_stroke_tessellation_perf__timeline_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20static_path_stroke_tessellation_perf__timeline_summary%22 ).
This test can be marked as unflaky.
2025-04-16 19:10:39 +00:00
Flutter GitHub Bot
909aeccfe4
Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky ( #167261 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios
dynamic_path_stroke_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20dynamic_path_stroke_tessellation_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2025-04-16 19:09:23 +00:00
Flutter GitHub Bot
ad17f03122
Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky ( #167260 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios
static_path_stroke_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20static_path_stroke_tessellation_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2025-04-16 19:04:32 +00:00
MarkZ
10a1d1520e
Adding macrobenchmarks for DDC ( #166617 )
...
We're adding macrobenchmark support to DDC (AMD modules and our new
hot-reload-capable module system) to be aware of any current/future
performance regressions. I'm not terribly aware of the metrics
collection pipeline; please let me know if we need to do any more work
to see these tests run/report numbers to the proper dashboards.
2025-04-16 03:29:36 +00:00
Gray Mackall
f02a93bc88
[reland] Fix regression in NDK version checking ( #167011 )
...
Relands https://github.com/flutter/flutter/pull/166998 .
On top of the original PR:
1. fixes unfortunate mistake in commenting the fix
2. adds to the `runIf` cases to better cover when this test should be
run in presubmit
3. pins a lower version of `shared_preferences_android`, as we need to
use a plugin with `compileSdk 34` for those lower AGP versions.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-04-14 16:38:16 +00:00
Jim Graham
dc78960cdb
add Impeller path stroke tessellation benchmark ( #166939 )
...
We currently benchmark path tessellation on Android and iOS, but only
for filled paths. We will now run those same benchmarks also with
stroking in a new set of benchmarks.
2025-04-10 21:38:08 +00:00
Victoria Ashworth
af1fd78b3c
Run tests on either iOS 17 or iOS 18 ( #166879 )
...
Fixes https://github.com/flutter/flutter/issues/148968 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-10 15:42:57 +00:00
Jonah Williams
5ec10614b5
Re-disable microbenchmarks iOS. ( #166788 )
...
This went flakey/flaky immeidately
2025-04-08 21:51:47 +00:00
Matan Lurey
4a3d13eb17
Enable a swath of bringup: true builds that were forgotten to the void. ( #166757 )
2025-04-08 17:14:10 +00:00
auto-submit[bot]
e5cd67b6fc
Reverts "Reverts "Remove bringup:true from Linux tool_tests_widget_preview_scaffold ( #166687 )" ( #166700 )" ( #166711 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166700
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: bkonyi
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breakage fixed in
https://github.com/flutter/flutter/pull/166701
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: auto-submit[bot]
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {fluttergithubbot}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166687
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke postsubmit ("... not up to date")
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8718230395584699185/+/u/run_test.dart_for_tool_tests_shard_and_subshard_widget_preview_scaffold/stdout
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: bkonyi
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
New shard seems to be stable and passing consistently.
<!-- end_revert_body -->
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-04-07 19:05:47 +00:00
auto-submit[bot]
208b2b1a9f
Reverts "Remove bringup:true from Linux tool_tests_widget_preview_scaffold ( #166687 )" ( #166700 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166687
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke postsubmit ("... not up to date")
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8718230395584699185/+/u/run_test.dart_for_tool_tests_shard_and_subshard_widget_preview_scaffold/stdout
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: bkonyi
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
New shard seems to be stable and passing consistently.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-04-07 17:06:47 +00:00
Ben Konyi
a333757dcf
Remove bringup:true from Linux tool_tests_widget_preview_scaffold ( #166687 )
...
New shard seems to be stable and passing consistently.
2025-04-07 16:15:55 +00:00
Ben Konyi
d6c0d6fee7
[ Widget Previews ] Add widget_preview_scaffold.shard to test the widget_preview_scaffold template contents ( #166358 )
...
Adds a new `widget_preview_scaffold.shard` directory which contains a
hydrated `widget_preview_scaffold` template. This will allow for us to
write widget tests against the widgets defined in the templates.
This PR doesn't add any widget tests and is only adding the ability to
run these tests in follow up changes.
Fixes https://github.com/flutter/flutter/issues/166416
2025-04-04 18:43:52 +00:00
jesswrd
b4543b7bf2
Updated to latest AVD to Support Android 16 (API 36) ( #165926 )
...
Updated test targets to depend on the latest AVD version that supports
Android 16(API 36) for framework. Updated to a 36 emulator at
`linux_android_emu_unstable` only to experiment and monitor potential
flakiness. After confirmed stability (~200 commits), I will update other
targets to depend on a 36 emulator in framework, packages, and engine.
Partially Addresses #165922
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-31 18:46:45 +00:00
Flutter GitHub Bot
53d93da57a
Marks Linux_mokey new_gallery__crane_perf to be flaky ( #165964 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_mokey new_gallery__crane_perf"
}
-->
Issue link: https://github.com/flutter/flutter/issues/165963
2025-03-31 17:41:07 +00:00
Mitchell Goodwin
9f1e7eda61
Remove bringup flag for customer tests ( #166161 )
...
Fixes #166160 by reverting #166103 .
Customer tests were not finishing due to errors in devtools, caused by
package:vm_service_protos being upgraded to 1.1.0 and desyncing with
package:protobuf. [package:vm_service_protos
](https://pub.dev/packages/vm_service_protos )has been rolled back to
1.0.0, and the [devtool checks are passing
again](https://github.com/flutter/devtools/actions/workflows/build.yaml ),
so marking the customer tests as unflaky again.
2025-03-28 21:21:04 +00:00
Zachary Anderson
d30c767656
Mark Linux coverage as bringup ( #166144 )
...
For https://github.com/flutter/flutter/issues/164591
2025-03-28 16:59:52 +00:00
Mitchell Goodwin
6816e6dbba
Mark Linux customer tests as flaky ( #166103 )
...
Marks tests as flaky to unblock tree. Related to #166102
2025-03-27 22:49:36 +00:00
jesswrd
807ccd7f9d
Update Java Versions to 21 on CI ( #165210 )
...
Updated java versions to 21 on CI. Monitor to see if anything breaks.
Fixes https://github.com/flutter/flutter/issues/163158
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
2025-03-24 22:43:22 +00:00
Jonah Williams
31ff6497f1
Reland: [Impeller] add a configuration option that allows defering all PSO construction until needed. ( #165622 )
...
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
---------
Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2025-03-22 01:34:05 +00:00
