Commit Graph

388 Commits

Author SHA1 Message Date
Emmanuel Garcia
7e60a65ff0
Don't read AndroidManifest.xml if it doesn't exit (#43669) 2019-10-29 16:05:13 -07:00
Jonah Williams
331d19ff4b
Add reloadMethod RPC (#43725) 2019-10-29 13:21:06 -07:00
Jonah Williams
1d7afd9c1d
Don't indefinitely persist file hashes, handle more error conditions (#43602) 2019-10-29 13:20:51 -07:00
Jenn Magder
01dc19b93f
Pass environment variables through to xcodebuild (#43553) 2019-10-28 19:58:06 -07:00
Jonah Williams
19e551c7a6
Remove Poller class from flutter_tools (#43685) 2019-10-28 19:35:43 -07:00
Jonah Williams
e25cd84a06
Catch failed startup error from build_daemon (#43598) 2019-10-28 15:58:14 -07:00
Jonah Williams
b142c9bbdb
catch failure to parse FLUTTER_STORAGE_BASE_URL (#43599) 2019-10-28 10:54:03 -07:00
Jonah Williams
36d50a48f4
Catch MissingPortFile exception (#43573) 2019-10-28 10:26:43 -07:00
Jonah Williams
d983c1d1ae
Ensure Chrome is closed on tab close (#43586) 2019-10-28 10:26:18 -07:00
Zachary Anderson
0dfabb2ae1
[flutter_tool] Use engine flutter_runner prebuilts (#43381)
* [flutter_tool] Use engine flutter_runner prebuilts

* Update packages/flutter_tools/lib/src/fuchsia/fuchsia_build.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
2019-10-28 09:38:08 -07:00
Jonah Williams
ab260bacd2
Refactor BuildMode into class, add jit_release configuration (#42476) 2019-10-28 09:37:29 -07:00
Jonah Williams
553662d101
Catch AppConnectionException from dwds (#43544) 2019-10-25 20:35:19 -07:00
Jonah Williams
4bd5eb5915
Enable track widget creation on by default (#43471) 2019-10-25 15:04:06 -07:00
Jonah Williams
4c47fdadd4
Add devfs for incremental compiler JavaScript bundle (#43219) 2019-10-25 15:03:13 -07:00
Jonah Williams
ed931e7941
initial bootstrap script for incremental compiler support (#43292)
* initial bootstrap script for incremental compiler support

* add more comments

* update to two scripts
2019-10-25 15:03:00 -07:00
Harry Terkelsen
eba69caf97
Don't html-escape in the plugin registrant templates. (#43448)
* Don't html-escape in the plugin registrant templates.

Fixes #43382

* Add test
2019-10-25 15:00:05 -07:00
Jonah Williams
c1d3ca07fe
catch ChromeDebugException from dwds (#43390) 2019-10-24 10:55:42 -07:00
Harry Terkelsen
dee4232d0c For --profile builds on web, still use -O4 but unminified names. (#43214) 2019-10-24 10:08:12 -07:00
Jonah Williams
096a8ac40a handle format error from vswhere (#43402) 2019-10-24 10:07:05 -07:00
Jonah Williams
9e7b6f9500
Catch version and option skew errors from build_daemon (#43403) 2019-10-24 09:06:45 -07:00
Jonah Williams
2237451711
Don't eagerly call runMain when --start-paused is provided to web application (#42144) 2019-10-24 07:57:52 -07:00
Jonah Williams
4c677e4148
Extra defensive programming for pub modification time assert (#43315) 2019-10-22 22:05:00 -07:00
James D. Lin
83704b1d91
Make ProjectFileInvalidator.findInvalidated able to use the async FileStat.stat (#42028)
Empirical measurements indicate on the network file system we use
internally, using `FileStat.stat` on thousands of files is much
faster than using `FileStat.statSync`. (It can be slower for files
on a local SSD, however.)

Add a flag to `ProjectFileInvalidator.findInvalidated` to let it
use `FileStat.stat` instead of `FileStat.statSync` when scanning for
modified files.  This can be enabled by overriding `HotRunnerConfig`.

I considered creating a separate, asynchronous version of
`findInvalidated`, but that led to more code duplication than I
liked, and it would be harder to avoid drift between the versions.
2019-10-22 20:48:23 -07:00
Jonah Williams
016ca1a0f1
Catch io.StdinException from failure to set stdin echo/line mode (#43225) 2019-10-22 20:35:43 -07:00
Jonah Williams
79a985f9fd
Add compiler configuration to support dartdevc target (#43281) 2019-10-22 20:35:05 -07:00
Jonah Williams
8cac409d90
Clarify hot restart behavior on the web (#42931) 2019-10-22 12:36:56 -07:00
Jonah Williams
46ea99122b
Revert "Extra defensive programming for pub modification time assert (#42491)" (#43235)
This reverts commit 3597bae6a0.
2019-10-21 20:54:02 -07:00
Ian Hickson
3597bae6a0 Extra defensive programming for pub modification time assert (#42491) 2019-10-21 20:15:20 -07:00
Emmanuel Garcia
e82ddc4c7a
Ensure android.enableR8 is appended to a new line (#43187) 2019-10-21 16:52:30 -07:00
Jonah Williams
27105cba2f
switch dart2js build to depfile, remove Source.function (#42977) 2019-10-21 16:46:44 -07:00
Jonah Williams
6c91a13731
Adding missing break in plugin validation check (#43180) 2019-10-21 16:46:07 -07:00
Jonah Williams
31a4ff80c7
add samsungexynos7570 to list of known physical devices (#43042) 2019-10-21 16:45:48 -07:00
Jonah Williams
6db4c44da8
remove period from URL so that it opens correctly in vscode (#43200) 2019-10-21 16:43:11 -07:00
Ian Hickson
124dc6617f
Clean up test infrastructure (#43030)
See #41880 for history.
2019-10-18 16:35:39 -07:00
Jonah Williams
39e4d9d152
Expand scope of rethrown gradle errors (#42966) 2019-10-18 14:56:39 -07:00
Jonah Williams
6fc99e98ad
rename headless server to web server (#42970) 2019-10-18 12:41:47 -07:00
Jonah Williams
21be8372c9
implement debugTogglePlatform for the web (#42951) 2019-10-18 12:41:15 -07:00
Jonah Williams
e67f9a3f6c
ensure we can disable --track-widget-creation in debug mode (#43016) 2019-10-18 12:40:50 -07:00
Jonah Williams
1982a5c3ec
Revert "Clean up test infrastructure (#41880)" (#42982)
This reverts commit 1781d5c9bb.
2019-10-17 19:47:16 -07:00
Ian Hickson
1781d5c9bb
Clean up test infrastructure (#41880) 2019-10-17 19:22:47 -07:00
Jonah Williams
f53b32eb23
refactor depfile usage and update linux rule (#42487) 2019-10-17 17:42:40 -07:00
Ferhat
f7ce5ae3fc
[web] Update web runner message with flutter.dev/web (#42676)
* Update web runner message with flutter.dev/web

* Update spoopy test to use Warning instead
2019-10-17 15:08:15 -07:00
Jonah Williams
cb518c4219
Fix progress indicators for release/profile builds of web. (#42857) 2019-10-16 16:10:06 -07:00
Jonah Williams
01f779e97a
Fix NPE in Chrome Device (#42813) 2019-10-16 15:46:07 -07:00
Emmanuel Garcia
0a93f4eb75
Remove isNewAndroidEmbeddingEnabled flag when reading an existing pro… (#42684) 2019-10-16 12:47:04 -07:00
Jenn Magder
357d02c87b
Always embed Flutter.framework build mode version from Xcode configuration (#42029) 2019-10-15 15:33:55 -07:00
Jonah Williams
ad1d67e0a1
serve correct content type from debug server (#42701) 2019-10-15 15:25:57 -07:00
Jonah Williams
68e768dbcf
fix type error in manifest asset bundle (#42791) 2019-10-15 15:25:33 -07:00
liyuqian
31cb44825c
Add --cache-sksl flag to drive and run (#42353)
So we can test SkSL precompile using the command line tools.
See https://github.com/flutter/engine/pull/12412.
2019-10-15 14:28:55 -07:00
Jonah Williams
e22d4aa140
Add debugging option to write vmservice address to file after starting (#41583) 2019-10-15 13:05:47 -07:00
Christopher Fujino
428d7d7f2d
dispose devices on cleanupAtFinish() for run_cold.dart (#42668) 2019-10-15 12:50:44 -07:00
Jenn Magder
dda74a1993
Increase template Swift version from 4 to 5 (#41882) 2019-10-15 12:37:13 -07:00
Jonah Williams
e372641789
Ensure we stop the status when browser connection is complete (#42698) 2019-10-14 21:36:31 -07:00
Jonah Williams
f8a5baf359
Dont close debug connection on exit (#42655) 2019-10-14 17:29:04 -07:00
Jonah Williams
0dce0c6e30
catch appInstanceId error from dwds (#42656) 2019-10-14 17:28:28 -07:00
Ryan Macnak
b7773da37b
Pass build mode-specific bytecode generation options to frontend_server. (#42471)
Fixes various Flutter framework test failures when bytecode is enabled.
2019-10-14 15:26:14 -07:00
Jenn Magder
a62bb3d9ab
Update minimum version to Xcode 10.2 (#42254) 2019-10-14 12:45:40 -07:00
Mouad Debbar
ba70e0e074
Print correct hostname when web server is launched (#42531) 2019-10-14 09:54:36 -07:00
Jonah Williams
04e04ffa95
Deflake wildcard asset test (#42597) 2019-10-14 08:49:02 -07:00
Emmanuel Garcia
532a8fed41
Print message and log event when app isn't using AndroidX (#42548) 2019-10-12 18:58:22 -07:00
Dan Field
3fea2838df
Skip test (#42557) 2019-10-11 16:18:00 -07:00
Zachary Anderson
af93b6af80
[flutter_tool] Improve yaml font map validation (#42538) 2019-10-11 12:17:37 -07:00
Ian Hickson
08643c41d7
Always fake ProcessManager when you fake Filesystem in tests (#42369)
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Ian Hickson
53be552ae1
Be more verbose when pub fails (#42187) 2019-10-10 19:37:01 -07:00
Jonah Williams
2b635816c6
Wrap dwds in async guard, only catch known error types (#42364) 2019-10-10 16:34:27 -07:00
Jonah Williams
03a45dc383
Add support for Android x86_64 ABI to Flutter (#42401) 2019-10-10 16:34:16 -07:00
Ryan Macnak
2a40c2ddb5
Pass -Ddart.developer.causal_async_stacks=true to frontend_server invocations. (#42354)
Bytecode generation will otherwise omit prologue code, causing --causal-async-stacks passed to the VM to behave inconsistently.
2019-10-10 10:41:24 -07:00
Sahil Soni
ff15a39c07 [BUG] Process all children of intent-filter instead of just the first one to identify default activity (#40029) 2019-10-10 10:05:43 -07:00
Lau Ching Jun
5a41374ac3
Add option to precache unsigned mac binaries. (#42376) 2019-10-09 22:24:15 -07:00
Christopher Fujino
ed482c3e09
Stop leaking iproxy processes (#42026) 2019-10-09 16:30:27 -07:00
stuartmorgan
d992d6de20 Make desktop stopApp only apply to processes Flutter started (#41519) 2019-10-09 16:28:10 -07:00
Jonah Williams
861fe0a276
Ensure precache --web works on dev branch (#42289) 2019-10-09 16:27:39 -07:00
Jonah Williams
6a99a8d9e4
Ensure web restart analytics events aren't sent for failures/dont serve devtools by default (#42260) 2019-10-08 20:06:13 -07:00
Jonah Williams
fde267516b
Make Pub an interface in the flutter tool (#42257) 2019-10-08 14:53:28 -07:00
Alexandre Ardhuin
83e5a8a0e4
some formatting changes (#41640) 2019-10-08 18:32:10 +02:00
Ian Hickson
cdc2d9901d
More consistent temp directory naming (#42063)
Applying our style guide:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#have-good-hygiene-when-using-temporary-directories
2019-10-07 16:43:04 -07:00
Zachary Anderson
cf0d4979c7
[flutter_tool] Re-work analytics events to use labels and values (#42016) 2019-10-07 15:04:55 -07:00
Dan Field
4566b34033
Do not validate the Android SDK when building an appbundle (#41946) 2019-10-07 10:38:19 -07:00
Dan Field
3af16678ad
Reland "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030)" (#42038)
This reverts commit 142a8630ec.
2019-10-07 10:37:58 -07:00
Zachary Anderson
3b66db6bf7
Updates packages (#41936) 2019-10-07 09:46:57 -07:00
Ian Hickson
97e00b2288 Skip sdk_validation_test again (#42091) 2019-10-07 08:11:45 -07:00
Ian Hickson
682e6383ac
Refactor sdk_validation_test (#42064) 2019-10-06 14:39:16 -07:00
Dan Field
f4b4616f87
Diagnose failure in CI, Mark III (#42037) 2019-10-04 20:01:04 -07:00
Ian Hickson
a22f4e9be5
trying to diagnose failure in CI, mark II (#42036)
* remove prints

* Remove the setUpAll() to see if that changes the error message.
2019-10-04 19:43:54 -07:00
Ian Hickson
4e6b77c087
trying to diagnose failure in CI (#42035) 2019-10-04 19:01:37 -07:00
Ian Hickson
142a8630ec
Revert "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030)
This reverts commit 3024053c82.
2019-10-04 17:51:51 -07:00
James D. Lin
14c5c6e161
Clean up ProjectFileInvalidator.findInvalidated a bit (#41889)
In preparation for some refactoring that I will be doing to
`ProjectFileInvalidator.findInvalidated`, make its code a bit
clearer:
* Indicate which arguments may be null.
* Don't bother calling `FileStat.statSync` on the `.packages` file
  for the initial load.  This makes the checks for the `.packages`
  file consistent with those for other files.
* Use `DateTime.isAfter()` instead of comparing microseconds
  ourselves.

While I was touching this file, I also removed some unnecessary
comparisons to `false`. (`_ManifestAssetBundle.wasBuiltOnce()` is the
only implementation I can find of `AssetBundle.wasBuiltOnce()`, and
it never returns `null`.)
2019-10-04 12:55:17 -07:00
Jonah Williams
3024053c82
AOT support for Linux Desktop I: switch Linux builds to assemble (#41612) 2019-10-04 12:13:36 -07:00
Ryan Macnak
cdb3578b14
Plumb --enable-asserts through to frontend_server invocation in debug mode. (#41832)
Bytecode generation will otherwise omit assert code, causing --enable-asserts to have no effect in the VM.
2019-10-04 12:07:23 -07:00
Emmanuel Garcia
5961bcc505
Generate projects using the new Android embedding (#41666)
* Generate projects using the new Android embedding

* Add comment about usesNewEmbedding:true

* Feedback

* Rework way to detect new embedding in new apps
2019-10-04 06:23:03 -07:00
Alexandre Ardhuin
890b939401
indent formal parameters correctly (#41644) 2019-10-04 11:00:18 +02:00
Jonah Williams
ae18f07324
Ensure plugin registrants are generated in build_web (#41906) 2019-10-04 00:36:09 -07:00
Jonah Williams
db9ad60bfe
Deflake web_fs_test.dart in flutter_tools (#41952) 2019-10-03 19:07:38 -07:00
Zachary Anderson
c7c8a6c498
[flutter_tools] Add more info to pub get failure event (#41652) 2019-10-03 11:08:42 -07:00
Jonah Williams
517c08e801
Make output directory a build input (#41862) 2019-10-03 11:07:53 -07:00
Jonah Williams
aeede20785
Handle missing .packages file in the flutter tool for prebuilt artifacts (#41697) 2019-10-02 15:18:34 -07:00
Ian Hickson
8c6d60bcfd
Move commands into their own shard (#39140) 2019-10-02 12:46:51 -07:00
Jonah Williams
39f85f94ec
Reland: don't update last compile time when compilation is rejected. (#41580)
* dont update last compiled time when compilation is rejected

* lets try flushing, thats a neat trick

* windows man

* Update hot_reload_test.dart

* Update hot_reload_test.dart

* Update devfs.dart

* Update hot_reload_test.dart

* Update hot_reload_test.dart

* add test that verifies when compile is good that time is updated

* Update devfs_test.dart
2019-10-02 12:46:33 -07:00
Jonah Williams
0af2a84cbb
Handle empty entry in asset list and add more explicit validation (#41735) 2019-10-02 12:45:51 -07:00
Jonah Williams
b2f38396f4
Reland: Switch to assemble API for dart2js (#41659)
* Stop using build_runner for dart2js

* fixes to yield when computing hashes and to imports

* add missing await

* Update filecache_test.dart

* Fix paths in filecache test

* use file uri for import

* add test cases and configurable override

* remove test dep

* fix filepaths for windows

* test no longer failing

* fix paths for test cases

* fix typo

* address comments

* make a constant

* make filehash async and use constant

* fix silly logic error
2019-10-01 14:03:42 -07:00