Michael Goderbauer
1d915bacc0
Roll engine to 9859af123eb383ade52208a9db58ac39db84bfc2 ( #16947 )
...
flutter/engine@9859af1 Roll dart to 29d6e963702fcbb0ed0d5ca67d6b5f977ac0c328
2018-04-25 10:25:03 -07:00
josephmr
7f9bf5ade9
Introduce DoctorValidatorsProvider to improve extensibility of flutter_tools ( #16918 )
...
DoctorValidatorsProvider is injected into Doctor to allow
overriding of DoctorValidators without needing to override
the whole Doctor instance.
2018-04-24 19:01:53 -07:00
xster
00221820df
Remove the initial xcodebuild clean step which seems unnecessary ( #16475 )
2018-04-24 18:17:24 -07:00
Chris Bracken
4ad190e74f
Make CompilerOutput immutable ( #16942 )
...
CompilerOutput values should never be mutated. Also includes minor
formatting change to the compile() method signature in line with the
style guide.
Minor housekeeping while I'm touching other bits of nearby code.
2018-04-24 16:48:04 -07:00
Chris Bracken
f570e046c9
Inline buildScriptSnapshot calls ( #16940 )
2018-04-24 16:07:14 -07:00
Chris Bracken
993f3947da
Generalise FakeGenSnapshot output generation ( #16938 )
...
Pre-factoring for addition of AOT snapshotting unit tests, which emit a
different set of expected outputs.
2018-04-24 15:51:10 -07:00
Chris Bracken
7ffcd3d22d
Extract KernelCompiler class ( #16937 )
...
Wraps the compile function in a class injected via the global context,
which makes it easier to mock in unit tests -- specifically tests for
AOT snapshotting, which already require pretty significant amounts of
mock inputs.
2018-04-24 14:03:41 -07:00
Alexander Aprelev
a21c93dd70
Fix boolean flag parsing in gradle. Track 'trackWidgetCreation' as property of the build. ( #16901 )
2018-04-24 09:51:25 -07:00
Zachary Anderson
c7ee37a0d8
[fuchsia] Pass a dummy command to the ssh tunnel setup ( #16906 )
...
* [fuchsia] Pass a dummy command to the ssh tunnel setup
* Address analyzer lint
* Update fuchsia_remote_debug_protocol
2018-04-23 21:26:51 -07:00
Alexander Aprelev
b1330eff5f
Fail test execution if compiler reported errors. ( #16895 )
...
Fixes https://github.com/flutter/flutter/issues/16496
2018-04-23 17:08:11 -07:00
Chris Bracken
de8a53c55b
Rename buildSnapshot to buildScriptSnapshot ( #16905 )
...
Renames buildSnapshot to build buildScriptSnapshot in preparation for
AOT snapshot tests.
2018-04-23 16:51:34 -07:00
Yegor
d354096299
a11y traversal: sort locally; use new sorting algorithm ( #16253 )
...
New a11y traversal:
- sort direct sibling SemanticsNodes only
- use new sorting algorithm
- implement RTL
- test semantics in traversal order by default
- add AppBar traversal test
- breaking: remove nextNodeId/previousNodeId from the framework
- breaking: remove DebugSemanticsDumpOrder.geometricOrder
2018-04-23 14:23:49 -07:00
Chris Bracken
b5af0a9114
Use GenSnapshot class for AOT snapshotting ( #16891 )
...
This replaces the existing manual invocation with the GenSnapshot class,
which allows for better configuration and testability.
2018-04-23 11:21:19 -07:00
PJ Essien
fd7222eea8
Fix error with 'flutter packages get' in package projects ( #16861 )
...
Package projects were erroneously being treated as apps
2018-04-22 18:03:46 -07:00
Todd Volkert
fb18ac650e
Notify test timeouts differently than test completions. ( #16842 )
...
This avoids notifying the coverage collector that we
completed the test when in fact we timed out, which in
turn avoids a downstream exception caused by the fact
that coverage collector assumes it has a valid observatory
port by which it can gather coverage data.
Fixes https://github.com/flutter/flutter/issues/16839
2018-04-21 19:52:46 -07:00
Devon Carew
f544f4d1c7
have flutter flormat use the sdkBinaryName method ( #16752 )
2018-04-21 08:29:07 -07:00
Devon Carew
36cf1158ec
add the full path to a flutter command ( #16720 )
...
* add the full path to a flutter command
* remove an unused import
* review comments
2018-04-20 17:39:32 -07:00
Michael Goderbauer
4f31a3f518
Revert "Enable sync-async" ( #16825 )
2018-04-20 16:33:07 -07:00
Yegor
ee735c4f25
Be specific about which exceptions are retried ( #16818 )
2018-04-20 14:45:50 -07:00
Mikkel Nygaard Ravn
315993efb3
Enable sync-async ( #16790 )
2018-04-20 14:49:33 +02:00
Todd Volkert
44b7e7d3f4
Fix capitalization in README.md ( #16788 )
2018-04-20 01:02:44 -07:00
Todd Volkert
12bbaba9ae
Do exponential backoff for all exceptions in VMService::defaultOpenChannel. ( #16785 )
...
We were trying to only catch WebSocketException, but in fact
SocketException can be thrown as well.
2018-04-19 23:36:15 -07:00
Devon Carew
6a82b1044a
use the --dart-sdk parameter to flutter analyze if passed in ( #16751 )
2018-04-19 18:44:46 -07:00
Yegor
85473d0941
retry VMService connection; expect missing PRODUCT_BUNDLE_IDENTIFIER ( #16770 )
...
Fixes #13655
2018-04-19 18:29:49 -07:00
Chris Bracken
cf5778810b
Move script snapshot argumtents to Snapshotter ( #16722 )
...
This moves --vm_snapshot_data and --isolate_snapshot_data argument
hardcoding from GenSnapshot (a minimal wrapper around gen_snapshot
invocations) to Snapshotter.buildScriptSnapshot(). These arguments are
present in both AOT and script snapshots, but differ semantically: for
script snapshots they're inputs from the host engine artifacts
directory, for AOT snapshots they're outputs to the build directory.
2018-04-19 16:03:07 -07:00
Devon Carew
c058c6a6d7
revert an older workaround for a pub/vm failure ( #16749 )
2018-04-19 13:11:42 -07:00
Chinmay Garde
48ab8648bf
On simulators, don't pass file paths to the engine that done exist. ( #16756 )
2018-04-19 12:42:56 -07:00
Todd Volkert
ec7b46e30b
Add stack trace to exception logs in flutter_platform ( #16715 )
2018-04-18 12:09:16 -07:00
Todd Volkert
3a0aabc37b
Add docs to VMService.onEvent() ( #16711 )
2018-04-18 09:24:52 -07:00
Mikkel Nygaard Ravn
1080c29832
Roll engine to c73be7ada2e1066e2a6f04f0541406409c2bfa6b ( #16707 )
2018-04-18 13:51:58 +02:00
Alexander Aprelev
09ca3c187d
Fix the way how stream event subscription is handled. ( #16698 )
2018-04-18 10:21:33 +02:00
Todd Volkert
c7df2619d7
Run test harness finalizers in reverse order. ( #16664 )
...
Finalizers handle the restoration of state. In order to restore
the state correctly, they shouyld be run in LIFO order.
Fixes #16657
2018-04-17 07:38:30 -07:00
Mikkel Nygaard Ravn
10cf0cedad
Revert "Roll engine to 1bc0e1bb9a8db882a21086096cc2b1e0854312b7 ( #16643 )" ( #16661 )
2018-04-17 12:40:02 +02:00
Todd Volkert
dd32d1b179
Roll engine to 1bc0e1bb9a8db882a21086096cc2b1e0854312b7 ( #16643 )
...
* Roll engine to d6d4eec24c38bb06a9b1aef4e70c321d447ba762
Contains the following engine commits:
flutter/engine@1bc0e1b On windows, refer to Dart snapshot directly executable.
flutter/engine@cf6ca32 Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79"
flutter/engine@4b45a53 Only make ERROR and FATAL log levels visible by default.
flutter/engine@98f6c2d Fix shell launcher test (dart2 compliant and stop polling)
flutter/engine@75851f0 Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79
flutter/engine@9495a52 On iOS, try to use ES3, then fall back to ES2.
flutter/engine@d6d4eec Fix broken Linux build
flutter/engine@d15dc76 Fix broken Chromebot build
flutter/engine@c17a629 Breadcrumbs to the wiki
flutter/engine@4eaf2c2 Return raw (unencoded) bytes in Image.toByteData()
flutter/engine@d812a61 Roll src/third_party/skia/ e669bdfad..276886160 (9 commits)
flutter/engine@62aeab7 Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain.
flutter/engine@f4ebb18 Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits)
flutter/engine@0b7d6be Re-land "do not pause rendering when android view loses focus"
flutter/engine@91dee59 If the rasterizer has a valid surface context, use that to create a snapshotting render target.
flutter/engine@570231b Specify the packages file path when running engine dart tests.
flutter/engine@0b9cef5 Minor update to README
flutter/engine@c386418 Promote line height in text style created from paragraph style
flutter/engine@4e0fbb6 If the test specifies a .dill file, dont make the engine interpret is as source.
flutter/engine@58e84c8 Re-land "Support multiple shells in a single process.
flutter/engine@37e5df0 Remove only use of SkPaint::kGenA8FromLCD
flutter/engine@b7358b3 libtxt: cache font families that are remapped to the default font family
flutter/engine@a530035 libtxt: fix leaks in Skia object reference counting
flutter/engine@0c74fc9 [fuchsia] Fix use-after-free
flutter/engine@b6d2dde [fuchsia] Fix build
flutter/engine@1dd1264 [async] Adapt to libasync API changes.
* Run test platform finalizers in reverse order to ensure that shell is shutdown before trying to delete any temporary files or directories. This fixes "Access Denied" error on Windows (see #16657 ).
2018-04-17 11:52:00 +02:00
Todd Volkert
c83d24d547
Always add a DevFS asset entry for the font manifest ( #16650 )
...
The engine expects it to always be there.
2018-04-16 21:48:21 -07:00
Alexander Aprelev
9e0a6107fa
Support local-engine option for flutter_tester on Windows. ( #16648 )
2018-04-16 20:40:52 -07:00
jcollins-g
85be28d36b
Add catch for SocketException and tests for exception handling on fetchUrl. ( #16569 )
2018-04-16 14:02:07 -07:00
Jacob Richman
ab9ba3f909
Support exposing the InspectorService over the Flutterservice extension protocol as well as the observatory protocol. ( #15876 )
...
* Support exposing the InspectorService over the Flutter
service extension protocol as well as the observatory protocol.
We will probably remove most of the observatory protocol support once a
couple versions of the Flutter IntelliJ plugin have shipped that use the
Flutter service extension protocol. The only reason to continue supporting
the observatory protocol is it will allow using the inspector when paused
at a breakpoint.
2018-04-16 10:04:40 -07:00
Siva
7dd166fac5
Revert "Turn support for sync-async on in Flutter. ( #16543 )" ( #16626 )
...
This reverts commit b0b2c0077a
2018-04-16 09:54:47 -07:00
Siva
b0b2c0077a
Turn support for sync-async on in Flutter. ( #16543 )
...
* Turn support for sync-async on in Flutter. With this feature
execution of async functions starts immediately instead of it
being delayed by one microtask tick.
* Address review comments.
* Adjust some stack trace expectations which are slightly different with
--sync-async turned on.
2018-04-16 08:44:38 -07:00
Alexander Aprelev
ea30c95dc9
Report RpcException error thrown by _reloadSource vmservice rpc. ( #16417 )
...
* Don't return null, just rethrow RpcException error when vmservice responds with error.
2018-04-13 17:02:14 -07:00
Hans Muller
fb0ab99d6f
Remove Number.tryParse() straggler ( #16570 )
2018-04-13 11:15:33 -07:00
Hans Muller
e7154bee1a
Remove the rest of the uses of Number.tryParse() ( #16568 )
2018-04-13 09:39:01 -07:00
Hans Muller
0260642fc5
Revert some uses of Number.tryParse() ( #16546 )
...
Revert some uses of Number.tryParse(), ignore deprecation warnings for Number.parse()
2018-04-12 19:16:44 -07:00
Konstantin Scheglov
2c183f235f
Build once in FlutterTesterDevice. ( #16457 )
2018-04-12 19:01:55 -07:00
Alexander Aprelev
e0cd42e4ad
Roll engine to 76cb311d9c33720dcd19274228b39ecdbad8d9af (with rolled dart) ( #16518 )
...
* Handle error count reported by frontend.
Extend compilation result from single string to a structure(string filename and integer error count).
* Use ?.
* Include engine roll with dart sdk roll.
* parse(onError) -> tryParse
* Make '?? throw' more readable and avoid issue with analyzer
* Fix test so it mocks compiler output including errors count
2018-04-12 16:28:01 -07:00
Devon Carew
a561722b2b
fix a test flake on appveyor ( #16479 )
...
* fix a test flake on appveyor
* only catch FileSystemExceptions
2018-04-12 15:07:51 -07:00
Siva
dbddcf26b5
Turn off unused changes report during hot reload ( #16520 )
...
* A new UI is being designed to make the unused reload messaging clearer,
the UI will use the coverage data to highlight lines in the UI that were not executed during a reload.
In lieu of that we are turning off the unused reload messages experiment.
There were some issues in Dart2 also with this functionality
- source fingerprinting is not implemented in Dart2
- some additional synthetic functions are generated for invocation argument checking that are not appropriately filtered out.
2018-04-12 14:24:10 -07:00
Chris Bracken
337d6df73d
Pass verbose flag to Xcode subcommands ( #16483 )
...
When flutter builds are run with --verbose, pass the flag through to
flutter sub-commands run via xcode_backend.sh.
2018-04-12 09:30:50 -07:00
Sarah Zakarias
4443e4d4cf
Cleanup FLX related code ( #16416 )
2018-04-12 10:12:26 +02:00
Mikkel Nygaard Ravn
1ba4336494
Require Cocoapods 1.5.0 ( #16443 )
2018-04-12 06:23:14 +02:00
Alexander Aprelev
da9e1a4aca
Introduce fingerprint check for preview-dart-2 build flx. ( #16484 )
...
* Introduce fingerprint check for preview-dart-2 build flx.
* Don't count outputs into fingerpint. Refactor compilation code.
2018-04-11 20:50:25 -07:00
Chris Bracken
b4d57553c8
Simplify script snapshotting code ( #16478 )
...
Inlines the very small amount of work being done in _build() into
buildScriptSnapshot(). Eliminates a duplicate (and un-awaited) call to
_writeFingerprint.
2018-04-11 16:53:32 -07:00
Devon Carew
071485258f
Revert "re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server ( #16281 )" ( #16482 )
...
This reverts commit 2f41ea546f
2018-04-11 16:49:38 -07:00
Devon Carew
2f41ea546f
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server ( #16281 )
...
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
2018-04-11 14:50:36 -07:00
Alexander Aprelev
4c221231c9
Sync .packages file as a normal input file. ( #16467 )
...
* Sync .packages file as regular file.
Currently .packages file is treated specially as DevFSStringContent to accommodate package-file rewrite when it is sent to the device for dart1 compilation. In dart2 we need to treat .packages as regular file because from frontend perspective it's just a normal input file.
2018-04-11 14:48:14 -07:00
Xiao Yu
3923ccf655
Revert 9749bea7b9. Accidentally pushed to flutter instead of fork repo for PR.
...
This reverts commit 9749bea7b9
2018-04-11 13:54:06 -07:00
Xiao Yu
9749bea7b9
Remove the initial xcodebuild clean step which seems unnecessary
2018-04-11 13:52:04 -07:00
Konstantin Scheglov
cf500bf6cd
Integration test for FlutterTesterDevice. ( #16424 )
2018-04-11 08:52:17 -07:00
Todd Volkert
f408bb06f9
Update dependencies ( #16442 )
2018-04-10 14:27:53 -07:00
Konstantin Scheglov
38970f5f75
Add a new Device backed by flutter_tester. ( #16405 )
2018-04-10 09:37:16 -07:00
Chris Bracken
4576f56624
Run iOS gen_snapshot as x86_64 arch ( #16323 )
...
We are about to begin building gen_snapshot as a multi-arch binary,
which when run as x86_64 will generate arm64 AOT output, and when run as
i386 will generate armv7 AOT output.
Currently, gen_snapshot is an x86_64 binary, so this change is
effectively preventative in nature, and is a no-op with the current
snapshotter.
2018-04-09 19:12:05 -07:00
Ian Hickson
44fbf7463b
Minor code cleanup ( #16237 )
2018-04-09 16:33:47 -07:00
Victor Choueiri
da4e06bbca
Update template .gitignore rules ( #15382 )
...
* Update template .gitignore rules
* Remove old packages rule
* Remove IDE folders from gitignore templates
* Prefer ios.tmpl/.gitignore
2018-04-09 15:02:24 -07:00
Sam Rawlins
2329cb7ec8
Bump mockito to 3.0.0-alpha+3 ( #16306 )
...
* Bump mockito to 3.0.0-alpha+3
* Type annotation
2018-04-09 12:43:31 -07:00
Jacob Richman
660408edd6
Switch to the new Matrix4.tryInvert method to avoid throwing and catching ( #15771 ) exceptions while performing hit testing.
2018-04-09 10:32:22 -07:00
Todd Volkert
d9a3ced9db
Check whether we can run sdkmanager in AndroidWorkflow.licensesAccepted ( #16343 )
...
Fixes https://github.com/flutter/flutter/issues/16332
2018-04-09 08:57:11 -07:00
Konstantin Scheglov
d121cbc80d
Make IntelliJPlugins tests use MemoryFileSystem. ( #16341 )
2018-04-08 09:46:11 -07:00
xster
bdc06194fb
Prompt a solution message when flutter tools network fail in China ( #16244 )
2018-04-06 18:44:05 -07:00
Zachary Anderson
d6d874474b
[fuchsia] Fixes for Fuchsia hot reload ( #16317 )
2018-04-06 13:23:16 -07:00
Mikkel Nygaard Ravn
731ed1b11b
Make flutter.gradle support Flutter used as lib ( #16300 )
2018-04-06 13:11:47 +02:00
Mikkel Nygaard Ravn
06b208f353
Make Podfiles work with Cocoapods 1.5.0 ( #16273 )
2018-04-05 22:47:03 +02:00
Jason Simmons
24bfbeb246
Handle whitespace in entry values in the AAPT badging parser ( #16245 )
...
Fixes https://github.com/flutter/flutter/issues/16200
2018-04-05 10:24:05 -07:00
Jonah Williams
5125c43247
re-enable verify only test failure and update deps. ( #16090 )
...
* re-enable verify-only failing test for out of sync deps and update deps to latest version
2018-04-04 10:52:46 -07:00
Konstantin Scheglov
4658ec0f9c
Extract checking IntelliJ packages into a helper and use for Android Studio. ( #16198 )
2018-04-04 10:48:46 -07:00
xster
48478b5952
Remove DevToolsSecurity check from initial flutter doctor ( #16007 )
2018-04-04 10:35:38 -07:00
Todd Volkert
d4084cde7d
Revert "Adds Java EE module to SDK manager calls" ( #16227 )
...
This reverts https://github.com/flutter/flutter/pull/16035
2018-04-04 09:46:26 -07:00
Devon Carew
aa55f50ddb
update intellij metadata in template files ( #16211 )
2018-04-04 09:36:34 -07:00
Devon Carew
13bafba994
add a period after xcode build done ( #16209 )
2018-04-04 07:22:58 -07:00
Luke
0c18d29643
Adds Java EE module to SDK manager environment to stop missing xml library exception when checking for licenses. ( #16035 )
2018-04-02 23:06:28 -07:00
Anatoly Pulyaevskiy
78434580d2
Upgrade quiver to 0.28.1 in flutter_test to fix usage of Maps ( #16132 )
2018-04-02 22:26:49 -07:00
Jonah Williams
0c89920069
Update logic for parsing sdk version number ( #15918 )
...
* add logic to parse 11.3 sim runtime major version
* add null aware and bump group number
* add comment describing version
2018-04-01 17:35:05 -07:00
Todd Volkert
8d6673dcf0
Revert "Make sure flutter update-packages --verify-only has a non-zero exit code ( #15962 )" ( #16089 )
...
This reverts commit cfda7a6548
2018-03-29 21:34:31 -07:00
Jonah Williams
cfda7a6548
Make sure flutter update-packages --verify-only has a non-zero exit code ( #15962 )
...
* make sure --verify-only logs error messages and fix typo
* ensure non zero exit code
* undo random pubspec change
2018-03-29 20:34:49 -07:00
Jason Simmons
b4274ef685
URL encode asset paths to support reserved characters in paths ( #16046 )
...
Fixes https://github.com/flutter/flutter/issues/14864
2018-03-29 13:47:35 -07:00
Todd Volkert
f69d125954
Move Cache.flutterRoot initialization up sooner ( #16057 )
...
It's required to be set before we detect local engine.
Was broken by #15984
2018-03-29 09:16:34 -07:00
Ralph Bergmann
895707324d
improve Flutter build commands ( #15788 )
...
add --buildNumber and --buildName to flutter build like
flutter build apk --buildNumber=42 --buildName=1.0.42
2018-03-29 05:58:31 -07:00
Todd Volkert
2c898f6813
Remove writelnStderr ( #16058 )
...
Paying off technical debt...
2018-03-29 05:55:32 -07:00
xster
4565395693
Let iOS auto-signing tool handle Googler scenario ( #16010 )
...
* Let iOS auto-signing tool handle Googler scenario
* Forgot to update tests
2018-03-28 18:58:06 -07:00
Todd Volkert
f8058d7fb2
Make AppContext API not be prone to Future oddities ( #16034 )
...
Follow-up comments to #15984
2018-03-28 15:17:29 -07:00
Alexander Aprelev
bffae21571
Again move mockito to 300plus2 ( #15981 )
...
* Revert "Revert "Move mockito to 3.0.0-alpha. (#15949 )" (#15979 )"
This reverts commit e59651f925194d2cf41752c9e96b30
2018-03-28 12:07:12 -07:00
Todd Volkert
8d11f5c763
Make AppContext immutable and race-free ( #15984 )
...
This updates AppContext per the recommendations in #15352
Fixes #15352
2018-03-28 10:58:28 -07:00
Alexander Aprelev
e59651f925
Revert "Move mockito to 3.0.0-alpha. ( #15949 )" ( #15979 )
...
This reverts commit a7e6225820
2018-03-27 10:38:20 -07:00
Alexander Aprelev
a7e6225820
Move mockito to 3.0.0-alpha. ( #15949 )
...
* Move mockito to 3.0.0-alpha.
This is needed so it matches mockito version used internally.
* Pick up +2 for the fixes
* Fix whenReturn in fuchsia_remote_debug_protocol
* more thenReturn becomes thenAnswer
* more thenReturn becomes thenAnswer
* more thenReturn becomes thenAnswer
2018-03-27 10:05:16 -07:00
Jonah Williams
e91683942c
Update AndroidManifest to include screenLayout|density in config changes ( #15871 )
...
* android templates should add density and screenLayout to config changes
* update the rest of the manifests
2018-03-24 12:38:42 -07:00
Alexander Aprelev
af74a7253b
Send relative uri when target physical file path is specified. ( #15887 )
2018-03-23 19:18:39 -07:00
Andrew Davies
72fd020a24
[fuchsia_remote_debug_protocol] Adds the fuchsia remote debug protocol package.
...
Adds a package that will support connecting to and debugging devices with multiple instances of the Dart VM, and operate on multiple Isolates and Flutter Views.
Currently supports connecting to all existing Dart VMs and extracting information about all Flutter Views running across each VM.
2018-03-22 17:19:02 -07:00
Alexandre Ardhuin
061352918b
enable lint avoid_relative_lib_imports ( #15780 )
2018-03-22 07:56:18 +01:00
Alexandre Ardhuin
217b2bdaa1
add new lints of linter-0.1.44 and enable unnecessary_parenthesis ( #15585 )
2018-03-21 07:10:14 +01:00
Jonah Williams
ad9506d25a
Traverse dependencies and dev dependencies separately ( #15581 )
...
* traverse dependencies and dev dependencies separately
* separate dev and reg deps
* update pubspecs
* add checksum string and update transitive dep string. Add additional verify command to check checksum
* cleanup comments
* add missing space, quote, run verify-onlu from bot script
* rerun tool with fixed string
* ensure correct working directory and bump versions
* flutter not flutterRoot
2018-03-20 20:03:32 -07:00
