Commit Graph

2363 Commits

Author SHA1 Message Date
Jonah Williams
6cb74eeac8
fix apk location for devicelab (#54697) 2020-04-13 16:56:27 -07:00
Yegor
14cceefe2b
Make Web shard count configurable via WEB_SHARD_COUNT (#54678) 2020-04-13 16:05:02 -07:00
Jonah Williams
e21266294f
Revert "Do not wait for connections after process has exited (#54497)" (#54618)
This reverts commit 283ec9e2a1.
2020-04-13 11:04:31 -07:00
Emmanuel Garcia
54dba4cd59
Don't import plugins that don't support android in settings.gradle (#54407) 2020-04-12 08:55:03 -07:00
Kaushik Iska
7b9aeb2ff2
[flutter_driver] Reland add SceneDisplayLag stats to timeline summary (#54490) 2020-04-11 15:30:01 -07:00
Yegor
559a27aaae
mark web benchmarks as not flaky (#54505) 2020-04-10 19:34:51 -07:00
Yegor
283ec9e2a1
Do not wait for connections after process has exited (#54497) 2020-04-10 16:54:10 -07:00
Yegor
d119e5f1e4
Add A/B test mode to local devicelab runner (#54494)
* Add A/B test mode to local devicelab runner
2020-04-10 16:53:52 -07:00
Mouad Debbar
b0610be3b4
[web] Don't collect trace info in the color grid benchmark (#54396) 2020-04-10 13:30:15 -07:00
Kaushik Iska
50b4c39c5d
Revert "[flutter_driver] Add SceneDisplayLag stats to timeline summary (#54218)" (#54480)
This reverts commit ce92333bf7.
2020-04-10 12:48:48 -07:00
Kaushik Iska
ce92333bf7
[flutter_driver] Add SceneDisplayLag stats to timeline summary (#54218) 2020-04-10 12:20:01 -07:00
Jonah Williams
f7de5aa5b0
fix visual density prefer_const_constructors lint (#54471) 2020-04-10 11:20:25 -07:00
Shi-Hao Hong
bec1b734bd
Cleanup in gen_l10n files (#54401) 2020-04-10 10:35:33 -07:00
Chris Yang
7042481dae
fix test (#54403) 2020-04-10 10:30:04 -07:00
Greg Spencer
d64955ab49
Add visualDensity and focus support to ListTile (#53888) 2020-04-10 10:20:02 -07:00
Tong Wu
a5765331bc
Re-enable deploy_gallery. (#54248) 2020-04-09 16:15:01 -07:00
Jonah Williams
4b98c0565a
Revert "fix and re-land "re-enable android_view_test (#54214)" (#54312)" (#54387)
This reverts commit 13052b10e4.
2020-04-09 12:41:00 -07:00
Jacob MacDonald
efdce3cf72
drop image package dependency for goldens (#54144) 2020-04-09 11:21:23 -07:00
Chris Yang
13052b10e4
fix and re-land "re-enable android_view_test (#54214)" (#54312) 2020-04-09 11:03:02 -07:00
Per Classon
4451ffca23
Add option for deferred loading to gen_l10n (#53824) 2020-04-09 03:57:01 -07:00
Filip Hracek
1593788cd9
Rename GPU thread to raster thread in API docs (#53422) 2020-04-08 18:57:03 -07:00
Shi-Hao Hong
5d63637e43
[gen_l10n] Fallback feature for untranslated messages (#53374)
* Generate methods using template resources if they do not exist in other locales

* Added a flag to either output of messages that have not been translated with detail into a file, or display a summary on the terminal.

* Add integration test for fallback message usage
2020-04-08 18:55:50 -07:00
Jonah Williams
dbecf2afd5
Revert "enable the regressed test (#54214)" (#54307)
This reverts commit f8784e72a9.
2020-04-08 13:58:33 -07:00
Shi-Hao Hong
592f7886e5
Remove escape dollar parameter in localizations_utils (#54219) 2020-04-08 12:52:03 -07:00
Christopher Fujino
19c8948e61
Fix frameworkVersionFor for flutter doctor and usage (#54217) 2020-04-08 12:47:05 -07:00
Chris Yang
f8784e72a9
enable the regressed test (#54214) 2020-04-08 12:42:03 -07:00
Kate Lovett
bcc7961d00
Skip Audits (2) (#53837) 2020-04-08 12:37:03 -07:00
Chris Yang
fc06d3feb3
Disable flutter_driver_screenshot_test_ios. (#53358) 2020-04-08 12:32:03 -07:00
Francisco Magdaleno
a0f7f6ca6d
[windows] Adds support for keyboard mapping. (#54227) 2020-04-08 10:07:02 -07:00
Yegor
4e3cf198e8
disable tracing for non-frame based benchmarks (#54236) 2020-04-08 09:17:03 -07:00
Michael Goderbauer
d47ad7ec0d
Reverse dependency between services and scheduler (#54212) 2020-04-08 09:12:03 -07:00
Jonah Williams
981afe39ae
[flutter_tools] ensure build fails if asset files are missing (#54233)
Ensure build fails if asset files are missing and that stderr messages are forwarded through Gradle
2020-04-07 19:42:57 -07:00
Jonah Williams
0a25309fb1
[versions] update versions (#54247) 2020-04-07 19:42:02 -07:00
Greg Spencer
0f68b46f6a
Revise Action API (#42940)
This updates the Action API in accordance with the design doc for the changes: flutter.dev/go/actions-and-shortcuts-design-revision

Fixes #53276
2020-04-07 16:49:39 -07:00
Jose Alba
3441d6cbe7
Slider rebase work (#53916)
* [Slider] Rebase.

* disabled thumb color with alphaBlend of colorScheme surface

* test remove alphablend

* Change rectangular track to how it used to be

* Chaned to adaptive slider

* blank lines

Co-authored-by: Will Larche <larche@google.com>
2020-04-07 17:10:18 -04:00
Per Classon
e8d2907595
[gen_l10n] Handle single, double quotes, and dollar signs in strings (#54185) 2020-04-07 12:21:02 -07:00
Michael Thomsen
98e7791ec9
Roll pinned xml and petitparser versions (#54181) 2020-04-07 12:16:03 -07:00
Konstantin Scheglov
b0492cc976
Fix newly reported prefer_const_constructors lints. (#54176) 2020-04-07 08:59:01 -07:00
Amir Hardon
ba18e99d1b
Enable the android_views AlertDialog test (#54163) 2020-04-07 08:32:13 -07:00
Tong Wu
39954a0924
[cleanup] Remove unused script (#54155) 2020-04-06 18:49:06 -07:00
Todd Volkert
de1e572916
Don't checkout master in roll_dev (#54150) 2020-04-06 16:15:07 -07:00
Mouad Debbar
e3e189219b
[web] Fix race condition in widget benchmarks (#53952) 2020-04-06 14:31:38 -07:00
Yegor
de27d7131c
disable the "gpu" tracing category (#54122) 2020-04-06 13:44:02 -07:00
Alexandre Ardhuin
f5a9902577
enable avoid_equals_and_hash_code_on_mutable_classes (#52507) 2020-04-06 13:36:01 -07:00
Amir Hardon
80bc3f4a3c
Test creation of Android AlertDialogs with a platform view context (#53980) 2020-04-06 12:36:01 -07:00
stuartmorgan
2d623278e7
Restructure the Windows app template (#53600)
This moves the app template more toward being a more generic starting
point for any Flutter application, eliminating some hard-code
assumptions about there being a single window/engine pair that is
directly bound to the life of the application:
- Moves the runloop into its own class, making it capable of servicing
  any number of engine instances.
- Moves the logic for setting up a window containing only a Flutter view
  into a window subclass for ease of re-use.
- Makes quit-on-window-close an optional property. (Long term this
  should be even more generic, like a quit-when-last-window-closes
  option, but this is a short-term improvement that removes the binding
  between the runloop and the window).
- Allows for multiple instances of Win32Window to exist without issues
  relating to the window class registration.

Since there are getting to be a non-trivial number of files associated
with the runner, this moves the source into a runner/ directory, as is
already done on some other platforms.

Note that creating multiple Flutter windows at the same time still
doesn't work correctly even with this change, but this addresses some of
the known issues, and makes it easier to test in the future (e.g., for
debugging engine-level issues with multiple instances).

Fixes #45397
2020-04-06 12:24:05 -07:00
Anisov Aleksey
be6234d56e
Read custom app project name from gradle.properties (#52791) 2020-04-05 20:46:44 -07:00
Todd Volkert
f5fe1e3e62
Update roll_dev to work with new version numbers (#54015) 2020-04-04 21:28:34 -07:00
Amir Hardon
caeaac7739
disable MotionEvents test (#54023) 2020-04-04 19:25:11 -07:00
Amir Hardon
f0aea666d7
revive the android_views test (#53963) 2020-04-04 16:41:01 -07:00
Yegor
4b92c16755
Use "measured_frame" instead of "CrRendererMain" to detect process ID (#53969) 2020-04-03 16:51:44 -07:00
Shi-Hao Hong
4e811d2819
[gen_l10n] Fix plural parsing for translated messages (#53954) 2020-04-03 15:46:01 -07:00
Yegor
c6ee4d268f
Temporarily mark web benchmarks as flaky (#53967) 2020-04-03 15:35:44 -07:00
Yegor
29c88081b9
Collect chrome://tracing data in Web benchmarks (#53879)
Collect chrome://tracing data in Web benchmarks
2020-04-03 15:10:39 -07:00
Shi-Hao Hong
365528aad6
Use no locale as synonym for nb (#53880) 2020-04-03 11:56:02 -07:00
Kate Lovett
63f8b9a4d5
Improving A11y for Flutter Gallery Demos (#53616) 2020-04-03 10:34:14 -07:00
Shi-Hao Hong
6837b0e353
[gen_l10n] Add scriptCode handling (#53868)
* [gen_l10n] Add scriptCode handling
2020-04-03 09:46:01 -07:00
Greg Spencer
a8b3d1b74f
Add toggleable attribute to Radio (#53846)
This adds a new toggleable attribute to the Radio widget. This allows a radio group to be set back to an indeterminate state if the selected radio button is selected again.

Fixes #53791
2020-04-02 15:40:37 -07:00
Greg Spencer
e20080b5d1
Add LICENSE file to packages/flutter, add test to make sure it… (#53799)
This adds a LICENSE file to the packages/flutter directory so that it can be found when building, and a test to make sure it exists in produced binaries.
2020-04-02 10:38:25 -07:00
Shi-Hao Hong
19e7db585d
[gen_l10n] Escape special JSON characters in generateString utility function (#53605) 2020-04-01 11:16:01 -07:00
Emmanuel Garcia
e61ab4a832
Copy APK into a known location, so it can be easily discovered (#53718) 2020-04-01 10:03:56 -07:00
Yegor
0d07788069
Add benchmark reproducing large static scrolling content (#53686) 2020-04-01 00:41:02 -07:00
Jose Alba
d14a301e41
Revert "[Slider] Rebase. (#52663)" (#53698)
This reverts commit e71cf1cdbe.
2020-03-31 16:14:22 -07:00
Casey Hillers
025f7ae642
Add ability to shard customer tests (#53433) 2020-03-31 14:01:01 -07:00
Kate Lovett
d3be7e1577
Restore codegen in separate PR (#53617) 2020-03-31 13:21:01 -07:00
Emmanuel Garcia
183b3c321e
Turn metal on in the platform views benchmark (#53676) 2020-03-31 11:56:23 -07:00
Alexander Aprelev
c6665e43da
Roll flutter engine to 10887c2abe7b7fe5866e84d6b63dd546f02fc963 (#53669)
* Update stack trace test expectations to adjust for a fix landed in dart sdk

* Include engine roll to 10887c2abe7b7fe5866e84d6b63dd546f02fc963

* Update column for the exception expectation
2020-03-31 11:28:03 -07:00
Kate Lovett
560c72287b
TODO Audits - 1 (#53604) 2020-03-31 11:21:01 -07:00
Kate Lovett
9b6fd7cb0b
Separate PR (#53619) 2020-03-31 11:16:02 -07:00
Jose Alba
e71cf1cdbe
[Slider] Rebase. (#52663) 2020-03-31 10:56:01 -07:00
Jonah Williams
8cb1d269f6
[versions] update EVERYTHING (#53467) 2020-03-30 14:09:38 -07:00
gaaclarke
12c7edec4d
Revert "disabled flutter_gallery_ios32__transition_perf (#53435)" (#53442)
This reverts commit ba0df45c12.
2020-03-27 16:06:11 -07:00
gaaclarke
ba0df45c12
disabled flutter_gallery_ios32__transition_perf (#53435) 2020-03-27 15:35:40 -07:00
Mouad Debbar
45a8b3db81
complete text layout benchmark (#53295) 2020-03-27 14:56:02 -07:00
Jenn Magder
57b0ddbd60
Uninstall app flag (#53385) 2020-03-27 10:13:54 -07:00
xster
ef7eb7edb3
Remove flutter attach test timeout (#53317) 2020-03-26 09:56:02 -07:00
gaaclarke
83a74e11d2
Started caching results from iana. (#53286) 2020-03-25 18:16:02 -07:00
xster
1376746237
Reland #53153 to attach to existing modules and apps for Android (#53289) 2020-03-25 16:45:49 -07:00
Jenn Magder
12dfa1e9fb
Mark stable devicelab tests as unflaky (#53310) 2020-03-25 16:24:17 -07:00
adityapstar
a57feac62e
fixed typo in HttpClient failure message (#53211) 2020-03-25 15:26:01 -07:00
chunhtai
9fdd4d2e0c
Renamed test class to avoid conflict with the navigator page api. (#53279) 2020-03-25 12:11:01 -07:00
Jenn Magder
b684041bb8
Revert "Let flutter attach find the service port by looking through old logs again (#53153)" (#53282)
This reverts commit 0c5ffdc9ef.
2020-03-25 10:53:45 -07:00
xster
0c5ffdc9ef
Let flutter attach find the service port by looking through old logs again (#53153) 2020-03-24 23:26:01 -07:00
Mouad Debbar
af21e74fef
[web] Write benchmarks to measure canvas-based text layout (#52434) 2020-03-24 22:10:25 -07:00
Darren Austin
142b526f1b
Material Date Picker redesign (#50546)
Date Picker UI redesign
2020-03-24 18:44:57 -07:00
Erik Ernst
d99ab6aa2c
Update utils.dart to work with the breaking change of SDK issue 40678 (#53093) 2020-03-24 14:21:01 -07:00
Jonah Williams
10571920c0
[flutter_tools] update to latest dwds API (#52936)
Should fix issues introduced in web-server device and allow loading org-dartlang-app URIs
2020-03-23 18:47:50 -07:00
stuartmorgan
685e9d1e47
Add pre-stable support for create on Windows (#51895)
Adds initial support for flutter create of apps and plugins. This is derived from the current FDE example app and sample plugin, adding template values where relevant.

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the create output about the fact that it won't be stable.

Plugins don't currently have a version marker since in practice this is not a significant problem for plugins yet the way it is for runners; we can add it later if that changes.

Fixes #30704
2020-03-23 10:42:26 -07:00
Yegor
2e36be7691
Enable more material and cupertino tests on the Web (#52961) 2020-03-20 11:36:24 -07:00
Jenn Magder
8001abec43
Add entitlement checks to codesigning test (#52919) 2020-03-20 10:23:56 -07:00
Yegor
5ea13b8493
fix KeySet.hashCode; enable multiple web tests (#52861)
fix KeySet.hashCode; enable multiple web tests
2020-03-20 08:49:19 -07:00
Ian Hickson
74a505b195
Some minor cleanup for the customer_testing shard (#49501)
* Allow projects that don't have tests on every platform.
  We don't really need to enforce that random projects have
  tests on every platform.

* Add some text at the end of the shard so we know it's
  actually running all the tests.
2020-03-19 19:03:36 -07:00
Chris Yang
b05210c707
Move ios screenshot test to flutter gold. (#52553) 2020-03-19 16:27:41 -07:00
Janice Collins
601c8dbebb
Update dartdoc to 0.30.2 (#52022) 2020-03-19 14:56:03 -07:00
Emmanuel Garcia
bec7f84a57
Fix package name (#52870) 2020-03-19 09:31:02 -07:00
Emmanuel Garcia
83fdf78a89
Mark platform_views_scroll_perf__timeline_summary as flaky (#52853) 2020-03-18 15:50:15 -07:00
Yegor
7b4c195f99
Fix web test flakiness; enable web golden tests (#52789)
* Fix web test flakiness; enable web golden tests

The fix is three-part:

- Only allow one test to load _and_ test at any point in time.
- Use a fresh Chrome instance for each test file.
- Increase Cirrus resources.

The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests.

Other minor changes:

- Remove test batching (it's no longer necessary)
- Fix the Chrome class, which was using the wrong Completer.
2020-03-18 15:11:48 -07:00
Emmanuel Garcia
f9b2d42b0e
Android test should run in stage: devicelab (#52850) 2020-03-18 14:17:24 -07:00
Emmanuel Garcia
4fa3d8c7e3
iOS test should specify DeviceOperatingSystem.ios (#52848) 2020-03-18 14:07:49 -07:00
Emmanuel Garcia
a3c6e4a0b9
Reland: Add Platform View benchmark (#52839) 2020-03-18 13:24:52 -07:00
Sam Rawlins
5d0e87ce38
Exclude codegen/lib/main.dart from static analysis (#52829) 2020-03-18 13:16:02 -07:00
Emmanuel Garcia
dc8ffe0430
Revert "Add benchmark for platform views (#52717)" (#52834)
This reverts commit 1f1731842a.
2020-03-18 11:16:38 -07:00
Emmanuel Garcia
1f1731842a
Add benchmark for platform views (#52717) 2020-03-18 10:55:50 -07:00
Jonah Williams
da0788a180
Update fuchsia remote debug protocol to use package:test shim instead of package:test_api (#52706)
This is necessary to ensure the tests can run in google3. Fixes https://b.corp.google.com/issues/151657461
2020-03-18 09:12:46 -07:00
Jonah Williams
b7101b45f5
[flutter_tools] disable added integration test due to Cirrus flakes (#52782) 2020-03-17 19:07:22 -07:00
Jonah Williams
6884086e5c
[flutter_tools] Update to latest dwds APIs (#51004)
Update to latest dwds APIs, moving back to dwds driven hot restart and enabling future work on expression evaluation.
2020-03-17 17:29:53 -07:00
Jonah Williams
a7011c4817
[flutter_tools] don't force service worker cache files to be absolute (#52606) 2020-03-17 10:17:03 -07:00
Shi-Hao Hong
351457cdd0
[gen_l10n] Separate out AppLocalizations classes and subclasses by language code (#52335) 2020-03-17 08:46:02 -07:00
Michael Thomsen
e36f4a467f
Fix paths causing test failures (#52660) 2020-03-16 14:05:48 +01:00
Michael Thomsen
e167181444
Move flutter_gallery to the testing folder (#52532)
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
2020-03-16 10:31:42 +01:00
liyuqian
8bff33e497
Remove missed frame budget count (#52560) 2020-03-13 17:26:02 -07:00
liyuqian
c80d1e8266
Perf test for color filter with saveLayer (#52063) 2020-03-13 10:31:02 -07:00
Greg Spencer
289deef8c5
Add C++ code generation for key maps. (#50998)
This adds generation of some C++ keycode maps for various platforms.

This isn't meant for general use: it's so that the Flutter authors can keep the keycodes up to date with the Chromium and Android (and other) sources. It doesn't run continuously, it's only run occasionally (manually) to update the maps, because they don't change very often, and there is often manual work needed to make it function.

In this PR, I added output of various .cc files that write into an engine repo situated next to the flutter repo on disk. This is a starting point for implementing platform-side handling of key events.
2020-03-12 17:39:31 -07:00
Chris Yang
8bcd94817f
Fix ios_platform_view_tests app name. (Trivail) (#52446) 2020-03-12 15:39:01 -07:00
Shi-Hao Hong
183da8f837
[gen_l10n] Fix suppportedLocales list (#52448)
* Fix suppportedLocales list

* Refactor integration tests for gen_l10n tool to catch exceptions
2020-03-12 12:58:13 -07:00
Jonah Williams
d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479)
Reland of #52149
2020-03-12 12:48:05 -07:00
Chris Yang
7fb7ea63b3
Reland "Add ios platform view integration test (#51882)" (#52440) 2020-03-11 16:32:47 -07:00
Shi-Hao Hong
96fd143cd7
[gen_l10n] Optional Headers (#52125)
* Expose --header and --header-file arguments for gen_l10n
2020-03-11 13:55:54 -07:00
Emmanuel Garcia
4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Mouad Debbar
5bb552270d
[web] Add benchmarks for text layout (#51663) 2020-03-10 18:46:03 -07:00
Chris Yang
fc5350ed04
Revert "Add ios platform view integration test (#51882)" (#52373)
This reverts commit 357fd2db38.
2020-03-10 18:42:15 -07:00
Chris Yang
357fd2db38
Add ios platform view integration test (#51882) 2020-03-10 17:33:01 -07:00
Greg Spencer
d19c44344b
Add sample for InheritedNotifier, convert two others to DartPa… (#52349)
This adds a sample for InheritedNotifier, and converts a couple of other samples to be DartPad samples. I also added a new sample template stateful_widget_material_ticker, which adds a TickerProviderStateMixin to the state object so that animation controllers can be created there easily.
2020-03-10 15:23:45 -07:00
Ben Konyi
66b978a197
Update pub dependencies to roll forward package:test (#52273) 2020-03-10 13:26:02 -07:00
Jonah Williams
4ce34f2516
[benchmarks] remove archived build aot benchmarks (#52283) 2020-03-09 20:15:59 -07:00
Francisco Magdaleno
e9905b6ad8
[Keyboard] Collects windows key data (#52265) 2020-03-09 17:21:02 -07:00
Jonah Williams
c1112d3f7e
[flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds (#52044) 2020-03-06 14:53:36 -08:00
Jonah Williams
9437639590
[flutter_tools] fix coverage measurement to report on lib and not test (#52093) 2020-03-06 10:24:23 -08:00
Jonah Williams
ee476a7bd1
Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714)" (#52041)
This reverts commit ee60eeea3e.
2020-03-05 12:51:42 -08:00
Jonah Williams
ee60eeea3e
[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714) 2020-03-05 12:38:40 -08:00
Jonah Williams
bbf913bc4c
[flutter_tools] resolve requests to web directory in debug mode (#51995) 2020-03-05 12:34:03 -08:00
Alexandre Ardhuin
c2ae654ddf
enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Flutter GitHub Bot
9c5009b251
[gen_l10n] Escape quote characters in ARB files (#51952) 2020-03-04 20:41:03 -08:00
Jonah Williams
124aa6f8b1
[flutter_tools] use package:test for coverage and remove build_runner test precompilation (#51966) 2020-03-04 17:12:58 -08:00
Jenn Magder
7593228665
Mark devicelab tests as no longer flaky (#51977) 2020-03-04 17:03:18 -08:00
Jason Simmons
c971ba0db4
Increase the timeout for the cull_opacity_perf_test to 45 seconds (#51962)
Fixes https://github.com/flutter/flutter/issues/51795
2020-03-04 13:53:01 -08:00
Flutter GitHub Bot
e22ceb0c7a
Add textfield perf test to devicelab (#51788) 2020-03-04 13:16:03 -08:00
Jenn Magder
32716b9e9b
Bitcode strip embedded iOS frameworks (#51914) 2020-03-04 13:15:33 -08:00
Ben Konyi
3edd3eb4a2
Updated package:test, package:test_core, package:coverage, package:package_config (#51946)
This is required to roll forward package:vm_service to 3.0.0 and is
blocking a DevTools release.
2020-03-04 11:40:52 -08:00
Jenn Magder
e491544588
Move embedding and linking Flutter frameworks into the tool (#51453)
* Move embedding and linking Flutter frameworks into the tool

* Unused import

* Migrate

* Rename run, add comments, remove typedef

* Add status log to tell the user what we did

* Remove Podfile migration, create IOSMigration superclass

* word-smiting

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* for space

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-03-03 12:11:28 -08:00
Shi-Hao Hong
d2c734a36f
Simple repeating word fixes (#51871) 2020-03-03 11:13:07 -08:00
Greg Spencer
1ba4f1f509
Add Linux and Windows target platforms (#51519)
This PR adds the linux and windows target platform enum values, along with automatically setting the defaultTargetPlatform to the appropriate value on those platforms.

Fixes #31366
2020-03-03 04:38:04 -08:00
Chris Bracken
f3018c378a
Revert "Temporarily disable the flutter_driver_screenshot_test. (#51665)" (#51783)
The original commit actually *enabled* the test by removing the
flaky: true field in the commit.

This reverts commit 1d3fcfd6ca.
2020-03-02 09:45:24 -08:00
Chris Yang
1d3fcfd6ca
Temporarily disable the flutter_driver_screenshot_test. (#51665) 2020-02-29 10:01:18 -08:00
Shi-Hao Hong
c98500dea3
Update gen_l10n tool to require base locale; Stocks app refresh (#51602) 2020-02-28 22:21:01 -08:00
Jonah Williams
9b4159c5ee
[flutter_tools] support run -d chrome test scripts (#51658) 2020-02-28 14:21:02 -08:00
Mouad Debbar
03d6b58002
[web] Allow benchmarks to customize their score keys (#51493) 2020-02-28 13:54:45 -08:00
Yegor
bae79599c2
add docs about writing/running web benchmarks (#50989)
* add docs about writing/running web benchmarks

* explain how to run like devicelab

* add WidgetBuildRecorder docs
2020-02-28 10:16:35 -08:00
Yegor
cd0fbd3205
improve web benchmark error reporting (#51490) 2020-02-28 10:14:22 -08:00
stuartmorgan
33bb1faf5b
Reland: Always use new plugin schema for plugin template (#49832)
Now that the new schema is supported on the stable channel, and the old
schema is considered legacy, the template should always create plugins
using the new schema.
2020-02-27 22:48:25 -08:00
Jason Simmons
d499d61efe
Update Android activities because plugin registration is now done by FlutterActivity.configureFlutterEngine (#50841) 2020-02-27 18:16:04 -08:00
Jonah Williams
08d079f6c2
[flutter_tools] wire up complete support for Dart obfuscation (#50509) 2020-02-27 08:58:33 -08:00
Dan Field
c75db98337
Live image cache (#51485)
* Reland "Live image cache" (#51441)

This reverts commit 419a2853a8.

* Make evict safer
2020-02-26 16:01:56 -08:00
Greg Spencer
9e744c5710
Implement VisualDensity for text fields. (#51438)
This implements VisualDensity changes for text fields*. By default, the layout of the text field does not change.

If the ThemeData.visualDensity is set to a value other than zero, then the density of the UI will increase or decrease. See the VisualDensity docs for more information.

(*In reality, the changes are on the InputDecorator class, not on the text field.)

I also fixed a problem that I think I found with _Decoration where it doesn't compare isDense or isCollapsed as part of its operator==.
2020-02-26 13:38:28 -08:00
Jonah Williams
55072246d0
[flutter_tools] remove build script from tool package (#50690) 2020-02-26 08:25:04 -08:00
Alexandre Ardhuin
a4054938ce
unnecessary multiline strings (#50806) 2020-02-25 18:12:17 -08:00
Dan Field
419a2853a8
Revert "Live image cache" (#51441)
* Revert "Live image cache (#51249)"

This reverts commit e2dcdb60e3.

* fix tests for other commit
2020-02-25 16:52:47 -08:00
Nate Bosch
9228b87eb3
Don't use a default test randomize ordering seed (#51018)
Fixes #51010

The test package differentiates between passing and not passing this
argument. A previous version had a bug that treated passing `0`
identically to not passing the argument, and the flutter test runner
relied on this bug by always passing a value and using a default of `0`.

- Remove the argument defaults throughout to make it clear that `null`
  is a valid value and the default.
- Remove the argument defaulting on the argument parser.
- Update the wording of the usage for this argument, this will also be
  updated on the `package:test` side.
2020-02-25 13:01:40 -08:00
Christopher Fujino
704fb4cbc7
Remove usage of ideviceinstaller in favor of ios-deploy (#50772) 2020-02-25 09:09:40 -08:00
Hans Muller
13e1336e6c
Generate message lookup in gen_l10n (#50733) 2020-02-24 20:17:13 -08:00
Yegor
d95a1a70a2
add WidgetBuildRecorder for benchmarking building widgets (#51088) 2020-02-24 16:08:40 -08:00
Dan Field
889e606ceb
Script to find Flutter earliest Flutter revision that contains an engine revision (#50948) 2020-02-24 14:49:12 -08:00
Jonah Williams
e6e79bce6f
[flutter_tools] remove vm_service_client dependency from flutter tool (#51227) 2020-02-24 14:19:43 -08:00
Dan Field
e2dcdb60e3
Live image cache (#51249)
* Revert "Revert "Live image cache (#50318)" (#51131)"

This reverts commit 2f09d601b5.

* Fix eviction of a pending image
2020-02-24 13:47:53 -08:00
Greg Spencer
c5dd3ec47a
Fix stuck keys when shift is released before the letter. (#51095)
This fixes a problem where if you press "Shift" and then "A", then release "Shift" and then "a", then the "A" key will be "stuck" on because the logical key for the key down message is different (capital "A") from the logical key for the key up message (lowercase "a").

This PR changes the pressed keys logic so that it uses the physical key to add/remove keys from the list of pressed keys, but keeps the associated logical key.

This does mean that after the "Shift" key goes up, the pressed keys contains a capital "A" and it doesn't switch to be a lowercase "a", but there isn't currently any mechanism we can use to do that remapping. This is far less surprising than the current behavior, but is still not quite correct.

I fixed the event simulation code to take a physicalKey so that it could be matched with the logical key, but the event simulation code isn't up to the task, since it can only simulate keys that appear in the key maps. The new platform key event design should fix that (added TODOs).
2020-02-21 14:13:38 -08:00
Jason Simmons
479e27c9f1
Update stack trace test goldens to handle engine builds with lazy async stacks (#51216)
The next engine roll will introduce --lazy-async-stacks, which affects the
contents of stack traces.  This updates test expectations to match both the
old and new stack trace formats.
2020-02-21 12:05:30 -08:00
Dan Field
d46d77dc05
Make test more flexible for new args from vm (#51217) 2020-02-21 10:35:54 -08:00
Dan Field
7034bc57df
Reduce duration of benchmark to avoid timeout (#51214) 2020-02-21 09:59:23 -08:00
Clement Skau
3275adb7fb
Updates test expectations for stack traces. (#51185)
With --lazy-async-stacks the stack output has changed slightly so updating the expect files to match.

This is a follow-up to https://github.com/flutter/flutter/pull/51047 as a preparation for the next engine roll which will start enabling --lazy-async-stacks in JIT mode.
2020-02-21 13:38:56 +01:00
Dan Field
2f09d601b5
Revert "Live image cache (#50318)" (#51131)
This reverts commit 1602be6ab6.
2020-02-20 13:20:28 -08:00
Harry Terkelsen
29306b0896
[Web] Add Material Card Infinite Scroll benchmark (#51005)
* [Web] Add Material Card Infinite Scroll benchmark

Adds a benchmark that makes an infinite list of Material cards
and scrolls it. This benchmark exercises more heavyweight rendering
like shadows and clipping and paths.

* Fix analyzer warnings. Respond to comments
2020-02-20 11:16:58 -08:00
Dan Field
d030296a97
Reland test (#50987) 2020-02-20 01:51:15 -08:00
Dan Field
2ce51aa284
add macos project to macrobenchmarks (#50999) 2020-02-20 01:50:51 -08:00
Alexandre Ardhuin
7d7ac7c32b
start multiline strings with newline (#50825) 2020-02-20 10:16:28 +01:00
Greg Spencer
d8a2169741
Revert "Upgrade dartdoc to 0.30.1 (#50980)" (#51060)
This reverts commit a51de38a20 because it breaks the flutter docs.
2020-02-19 09:55:32 -08:00
Dan Field
f81588a5a3
Roll engine bb01cb7faf26..77c5812d48b8 (#50994) 2020-02-18 16:33:55 -08:00
Sunbreak
fcf7fda99c
Remove miscellaneous xcworkspacedata (#50715) 2020-02-18 12:41:27 -08:00
Janice Collins
a51de38a20
Upgrade dartdoc to 0.30.1 (#50980) 2020-02-18 12:40:10 -08:00
Jonah Williams
d0b7f0cd4e
Revert "Animated placeholder perf (#50851)" (#50984)
This reverts commit e4fbb1aba6.
2020-02-18 12:32:46 -08:00
Dan Field
e4fbb1aba6
Animated placeholder perf (#50851) 2020-02-18 11:29:22 -08:00
Jonah Williams
67362ce5e0
[flutter_tools] fix debug stack traces (#50872) 2020-02-18 11:28:02 -08:00
Jonah Williams
dfcf9beb6b
[versions] update sync http dependency (#50981) 2020-02-18 11:26:17 -08:00
Jonah Williams
9b4cb4da72
[versions] reland update test to 1.12.0 (#50879) 2020-02-18 10:38:54 -08:00
shihchanghsiungsonos
ec9813a500
Fix the issue of Android add2app build fails on Android when assets are read-only (#50047) 2020-02-16 19:15:52 -08:00
Jonah Williams
e481fcae52
Revert "[version] update to package:test 1.12.0 (#50818)" (#50853)
This reverts commit d3387bc916.
2020-02-14 22:34:30 -08:00
Jonah Williams
d3387bc916
[version] update to package:test 1.12.0 (#50818) 2020-02-14 21:51:47 -08:00
Dan Field
1602be6ab6
Live image cache (#50318)
Track images available on screen
2020-02-14 15:03:05 -08:00
Alexandre Ardhuin
85ab331c82
fix unnecessary_string_interpolations lint (#50790) 2020-02-14 10:41:23 +01:00
Alexandre Ardhuin
0bd45bc222
update lint list + enable unnecessary_string_interpolations (#50593) 2020-02-14 09:43:52 +01:00
Yegor
b34046903b
Fix stack trace parsing on non-debug builds; add e2e tests (#50652)
* Fix stack trace parsing on non-debug builds; add e2e tests
2020-02-13 18:34:08 -08:00
Dan Field
766bd70598
Image tracing (#50648) 2020-02-13 14:04:02 -08:00
Yegor
97a5336a34
Clear flaky flag on web benchmarks (#50693) 2020-02-13 07:39:19 -08:00
Dan Field
3d812c1b96
Reduce gradle deps (#50691)
* drop unnecessary test deps

* bump to junit 4.13
2020-02-12 21:14:54 -08:00
Greg Spencer
d57d493507
Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672)
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.

The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.

- Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
2020-02-12 16:22:01 -08:00
Dan Field
58a4122b97
update packages (#50666) 2020-02-12 14:51:38 -08:00
Greg Spencer
c132c0faa9
Revert "Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50660)
This reverts commit 8ef5e2f046 because it breaks some semantics tests.
2020-02-12 13:37:36 -08:00
Casey Hillers
781cd4d87c
Update Devicelab README with new dashboard information (#48908) 2020-02-11 18:25:17 -08:00
Jenn Magder
bfbb347682
Use BUILD_LIBRARY_FOR_DISTRIBUTION build setting for generating add-to-app frameworks (#50536) 2020-02-11 15:53:02 -08:00
Jonah Williams
18f38cd45b
Switch flutter_tools to use frontend_server for web compilation (#50365) 2020-02-11 15:43:46 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00