Commit Graph

278 Commits

Author SHA1 Message Date
Jonah Williams
e2554a9202
Add "flutter downgrade" command (#50506) 2020-02-13 11:56:45 -08:00
Dan Field
24f8f799da
add an --enable-vmservice flag (#50663) 2020-02-12 14:52:09 -08:00
Zachary Anderson
b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots (#50641) 2020-02-12 10:58:02 -08:00
Zachary Anderson
1903ce012e
Revert "[flutter_tools] Disable analytics for more bots (#50579)" (#50622)
This reverts commit 0a38f29c0d.
2020-02-11 22:47:41 -08:00
Zachary Anderson
0a38f29c0d
[flutter_tools] Disable analytics for more bots (#50579) 2020-02-11 15:48:02 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Amir Hardon
bcef4edfc8
Make the template plugin example depend on the plugin as a real dependency (#50485) 2020-02-10 16:03:02 -08:00
Jonah Williams
568172793c
Add "flutter symbolize" command (#49465) 2020-02-10 14:18:03 -08:00
Jenn Magder
082ae838bd
Fall back to global cache and platform if null when injected into constructor (#50370) 2020-02-07 15:28:45 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Levi Lesches
149e06232b
Add option to clear the terminal by pressing "c" (#50034) 2020-02-06 15:53:04 -08:00
Dan Field
4b8efad99b
Font subset in the tool (#49737) 2020-02-04 20:34:24 -08:00
Zachary Anderson
103b12fc11
[flutter_tools] Isolate userHomePath, other cleanups (#50125) 2020-02-04 18:03:03 -08:00
Zachary Anderson
92f7e16312
[flutter_tools] Make OperatingSystemUtils context-free (#49740) 2020-01-29 17:51:31 -08:00
Jenn Magder
e8b3d7f358
Update Xcode compatibility version (#49654) 2020-01-29 15:58:02 -08:00
Jonah Williams
c341d4b78f [flutter_tools] Discover pubspec.yaml in parent directories (#48548) 2020-01-27 21:48:01 -08:00
Dan Field
8b2993337a
revert #48985 (#49572) 2020-01-27 14:36:02 -08:00
Jenn Magder
7feb7dddf1
Inject platform into build ios-framework command (#49463) 2020-01-27 10:32:50 -08:00
Jonah Williams
2f59919496 [flutter_tools] Reland fast start by default for Android (#49315) 2020-01-24 19:18:01 -08:00
Hans Muller
bc5c46438a Migrate TextTheme to 2018 APIs (#48547) 2020-01-24 19:03:01 -08:00
Alexandre Ardhuin
1cc38683cd remove empty string in string interpolations (#49371) 2020-01-24 10:43:02 -08:00
Zachary Anderson
d9f071fd0a [flutter_tool] Don't crash when writing to pub stdin fails (#49323) 2020-01-23 20:13:01 -08:00
Mouad Debbar
a1fa1a3d26 [web] Wire the "--start-paused" flag correctly for web (#49310) 2020-01-22 14:58:46 -08:00
Angjie Li
f0a175f41d Use flutter_tools to start WebDriver browser. (#49228) 2020-01-21 16:48:02 -08:00
Jonah Williams
2ebe9da454
Revert "[flutter_tools] Reland enable fast-start by default for Android (#48851)" (#49227) 2020-01-21 09:51:08 -08:00
Jonah Williams
1ac01b30ca
[flutter_tools] Reland enable fast-start by default for Android (#48851) 2020-01-21 08:59:26 -08:00
Jenn Magder
ac7b307803 Don't pre-cache Android artifacts with --no-android flag (#49009) 2020-01-20 23:23:02 -08:00
Anthony
b67d5ec6e9 [a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985) 2020-01-17 15:13:01 -08:00
Alexandre Ardhuin
003541499b use isA<Xxx>() matcher (#48482) 2020-01-16 12:43:03 -08:00
Jonah Williams
63c65e5cdb
[flutter_tools] Clean up build_aot code post assemble migration (#48771) 2020-01-14 19:07:15 -08:00
Jonah Williams
bc6f270c58
Revert "[flutter_tools] Enable fast start by default for Android (#48746)" (#48836)
This reverts commit d5b0b3c8d1.
2020-01-14 13:23:03 -08:00
Jonah Williams
d5b0b3c8d1
[flutter_tools] Enable fast start by default for Android (#48746) 2020-01-14 12:38:53 -08:00
Dan Field
0a600e1ddc
Fix tool test order (#48735) 2020-01-13 17:11:32 -08:00
Zachary Anderson
23a3d1014f
[flutter_tool] Make BotDetector context free (#48605) 2020-01-13 10:12:06 -08:00
Zachary Anderson
67a68e9fa6
[flutter_tools] Fix analytics opt out event (#48585) 2020-01-10 14:35:19 -08:00
Emmanuel Garcia
ec2d58335a Make subcommands return success instead of null (#48100) 2020-01-10 11:28:01 -08:00
Jonah Williams
749589d896
[flutter_tools] Remove context usage from status and clean up test cases (#48446) 2020-01-10 09:36:49 -08:00
Zachary Anderson
23ce192a8f Reland: Reword flutter run help screen. (#48423) 2020-01-09 08:18:03 -08:00
stuartmorgan
58d6c425e4
Check for desktop project files before building (#48350)
Moves the checks that projects have been configured for desktop to a lower level, where they will cover more codepaths (e.g., 'run'), and improves them to check for native build projects, rather than just directories, to catch cases where the directory exists (e.g., due to accidental creation of generated files).

Also adds links to the error messages pointing to instructions on adding desktop support to a project.

Fixes #47145
2020-01-08 12:39:49 -08:00
Jonah Williams
f7b8d62cbc
[flutter_tool] Refactor Logger and Terminal to (mostly) no longer depend directly on context (#47269) 2020-01-08 12:35:12 -08:00
Zachary Anderson
a1bf03f87a
Revert "Esarbanis flutter run help (#48314)" (#48351)
This reverts commit 866fa64dce.
2020-01-07 15:06:40 -08:00
Jonah Williams
bf6c4c4a41
[flutter_tools]web]Add support for --csp mode to build web (#48319) 2020-01-07 12:20:03 -08:00
Zachary Anderson
866fa64dce
Esarbanis flutter run help (#48314)
* Reword flutter run help screen.

* As per Hixie request, added Efthymios Sarmpanis to the AUTHORS file

* fix test

Co-authored-by: Efthymis Sarmpanis <e.sarbanis@gmail.com>
2020-01-07 12:10:08 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Dan Field
79c4c38cc9 Make analyze once test not depend on test order or flutter create command (#48003) 2020-01-06 16:33:01 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable (#47398) 2020-01-06 11:04:20 -08:00
Angjie Li
9df1790f24 Flutter Web Driver Support (#47890) 2020-01-02 19:48:01 -08:00
Francisco Magdaleno
f2f9d0e4fd
Revert "Flutter Web Driver Support (#47470)" (#47698)
This reverts commit cc1c9649c4.
2019-12-23 15:20:11 -08:00
Jenn Magder
9861a1c045
flutter build ios-framework generate Flutter.podspec (#47556) 2019-12-23 13:12:36 -08:00
Angjie Li
cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Jonah Williams
3fe6668849
[flutter_tool] ensure extraGenSnapshotArguments are forwarded to gen_snapshot from Android builds (#47059) 2019-12-19 13:44:21 -08:00
Lau Ching Jun
2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389)
This reverts commit 1ef0eadb45.
2019-12-18 17:02:31 -08:00
Dan Field
b23238890a Pipe through test-randomize-ordering-seed (#47243) 2019-12-18 13:58:01 -08:00
Angjie Li
1ef0eadb45 Flutter Web Driver Support (#45951)
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
2019-12-18 10:45:39 -08:00
Jenn Magder
1cdf0f44db
Only set flutter run usage values for targeted device platforms (#46931) 2019-12-17 14:09:34 -08:00
Michael Goderbauer
862289fa79 fix imports to unawaited (#47181) 2019-12-17 13:29:26 -08:00
Jonah Williams
0a2d8e0cce
[flutter_tool] Remove direct usage of package:linter in the flutter_tools (#47174) 2019-12-16 18:37:20 -08:00
Danny Tuppeny
4944622b5d
Support URL tunnelling (pass dwds UrlEncoder through to editors via daemon) (#44271)
* Prposal for supporting URL tunnelling

* Update daemon.md

* Add the ability for daemon to call clients to expose URLs

* Fix dwds mock in web_fs tests

* Fix type error

* Remove build_runner import from run

* Move appStartedTime back to after the app has started

* Remove nested DI scope and pass urlTunneller down

* Fix import

* Tweak TODO

* Fix existing tests

* Fix spec to use result instead of params for response object

* Fix exposeUrl to use a url field, as spec'd

* Test that the daemon's exposeUrl sends a request and handles the response
2019-12-12 18:43:58 +00:00
Zachary Anderson
895ffc80dc
[flutter_tool] Handling of certain unrecoverable filesystem errors (#46617) 2019-12-11 12:54:36 -08:00
Jonah Williams
bda9d90804
[flutter_tool] Reland: support --fast-start for Android applications (as an opt-in) (#46140) 2019-12-10 10:26:14 -08:00
Jonah Williams
81aa2710d2
[flutter_tool] add a vmservice API for hot ui requests (#45649) 2019-12-09 21:31:34 -08:00
Ian Hickson
14145a4ec9 Try re-enabling all these tests. (#46615) 2019-12-09 18:58:02 -08:00
Jonah Williams
a491697893
[flutter_tool] Ensure dependency constraint for templates created with a driver test are correct 2019-12-09 17:32:03 -08:00
Christopher Fujino
0268510480 Fix analytics regression (#46242) 2019-12-09 15:13:02 -08:00
Jonah Williams
7f235ea8bc
Mitigation for current tool test skips on CI (#46181) 2019-12-05 23:16:25 -08:00
Zachary Anderson
e98acc7d1d [flutter_tool] Print version info on a no-op upgrade. (#46109) 2019-12-05 12:16:48 -08:00
Jenn Magder
d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138)
This reverts commit 2a113165c0.
2019-12-04 18:12:57 -08:00
Jonah Williams
2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
Zachary Anderson
4484ae4043 [flutter_tool] Do not continue with a no-op 'upgrade' (#46011) 2019-12-03 20:08:24 -08:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Zachary Anderson
e4b809b7c8
[flutter_tool] Crash less when git fails during 'version' (#45628) 2019-11-27 10:18:43 -08:00
Jonah Williams
831163f0d0
Register memory info command on vmservice for Android devices (#45568) 2019-11-26 14:49:56 -08:00
Christopher Fujino
dc68d5700b
Fix flutter run cache (#45267) 2019-11-26 09:02:34 -08:00
Emmanuel Garcia
81724bd60f
Fallback to protocol discovery if mdns returns null (#45439) 2019-11-25 11:51:54 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools (#45153)
* implicit-casts:false on flutter_tools

* use castStringKeyedMap

* address review comments

* address review comments

* fix issues after rebase
2019-11-24 06:54:43 +01:00
Yegor
aa3943316b
Fix dartDefines in daemon mode (#45317)
* de-null dartDefines in daemon mode
* remove daemonCommand; pipe through dartDefines into Daemon
* pass dartDefiles in attach; add test for --machine mode
2019-11-22 08:57:14 -08:00
Emmanuel Garcia
5df4b7db23
Reland: Attach looks at future observatory URIs (#45307) 2019-11-20 18:51:25 -08:00
Emmanuel Garcia
fb5e49082b
Revert "Attach looks at future observatory URIs (#45228)" (#45237)
This reverts commit 2135e9fb1e.
2019-11-19 23:14:25 -08:00
Emmanuel Garcia
2135e9fb1e
Reland: Attach looks at future observatory URIs (#45228) 2019-11-19 21:43:52 -08:00
Emmanuel Garcia
7a0911b47a
Revert "Attach looks at future observatory URIs (#44637)" (#45211)
This reverts commit 6d77996d6a.
2019-11-19 16:47:39 -08:00
Emmanuel Garcia
6d77996d6a
Attach looks at future observatory URIs (#44637) 2019-11-19 15:11:41 -08:00
Jonah Williams
a7367b650b
Don't log stack traces to console on build failures (#44966) 2019-11-18 14:04:11 -08:00
Danny Tuppeny
81f6ba84b9
Switch from using app.progress to app.webLaunchUrl for passing web launch urls (#44268)
* Switch from using app.progress to app.url for passing web launch urls

* Update daemon.md

* Change app.url -> app.webLaunchUrl

* Add tests for app.webLaunchUrl event

* Update tests with recent changes after rebasing
2019-11-18 18:10:15 +00:00
Danny Tuppeny
5376e90fda
Print a message when modifying settings that you may need to reload IDE/editor (#44574)
* Print a message when modifying settings that you may need to reload IDEs/editors

* Add a test for `flutter config` output

* Remove blank line
2019-11-14 17:54:22 +00:00
Jenn Magder
25b33a8c3b
Fake locale in doctor_test (#44878) 2019-11-13 19:08:10 -08:00
Jenn Magder
6498f64399
Catch and display version check errors during doctor (#44868) 2019-11-13 18:23:05 -08:00
Jonah Williams
985da83139
Revert "Allow specifying device-vmservice-port and host-vmservice-port (#44027)" (#44843)
This reverts commit c0af77bf87.
2019-11-13 14:35:07 -08:00
Jonah Williams
c0af77bf87
Allow specifying device-vmservice-port and host-vmservice-port (#44027) 2019-11-13 13:01:41 -08:00
Jonah Williams
7caef218b5
refactorings to testbed.run and testbed.test (#44488) 2019-11-12 15:35:59 -08:00
Yegor
e7073f9a1f
add --dart-defines option (#44083) 2019-11-09 17:08:53 -08:00
Jonah Williams
9fa0f3b2ea
fix test for null flutter root (#44468) 2019-11-08 14:38:44 -08:00
Jonah Williams
978fada33c
Refactor flutter.gradle to use assemble directly (#43876)
Removes multiple re-entrant calls of bundle and aot and replaces them with a single call to assemble. This restores full caching and will allow follow-up performance improvements when building multiple ABIs
2019-11-08 12:41:24 -08:00
Jonah Williams
cc51ad5d08
Reland: enable usage of experimental web compiler (#44400) 2019-11-07 20:13:02 -08:00
chunhtai
6a9b72c16b
fixing todo comments in flutter tests to include url link. (#42691) 2019-11-07 17:34:36 -08:00
Jonah Williams
7535ef735f
Revert "Enable usage of experimental incremental compiler for web (#43576)" (#44396)
This reverts commit e5d6d92498.
2019-11-07 16:32:20 -08:00
Jonah Williams
e5d6d92498
Enable usage of experimental incremental compiler for web (#43576) 2019-11-07 16:29:51 -08:00
xster
ba26f926c7
Add Android embedding version analytics (#44043) 2019-11-05 12:38:42 -08:00
Zachary Anderson
372fe290e4
[flutter_tool] Update analytics policy, send event on disable (#43217) 2019-11-05 10:43:52 -08:00
Jonah Williams
79bc6cafc5
implement build aot with assemble for Android target platforms (#43282) 2019-10-30 15:23:25 -07:00
Zachary Anderson
d0d8e6edcb
[flutter_tool] Teach the tool about local engine Fuchsia artifacts (#43759) 2019-10-30 14:11:18 -07:00
liyuqian
c523149819
Reland "Enable dump-skp-on-shader-compilation in drive (#43022)" (#43455)
This reverts commit b9eb3f717a.

We fixed the issue by updating the constructors.
2019-10-29 14:20:22 -07:00
Jonah Williams
450a72488d
set trace to true for desktop builds (#43577) 2019-10-28 10:27:11 -07:00
Zachary Anderson
0dfabb2ae1
[flutter_tool] Use engine flutter_runner prebuilts (#43381)
* [flutter_tool] Use engine flutter_runner prebuilts

* Update packages/flutter_tools/lib/src/fuchsia/fuchsia_build.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
2019-10-28 09:38:08 -07:00
Jonah Williams
4bd5eb5915
Enable track widget creation on by default (#43471) 2019-10-25 15:04:06 -07:00
Jonah Williams
ae207b5e42
Handle permission error during flutter clean (#43401) 2019-10-25 15:02:38 -07:00
Jonah Williams
b9eb3f717a
Revert "Enable dump-skp-on-shader-compilation in drive (#43022)" (#43438)
This reverts commit 4f385c8fb7.
2019-10-24 11:18:55 -07:00
liyuqian
4f385c8fb7 Enable dump-skp-on-shader-compilation in drive (#43022) 2019-10-24 11:04:59 -07:00
Jonah Williams
4c677e4148
Extra defensive programming for pub modification time assert (#43315) 2019-10-22 22:05:00 -07:00
Jonah Williams
46ea99122b
Revert "Extra defensive programming for pub modification time assert (#42491)" (#43235)
This reverts commit 3597bae6a0.
2019-10-21 20:54:02 -07:00
Ian Hickson
3597bae6a0 Extra defensive programming for pub modification time assert (#42491) 2019-10-21 20:15:20 -07:00
Ian Hickson
124dc6617f
Clean up test infrastructure (#43030)
See #41880 for history.
2019-10-18 16:35:39 -07:00
Jonah Williams
e67f9a3f6c
ensure we can disable --track-widget-creation in debug mode (#43016) 2019-10-18 12:40:50 -07:00
Jonah Williams
1982a5c3ec
Revert "Clean up test infrastructure (#41880)" (#42982)
This reverts commit 1781d5c9bb.
2019-10-17 19:47:16 -07:00
Ian Hickson
1781d5c9bb
Clean up test infrastructure (#41880) 2019-10-17 19:22:47 -07:00
Jonah Williams
863fb2f2cc
Remove linux-x64 unpack logic (#42962) 2019-10-17 19:22:03 -07:00
Christopher Fujino
428d7d7f2d
dispose devices on cleanupAtFinish() for run_cold.dart (#42668) 2019-10-15 12:50:44 -07:00
chunhtai
9423a01204
fix flutter error report correct local widget (#41224) 2019-10-13 18:41:22 -07:00
Ian Hickson
08643c41d7
Always fake ProcessManager when you fake Filesystem in tests (#42369)
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Jonah Williams
7ab653c6ca
Add error logging to flutter generate (#42209) 2019-10-11 07:16:11 -07:00
Jonah Williams
861fe0a276
Ensure precache --web works on dev branch (#42289) 2019-10-09 16:27:39 -07:00
Jonah Williams
14c1c211d5
Catch argument error from Make when it isn't installed (#42252) 2019-10-08 14:53:55 -07:00
Jonah Williams
fde267516b
Make Pub an interface in the flutter tool (#42257) 2019-10-08 14:53:28 -07:00
Jonah Williams
9638756c2a
Apply mocks to test command to deflake web_fs test (#42118) 2019-10-07 15:20:33 -07:00
Zachary Anderson
cf0d4979c7
[flutter_tool] Re-work analytics events to use labels and values (#42016) 2019-10-07 15:04:55 -07:00
Alexandre Ardhuin
890b939401
indent formal parameters correctly (#41644) 2019-10-04 11:00:18 +02:00
Jonah Williams
ae18f07324
Ensure plugin registrants are generated in build_web (#41906) 2019-10-04 00:36:09 -07:00
Zachary Anderson
c7c8a6c498
[flutter_tools] Add more info to pub get failure event (#41652) 2019-10-03 11:08:42 -07:00
Ian Hickson
8c6d60bcfd
Move commands into their own shard (#39140) 2019-10-02 12:46:51 -07:00