github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
fea4a91ab6
Commit Graph

1169 Commits

Author SHA1 Message Date
Ryan Macnak
d33da2fadd Also forward VM prints. (#4909) 2016-07-13 09:17:24 -07:00
Collin Jackson
f82b62096d Simplify iOS template project 2016-07-12 18:34:01 -07:00
Collin Jackson
6073a7e991 Fall back to the default xcodeproj if a workspace cannot be found (e.g. for example apps) 2016-07-12 17:34:08 -07:00
Collin Jackson
f83ea1ae6c Merge pull request #4895 from collinjackson/xcworkspace 
Remove dependency on FlutterAppDelegate so devs can more easily add SDKs.
 2016-07-12 14:24:16 -07:00
Collin Jackson
fdc2a2ba77 When using flutter run, build the workspace instead of the project 2016-07-12 14:04:02 -07:00
Collin Jackson
0d1752241f Remove dependency on FlutterAppDelegate so devs can more easily add SDKs. 2016-07-12 13:56:07 -07:00
Adam Barth
a33fc49659 Remove dangling reference to ViewController (#4841) 
We want to use the FlutterViewController in this new project template.

Fixes #4840
 2016-07-07 10:45:58 -07:00
Phil Quitslund
ea24d14c0c Merge pull request #4823 from pq/dart_1.18.0-dev.4.0 
Bump Dart SDK to `1.18.0-dev.4.0`.
 2016-07-06 14:54:52 -07:00
pq
cb4f01ae3d Bump Dart SDK to 1.18.0-dev.4.0. 
Last dev push for `1.18`.
 2016-07-06 14:43:40 -07:00
Adam Barth
151750baa8 Update the ios projects for examples to HelloServices model (#4822) 
We now use a different approach for ios projects where the developer controls
the Xcode project file. This patch removes the old ".generated" approach in
favor of the new approach.
 2016-07-06 14:13:21 -07:00
Adam Barth
8d56fae557 Finish integrating HelloServices model on iOS (#4820) 
This patch changes the default `flutter create` command to generate a
HelloServices-style app on iOS. As a consequence, the Atom integration now
fully works with HelloServices.
 2016-07-06 13:13:28 -07:00
Devon Carew
ec752d813d send ext.flutter.debugDumpApp; ext.flutter.reassemble (#4810) 
* send ext.flutter.debugDumpApp; ext.flutter.reassemble

* expose debugDumpRenderTree
 2016-07-04 11:21:56 -07:00
Devon Carew
f0671edfdb workaround adb logcat -T (#4798) 2016-07-01 10:19:28 -07:00
Adam Barth
639532bd51 Don't pick up Android SDK from local engine (#4801) 
It can cause trouble if the user has a newer Android SDK installed normally.
Instead, just use the normal Android SDK.
 2016-06-30 15:47:56 -07:00
Todd Volkert
f410ca80b7 Include target in revision string, since it affects the xcode config (#4795) 2016-06-30 11:33:36 -07:00
pq
a417786d77 Update to latest analyzer (w/ cleanup). 
Bye-bye `@protected `trampolines! :)
 2016-06-30 10:39:45 -07:00
Phil Quitslund
05bcbb6cd0 Merge pull request #4785 from pq/empty_statement_cleanup 
Cleanup empty statements.
 2016-06-28 14:02:05 -07:00
pq
543f705adb Cleanup empty statements. 
The new `empty_statements` lint (in the next DEV roll), flags these empty statements.  Harmless, except the one in `basic.dart` that fixes a real-life bug. :)
 2016-06-28 13:42:22 -07:00
Todd Volkert
fbab25be59 Remove errant xcuserdata file from project templates (#4784) 2016-06-28 13:39:07 -07:00
Adam Barth
41d6303570 Improve test coverage for material.dart (#4776) 
Previously these widget had zero test coverage. Also, improve the
coverage tooling Mac.
 2016-06-28 08:48:48 -07:00
Devon Carew
6cdfd86ad1 send the reload source command for ios simulators (#4731) 
* send the reload source command for ios simulators

* review changes

* rewrite w/ a completer
 2016-06-24 10:26:43 -07:00
Devon Carew
aa364a082d don't rewrite the console in non-ansi mode (#4735) 2016-06-24 09:56:04 -07:00
Adam Barth
46da9e8498 Add a simple way of merging coverage data (#4726) 
`flutter test` now has a `--merge-coverage` flag that can be used to merge
coverage data from previous runs, enabling faster iteration cycles.
 2016-06-23 18:02:55 -07:00
Adam Barth
10931af0d3 Simplify coverage workflow (#4725) 
We now download the base coverage file automatically.
 2016-06-23 16:31:25 -07:00
Adam Barth
f20546a1d7 Remove drudge spam (#4724) 
Stop spamming the console about drudge by pinning an earlier version of
json_scheme that doesn't spam.
 2016-06-23 15:37:51 -07:00
Adam Barth
7b99ecff35 Use relative paths in lcov.info (#4722) 
Using relative paths makes it easier to share lcov.info files across machines.
 2016-06-23 15:29:54 -07:00
Phil Quitslund
55b51ee549 Merge pull request #4697 from pq/analyzer_0.27.4-alpha.14 
Update to latest analyzer (0.27.4-alpha.14) and misc. analysis fixes.
 2016-06-23 10:03:49 -07:00
pq
1cad4f4705 Fallback to a standard SDK if no embedders are found. 2016-06-22 19:30:46 -07:00
Todd Volkert
e91f3eef46 Don't uninstall before installing in flutter run (#4699) 
#4672
 2016-06-22 15:43:57 -07:00
Adam Barth
ed2c24ba2b Add coveralls support to Travis (#4690) 
This patch causes us to upload a coverage report to coveralls.io.
 2016-06-22 14:47:41 -07:00
pq
352e2f573b Update to latest analyzer (0.27.4-alpha.14) and misc. analysis fixes. 
* brings in analyzer version (`0.27.4-alpha.14`) corresponding to current Dart SDK (`1.18.0-dev.2.0`).
* updates analysis to use prefered API for embedder URI resolution
* adds trampolines to `State` and `StatelessWidget` to allow for warning-free within-library @protected access (needed since we closed off access to @protected closures from outside subclasses).
* turns off cache dependency tracking for analysis (in DDC this amounted to a 10% speed improvement).
 2016-06-22 14:34:30 -07:00
Adam Barth
b094fa6dd3 Add support for --coverage to flutter test (#4679) 
We need https://github.com/dart-lang/coverage/issues/100 to be fixed before
this will be useful.

Fixes #2342
 2016-06-22 12:22:01 -07:00
Jason Simmons
f307735edc Remove the assembleFlx accessor and FLX asset path overrides (#4671) 
This is now obsolete
 2016-06-21 15:29:34 -07:00
Jason Simmons
c823acc345 Pass a package map to gen_snapshot instead of a packages symlink directory (#4666) 2016-06-21 13:47:24 -07:00
Ian Hickson
e502e9c8f8 ImageIcon (#4649) 
Anywhere that accepted IconData now accepts either an Icon or an
ImageIcon.

Places that used to take an IconData in an `icon` argument, notably
IconButton and DrawerItem, now take a Widget in that slot. You can wrap
the value that used to be passed in in an Icon constructor to get the
same result.

Icon itself now takes the icon as a positional argument, for brevity.

ThemeData now has an iconTheme as well as a primaryIconTheme, the same
way it has had a textTheme and primaryTextTheme for a while.

IconTheme.of() always returns a value now (though that value itself may
have nulls in it). It defaults to the ThemeData.iconTheme.

IconThemeData.fallback() is a new method that returns an icon theme data
structure with all fields filled in.

IconTheme.merge() is a new constructor that takes a context and creates
a widget that mixes in the new values with the inherited values.

Most places that introduced an IconTheme widget now use IconTheme.merge.

IconThemeData.merge and IconThemeData.copyWith act in a way analogous to
the similarly-named members of TextStyle.

ImageIcon is introduced. It acts like Icon but takes an ImageProvider
instead of an IconData.

Also: Fix the analyzer to actually check the stocks app.
 2016-06-20 21:04:45 -07:00
Devon Carew
415324f2f0 bump our dep on the test package (#4625) 
* bump out dep on the test package

* add other pubspecs
 2016-06-19 08:10:03 -07:00
Adam Barth
ba4f1e02c2 Add an example of listening to app lifecycle events (#4623) 
Fixes #4553
 2016-06-18 10:43:38 -07:00
Jason Simmons
d89823be2a Remove packages/flx and the FLX code signing scheme (#4612) 2016-06-17 12:35:30 -07:00
Phil Quitslund
9fe7617184 Merge pull request #4588 from pq/1.18.0-dev.1.0_prep 
Dead code, switch cleanup and `crypto` bump.
 2016-06-16 10:01:34 -07:00
pq
3e9067a4ec Dead code and switch cleanup (continued). 
Prep to get us ready to pull in a new dev SDK and bump our analyzer DEP.

* updates `crypto` (required by fresh analyzer)
* fixes newly flagged dead code warnings
* fixes switches that fall through and don't return
 2016-06-16 09:45:37 -07:00
Adam Barth
2ce57eb3ce Fix paths again (#4589) 
I got confused about the sdk_ext directory.
 2016-06-16 09:37:10 -07:00
Adam Barth
fc77bfe630 Attempt to fix AOT build (#4587) 
I moved dart_ui.dart to an new path and forgot to update this reference.
 2016-06-16 09:05:04 -07:00
Devon Carew
661740d2d6 updates from previous review (#4577) 2016-06-15 11:25:31 -07:00
Devon Carew
fc47909e9f send application files to the observatory's devfs (#4572) 
* send application files to the observatory's devfs

* update comment
 2016-06-15 09:29:23 -07:00
Ian Hickson
0d21e69b1d Fix flutter upgrade and flutter build ios (#4564) 
* Fix `flutter upgrade`

* Fix builds on iOS
 2016-06-14 18:16:55 -07:00
Phil Quitslund
0f1132f93a Merge pull request #4559 from pq/missing_returns 
Add missing returns.
 2016-06-14 15:41:49 -07:00
pq
f5a4e63237 Added asserts. 2016-06-14 15:19:14 -07:00
Ian Hickson
294376fb01 fix reentrant locking in pub upgrade (#4556) 2016-06-14 12:39:20 -07:00
pq
7a95548746 Add missing returns. 
As of `1.18.0-dev-0`, these cases will get flagged.  In the meantime, the
 2016-06-14 12:13:56 -07:00
Chinmay Garde
9782d97faa Enable launching applications on the iOS device with observatory and diagnostics server connected. (#4424) 2016-06-14 11:47:51 -07:00
Ian Hickson
f92f71feb9 Lock flutter tool while updating artifacts (#4476) 
This prevents multiple simultaneous runs of the analyzer from stomping
over each other (e.g. multiple runs of 'update-packages'). Certain
long-lived commands (like analyze, run, logs) are exempted once they've
done enough work to be safe from most stomping action.

This still doesn't make us entirely safe from craziness, e.g. if you're
half way through an 'update-packages' run and you call 'git pull', who
knows what state you'll end up in. But there's only so much one can do.

Fixes https://github.com/flutter/flutter/issues/2762
 2016-06-14 10:16:08 -07:00
Ian Hickson
2b2d782503 "--watch --flutter-repo" wasn't analyzing flutter (#4548) 2016-06-13 19:19:35 -07:00
Ian Hickson
2cdda9e679 Provide a way to save the analyzer results to disk (#4541) 2016-06-13 13:29:10 -07:00
Devon Carew
b6c3ae37f6 send supportsRestart flag when starting an app (#4513) 
* send supportsRestart flag when starting an app

* remove unused imports

* review comments
 2016-06-13 13:16:20 -07:00
Todd Volkert
2099d3789c Pull iOS build templates from flutter tools vs engine artifacts (#4526) 2016-06-13 12:30:08 -07:00
Ian Hickson
c9bcf1074e Analyzer was confused when you deleted files (#4528) 
Also, make it clear the screen between results so it's more obvious
what's going on when you have new results (especially when you have
fixed everything).
 2016-06-13 12:20:03 -07:00
Todd Volkert
d2ee6f7838 Rename app.so -> app.dylib (#4522) 2016-06-10 16:57:21 -07:00
Devon Carew
1ff3a2a039 show progress while running the analysis server (#4525) 2016-06-10 16:39:43 -07:00
Jason Simmons
484c36f145 Set the android:debuggable flag when building an APK in debug mode (#4523) 
See https://github.com/flutter/flutter/issues/4438
 2016-06-10 16:06:12 -07:00
Devon Carew
b2938f40e3 expose the devfs api (#4521) 2016-06-10 15:08:12 -07:00
Devon Carew
b5c8f2a43f print stack traces from the analysis server (#4507) 2016-06-10 06:48:16 -07:00
Kaiyuan Wang
8446ae3c87 Fix flutter drive crash issue when run in develop mode (#4492) 2016-06-09 12:39:14 -07:00
Adam Barth
c02c553867 Fix types for flutter test in checked mode (#4488) 
Fixes #4059
 2016-06-09 07:27:23 -07:00
Devon Carew
fcd68c8a21 Support route (#4470) 
* support --route in flutter run --resident

* also for the daemon app.start command
 2016-06-08 13:44:54 -07:00
Devon Carew
d3e5e48701 revmoe the debug:true param from the atom launch config (#4464) 2016-06-08 12:21:45 -07:00
Jason Simmons
0db04819dc More flexibility for defining the locations of assets packaged in an FLX (#4462) 
* Add a map of relative to absolute paths for assets located outside the app's
  source directory
* If a "packages" directory exists, obtain assets from there instead of
  using the packages/ prefix to indicate package map lookup
 2016-06-08 11:32:30 -07:00
Devon Carew
5c59862208 Update usage.dart (#4451) 
Update the analytics code.
 2016-06-08 09:38:12 -07:00
Adam Barth
440aa5ee2f Add -t support to flutter run on iOS (#4439) 2016-06-07 16:41:53 -07:00
Devon Carew
3ba17136b7 add a restart command to the daemon protocol (#4385) 
* refactor the --resident run option into a separate file

* update daemon to run --resident apps

* re-plumbing daemon start

* send app logs

* update tests

* review changes

* fix test runner

* remove PackageMap.createGlobalInstance; rely on the ctor

* review comments
 2016-06-07 12:13:35 -07:00
Chinmay Garde
68ba5bfd7c Suppress verbose output from ios-deploy when not in verbose mode. (#4423) 2016-06-07 12:02:08 -07:00
Devon Carew
958fb0f888 Update flutter_command_runner.dart (#4398) 2016-06-06 15:35:31 -07:00
Adam Barth
8f03ebe56b Teach FlutterPlugin.groovy about AOT builds (#4389) 
The `flutter.buildMode` property now controls whether to build in debug,
profiling, or release.
 2016-06-06 12:56:04 -07:00
Devon Carew
6c96e1a320 use the --resident option on flutter run by default (#4386) 2016-06-06 10:29:27 -07:00
Phil Quitslund
6d2d495369 Merge pull request #4348 from pq/fix_4091 
Fix flutter analyze defaults when files are specified (#4091).
 2016-06-06 10:00:55 -07:00
Adam Barth
29af5c0317 Set a sensible default framework path (#4370) 
This patch sets a default path for Flutter.framework that's sensible based on
the FLUTTER_MODE.
 2016-06-03 17:01:18 -07:00
Chinmay Garde
8756a094a9 Add a FLUTTER_MODE variable to the generated Xcconfig and fix snapshot generation on all targets. (#4362) 
Get rid of the DART_EXPERIMENTAL_INTERPRETER_FLAG.
 2016-06-03 13:55:57 -07:00
Devon Carew
26076d9efd Update utils.dart (#4364) 2016-06-03 13:21:16 -07:00
Devon Carew
7ae584bc02 handle 'last message repeated' from ios simulator (#4300) 2016-06-03 12:54:27 -07:00
pq
ce82bc1b15 Check for user specified args. 2016-06-03 12:52:43 -07:00
Adam Barth
8171aa86f0 Document how to build hello_services for iOS (#4354) 
This patch adds some sensible defaults to xcode_backend.sh and documents how to
build hello_services for iOS using Xcode.
 2016-06-03 12:20:54 -07:00
pq
305af8b873 Fix flutter analyze defaults when files are specified (#4091). 
Disables current package and current directory analysis when files are specified.

Fixes: https://github.com/flutter/flutter/issues/4091.
 2016-06-03 09:24:54 -07:00
Jason Simmons
d8d0d6b31b Resolve package references in font asset paths (#4334) 2016-06-02 15:05:41 -07:00
Eric Seidel
4c86b73027 wip 2016-06-02 14:17:21 -07:00
Jason Simmons
00c7734c8b Tools daemon handlers for discovering apps and forwarding device ports (#4324) 2016-06-02 14:00:27 -07:00
Adam Barth
612a097d1f Add --target support to flutter build ios (#4318) 
Fixes #4298
 2016-06-02 08:57:13 -07:00
Devon Carew
bc5d407477 fix an issue where the refresh benchmark would overwrite a completer (#4315) 2016-06-01 19:57:08 -07:00
Devon Carew
9e9dfc3d2d fix a race condition with isolate notification (#4286) 
* fix a race condition with isolate notification

* return a future
 2016-06-01 15:17:04 -07:00
Devon Carew
2a2bd7b6f4 fix an exception while parsing a services file (#4302) 2016-06-01 14:06:44 -07:00
Adam Barth
c26fcfdfaa Update xcodebuild for Generated.xcconfig (#4268) 
This patch updates how we generate xcconfig files to match what
xcode_backend.sh expects.
 2016-06-01 12:32:45 -07:00
Phil Quitslund
77b8e3273d Merge pull request #4271 from pq/0.27.4-alpha.9 
Update analyzer dep to 0.27.4-alpha.9
 2016-05-31 11:31:16 -07:00
Jason Simmons
49c4064132 Add Dart IO entry points to the snapshotter command line (#4257) 2016-05-31 10:51:28 -07:00
pq
985a7b91cf Update analyzer dep to 0.27.4-alpha.9 
Update analyzer dep to 0.27.4-alpha.9 to enjoy analyzer perf improvements (https://codereview.chromium.org/2011183004/) (and keep in sync with the SDK).

(This is a revisit to https://github.com/flutter/flutter/pull/4253.)
 2016-05-31 06:59:56 -07:00
Adam Barth
7de84709cf Address review comments on prior patch (#4270) 
I pulled the trigger to land the previous patch too quickly and missed a
number of comments.
 2016-05-30 14:47:49 -07:00
Devon Carew
7c47837c27 show build progress; print app sizes (#4263) 
* show build progress; print app sizes

* add todo

* review comments

* remove unused import
 2016-05-29 15:07:41 -07:00
Devon Carew
49affc4098 make the drive output prettier (#4260) 2016-05-27 22:36:07 -07:00
Devon Carew
111392d7c9 run pub get (w/ symlinks) for flutter drive (#4259) 
* run pub get (w/ symlinks) for flutter drive

* review comments
 2016-05-27 21:42:46 -07:00
Adam Barth
aee32698ac Add backend tools for extensible iOS apps (#4250) 
Instead of embedding Flutter.framework and BuildFlutterApp in the Xcode
project, we store these in flutter.git, where we can reference them.
 2016-05-27 15:30:42 -07:00
Devon Carew
c98ce02417 print the dartlang atom plugin version from flutter doctor (#4242) 2016-05-27 13:31:55 -07:00
Chinmay Garde
989a530350 Don't avoid linking with libSystem to work around issue in dyld. (#4241) 2016-05-27 11:24:10 -07:00
Todd Volkert
51d4ab3324 Fix install for iOS simulator, and add ability to uninstall (#4223) 2016-05-27 11:05:10 -07:00
Yegor
f544abd016 modernize flutter drive w.r.t. debug/profile/release options (#4217) 
* modernize `flutter drive` w.r.t. debug/profil/release options

* make error message prettier
 2016-05-27 10:02:36 -07:00
Devon Carew
ec7517766c Flutter run restart (#4105) 
* working on making a faster flutter run restart

* clean up todos; fire events on isolate changes

* use the Flutter.FrameworkInitialization event

* review comments
 2016-05-26 15:26:14 -07:00
Devon Carew
646b5350d1 resolve symlinks in paths to flutter (#4219) 
* resolve symlinks in paths to flutter

* review comments
 2016-05-26 14:41:33 -07:00
Devon Carew
d6aed1e7c9 add a --quiet option to flutter_tools (#4213) 2016-05-26 13:41:29 -07:00
Todd Volkert
239a717dcc Revert "Pass the local engine config through Xcode (#4190)" 
This reverts commit 8f69cccc18.
 2016-05-26 11:03:08 -07:00
Adam Barth
fde55a6f6a Update vector_math (#4201) 
The new version has an API change. Also, up our SDK requirements to be a
bit more realistic.
 2016-05-26 09:49:09 -07:00
Devon Carew
9cfa96608c dissallow -release mode on emulators (#4204) 
* dissallow -release mode on emulators

* have the help text print the default mode
 2016-05-26 09:14:51 -07:00
Todd Volkert
92ee807a3c Plumb --local-engine flag through to LOCAL_ENGINE in Local.xcconfig 
Fixes #4186
 2016-05-25 18:37:36 -07:00
Adam Barth
c69cff9428 Update test package (#4198) 2016-05-25 17:45:23 -07:00
Jason Simmons
5aa9a7fc53 Forward the observatory (but not the diagnostic server) when in profile mode (#4183) 2016-05-25 15:21:11 -07:00
Adam Barth
8f69cccc18 Pass the local engine config through Xcode (#4190) 
This passes the information through Xcode to the `flutter build aot` call via
the environment so that it picks up the right artifacts.

Fixes #4186
 2016-05-25 14:33:22 -07:00
Todd Volkert
0da58802cf Fix aot compiler and linker args 2016-05-25 14:32:57 -07:00
Adam Barth
b1b6271683 Use "call" instead of "invoke" (#4177) 
For consistency.

Fixes #4142
 2016-05-24 17:53:04 -07:00
Adam Barth
e8e9d4633c Workaround https://github.com/dart-lang/sdk/issues/26362 (#4171) 
When building AOT, we now run `pub get` instead of printing an error telling
the user to run `pub get`. We can remove this code once the bug reference above
is fixed (should be a couple days).
 2016-05-24 16:29:13 -07:00
Todd Volkert
cc8c78adf4 iOS tools cleanup (#4161) 
* iOS tools cleanup

1) Fix `flutter install` on both device and simulator to refer to the actual
   bundle and not just the .generated folder
2) Fix `flutter run` on device to actually run vs just installing

Still TODO:
1) Discovered that isAppInstalled on iOS simulator always reports true,
   meaning it'll never actually try to install the app.

Fixes #3947
Fixes #1823
 2016-05-24 16:25:40 -07:00
Adam Barth
2d726fc0c5 Build app.so instead of app.a on iOS (#4168) 
The app.a wasn't getting pulled into the main executable because we weren't
referencing any of its symbols. Instead, create a dylib that can be packaged
with the application and loaded at runtime.
 2016-05-24 15:49:53 -07:00
Adam Barth
e8a47b6d49 Add --interpreter to flutter build aot (#4159) 
This patch teaches flutter build aot to build `app.a` for use with the Dart
interpreter.
 2016-05-24 12:06:53 -07:00
Adam Barth
cb7a690815 Let flutter build aot select a target platform (#4154) 
Currently only android-arm and ios are supported target platforms.
 2016-05-24 11:21:07 -07:00
Adam Barth
f33596aacb Teach flutter to build app.a (#4141) 
On iOS, we use Xcode to build a static library that contains the precompiled
code. This code is currently unused, but it will be used by the new Xcode
harness to factor out as much complexity as possible into the flutter tool.
 2016-05-24 09:49:31 -07:00
Devon Carew
4764550f9f fail flutter analyze when there are errors (#4117) 2016-05-23 14:39:42 -07:00
Chinmay Garde
66fee3a622 Wire up ios-profile and ios-release. Switching between debug, profile and release starts the build process from scratch. (#4063) 2016-05-23 12:58:42 -07:00
Devon Carew
1ae0a76cf9 warn when flutter doesn't match the pubspec version (#4109) 2016-05-23 12:23:05 -07:00
Devon Carew
4962656b1d remove old command aliases (#4103) 2016-05-23 12:06:49 -07:00
Devon Carew
17b9c12b80 adjust adb logcat filter (#4104) 2016-05-23 12:04:07 -07:00
Ian Hickson
10c861d6e9 Track number of pending dartdocs too (#4088) 2016-05-20 16:47:44 -07:00
Ian Hickson
94636bd206 Cleanup based on new lints (#4052) 2016-05-20 14:08:46 -07:00
Todd Volkert
3042da9f6d Prefer getAdbPath(androidSdk) over androidSdk.adbPath (#4076) 
For developers with the platform tools installed but no SDK, it prevents
crashing in the flutter tool in favor of more user-friendly error messages
downstream.
 2016-05-20 10:45:35 -07:00
Devon Carew
3b3b0ff1bb make sdb getprop less verbose (#4053) 2016-05-19 14:10:09 -07:00
Devon Carew
95f838b072 Update trace.dart (#4055) 2016-05-19 14:06:40 -07:00
Phil Quitslund
3693a7c303 Merge pull request #4054 from pq/overriden_field 
Fix analyzer field overrides.
 2016-05-19 13:43:27 -07:00
pq
2a9d2b5f30 Fix analyzer field overrides. 
Cleans up 3 of the 4 violations of the `overriden_field` lint.

The last one is more interesting and I'll defer to someone closer to that code:

    [lint] Do not override fields. (packages/flutter/test/rendering/rendering_tester.dart, line 91, col 14)
 2016-05-19 13:12:04 -07:00
Eric Seidel
880f2f785e flutter test now works on mac as well as linux 
@chinmaygarde
 2016-05-19 13:10:15 -07:00
Devon Carew
a48b063a10 rebuild when the build type changes (#4032) 
* rebuild when the build type changes

* handle local engine builds

* also check the timestamp
 2016-05-19 12:49:40 -07:00
Phil Quitslund
8109bde6e3 Merge pull request #4036 from pq/comment_refs 
Cleanup dangling comment references.
 2016-05-19 11:19:55 -07:00
Devon Carew
0b5072c2ef fix check to ignore bots (#4034) 2016-05-19 10:51:31 -07:00
pq
1a6f499bc1 Cleanup dangling comment references. 
Quick pass at fixing a few dangling references as revealed by the new `comment_references` lint (https://github.com/dart-lang/linter/issues/240).

There's a bunch more to do here before we can turn it on by default (~430 lints as of now).  Many of them are a simple matter of adding an import (e.g., `dart:async` for library docs that reference `Future`) but others will require a bit of thought.  Probably best done by the folks writing the code. :)
 2016-05-19 10:21:38 -07:00
Chinmay Garde
376cb2eb38 Attach standard streams of the child sky_shell process so that logs from the shell show up. (#4024) 2016-05-18 16:58:46 -07:00
pq
addc888926 Update to new analyzer and linter. 
Notably, this will allow us to play with

* the fixed `public_member_api_docs` that now checks for documented getters when checking setters (https://github.com/dart-lang/linter/issues/237), and
* the new `comment_references` lint that ensures identifiers referenced in docs are in scope (https://github.com/dart-lang/linter/issues/240).
 2016-05-18 11:47:44 -07:00
pq
7163cf115d Revert "Update to new analyzer and linter." 
This reverts commit f91cf1c450.
 2016-05-18 11:45:25 -07:00
pq
f91cf1c450 Update to new analyzer and linter. 
Notably, this will allow us to play with

* the fixed `public_member_api_docs` that now checks for documented getters when checking setters (https://github.com/dart-lang/linter/issues/237), and
* the new `comment_references` lint that ensures identifiers referenced in docs are in scope (https://github.com/dart-lang/linter/issues/240).
 2016-05-18 11:44:43 -07:00
Jason Simmons
fc61060421 Log an error if the Android intent fails during flutter refresh (#3988) 2016-05-17 14:35:11 -07:00
Ian Hickson
f284c1a049 Fix tests (#3977) 
Also, make sure that broken tests actually break the bots.

And add a test to make sure that keeps happening.
 2016-05-17 12:45:37 -07:00
Jason Simmons
c192a7e4ca Replace the checked flag in DebuggingOptions with the build mode (#3901) 
This also fixes some related problems affecting "flutter run":
  * FLXes built during AndroidDevice.startApp need to match the build mode
  * APKs should always be rebuilt if the build mode uses AOT compilation
 2016-05-17 12:38:25 -07:00
pq
97ba6a1e0b Re-enable implementation_imports lint rule. 2016-05-17 11:02:10 -07:00
Phil Quitslund
a6b8980d3e Merge pull request #3954 from pq/summaries_off 
Back out SDK summaries.
 2016-05-17 09:03:15 -07:00
Phil Quitslund
04cdf71add Merge pull request #3955 from pq/type_annotate_public_apis_off 
Remove redundant type annotation lint.
 2016-05-17 09:02:27 -07:00
Collin Jackson
b4313b04b0 Merge pull request #3946 from collinjackson/apk 
Make flutter run generate identical apks to flutter build apk
 2016-05-17 07:30:10 -07:00
Collin Jackson
a312db482d remove the add-files argument to flutter run 2016-05-16 18:33:59 -07:00
Chinmay Garde
0e8f26dd6c Use the correct host toolchain when building from a local engine checkout on Mac. (#3956) 2016-05-16 17:05:39 -07:00
pq
464ccdfcac Remove redundant type annotation lint. 
SInce this is a subset of `always_specify_types` I think we can safely remove it.

In practice, if you violate you get doubly nagged:
```
[lint] Type annotate public APIs. (packages/flutter_tools/lib/src/dart/runner.dart, line 5, col 1)
[lint] Declare method return types. (packages/flutter_tools/lib/src/dart/runner.dart, line 5, col 1)
```

One warning is probably enough to get the message across? ;)
 2016-05-16 16:02:18 -07:00
pq
fddab5d800 Back out SDK summaries. 
Net-net: SDK summaries are not safe in the presence of SDK library embedders.

Context (and bug to track re-enablement) here: https://github.com/dart-lang/sdk/issues/26467.
 2016-05-16 15:57:45 -07:00
Collin Jackson
00e22284f2 Fix #3891 by making flutter run generate identical apks to flutter build apk 2016-05-16 15:53:18 -07:00
Ian Hickson
3252701753 Make it possible to run tests live on a device (#3936) 
This makes it possible to substitute 'flutter run' for 'flutter test'
and actually watch a test run on a device.

For any test that depends on flutter_test:

1. Remove any import of 'package:test/test.dart'.

2. Replace `testWidgets('...', (WidgetTester tester) {`
      with `testWidgets('...', (WidgetTester tester) async {`

3. Add an "await" in front of calls to any of the following:
    * tap()
    * tapAt()
    * fling()
    * flingFrom()
    * scroll()
    * scrollAt()
    * pump()
    * pumpWidget()

4. Replace any calls to `tester.flushMicrotasks()` with calls to
   `await tester.idle()`.

There's a guarding API that you can use, if you have particularly
complicated tests, to get better error messages. Search for
TestAsyncUtils.
 2016-05-16 12:53:13 -07:00
Devon Carew
483922d15c allow per-command analytics suppression (#3919) 
* allow per-command analytics suppression

* rev the usage package dep
 2016-05-15 20:06:27 -07:00
Chinmay Garde
a21dedc16f Enable targetting AOTC Android builds from Mac hosts. (#3911) 2016-05-13 17:03:03 -07:00
Devon Carew
cc5d1adcfc handle an exit code from android n (#3914) 
* handle an exit code from android n

* review comments
 2016-05-13 16:47:30 -07:00
Yegor
15decfca6e reenable --checked option in flutter drive (#3916) 2016-05-13 16:42:28 -07:00
pq
4dd548578f Re-enable one_member_abstracts lint (#3608). 2016-05-13 14:28:21 -07:00
Seth Ladd
20897c3f66 Box too big (#3884) 
* shrink analytics message to < 80 chars

* catch line ending
 2016-05-13 09:44:36 -07:00
Devon Carew
40c0d6ea12 Consolidate observatory code (#3892) 
* rename service_protocol.dart to protocol_discovery.dart

* add a wrapper around the obs. protocol

* use json-rpc in run

* consolidate obs. code; implement flutter run --benchmark

* review comments
 2016-05-12 18:15:23 -07:00
Jason Simmons
32846de9f8 Remove ArtifactStore and move flutterRoot into Cache (#3883) 2016-05-12 15:54:35 -07:00
Phil Quitslund
616d9e2ea8 Merge pull request #3880 from pq/void_setters 
Turn on `avoid_return_types_on_setters` and cleanup annotated setters.
 2016-05-12 12:28:15 -07:00
Jason Simmons
a590ee2671 Remove BuildConfigurations (#3879) 
Artifacts from local engine builds will be found based on the --local-engine flag
 2016-05-12 12:22:15 -07:00
pq
e54196d7fc Turn on avoid_return_types_on_setters and cleanup annotated setters. 
It's safe to remove the unneeded `void`s from setters since the blocking issues in the
`always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/).  We can also safely flip the bit on  `avoid_return_types_on_setters`.
 2016-05-12 11:45:30 -07:00
Devon Carew
7072c8f255 Update version.dart (#3873) 2016-05-11 19:58:34 -07:00
Chinmay Garde
f0a8ee2a86 Use debug artifacts on mac host and update engine revision. (#3875) 2016-05-11 17:07:12 -07:00
Jason Simmons
0f53f7966b Remove Toolchain and extend ToolConfiguration to locate host tools such as sky_snapshot (#3870) 
Host tools can be found in the artifact cache directory for the host platform.
If a developer wants to use a local engine build instead, then provide an
--engine-build flag that selects the specific engine build variant.
 2016-05-11 15:47:26 -07:00
Devon Carew
45db865079 be more lenient when looking for matching android sdk components (#3830) 
* be more lenient when looking for matching android sdk components

* use a null aware operator
 2016-05-11 15:34:24 -07:00
Chinmay Garde
29b8c804da Update bucket names for each target and host build configuration. (#3866) 2016-05-11 14:54:51 -07:00
Chinmay Garde
915f24866a Change bucket names for iOS and Mac based on buildbot updates. (#3863) 2016-05-11 13:41:44 -07:00
Devon Carew
6635f1cf9b re-enable --checked (#3857) 2016-05-11 12:26:46 -07:00
Jason Simmons
82dbd43e74 Fix the paths for local engine builds targeting the host platform (#3855) 2016-05-11 11:11:34 -07:00
Collin Jackson
e2ab858202 Fix #3825 crash installing onto certain Android devices 2016-05-11 09:32:35 -07:00
Devon Carew
826936cd33 use vendored dart sdk; check the expected version of flutter (#3831) 
* use vendored dart sdk; check the expected version of flutter

* search up directories looking for the flutter root
 2016-05-10 16:21:30 -07:00
Phil Quitslund
eec3fc60f1 Merge pull request #3838 from pq/sdk_summaries 
Turn on SDK summaries in flutter analyze.
 2016-05-10 15:22:33 -07:00
Devon Carew
52d0434bec create a flutter setup command (#3837) 2016-05-10 15:04:29 -07:00
pq
a8f96de47d Removed unused import. 2016-05-10 14:37:39 -07:00
pq
d11651d293 Turn on SDK summaries in flutter analyze. 
The latest dev build has stable summaries so we should start using them.

(Also ensures that analysis options are propogating to the SDK analysis context --- see:  https://github.com/dart-lang/sdk/issues/26129.)
 2016-05-10 14:31:00 -07:00
Devon Carew
067715e302 Send exit for flutter run --resident (#3829) 
* send ext.flutter.exit

* listen for help restart, quit

* refactor into a separate class
 2016-05-10 13:47:00 -07:00
Todd Volkert
810b3e32a6 Fix regexp that strips invalid characters from the project identifier 
Fixes #3835
 2016-05-10 13:24:20 -07:00
Todd Volkert
43c0c52225 Fix regexp that strips invalid characters from the Uniform Type Identifier 
Fixes #3835
 2016-05-10 13:08:29 -07:00
Jason Simmons
6ab77622e4 Update flutter_tools for the "unoptimized" engine build flag and the new output directory naming scheme (#3832) 2016-05-10 12:02:09 -07:00
pq
18d971d492 Remove gratuitous pub resolver from flutter analysis. 
Package mapping is already done by the `PackageDependencyTracker` so this extra check is at best not needed.  (At worst could cause an unneeded and costly call to `pub list-package-dirs`!)
 2016-05-09 12:21:18 -07:00
Phil Quitslund
cc93170894 Merge pull request #3798 from pq/package_map_cleanup 
Analyze update to use in-memory package map.
 2016-05-09 11:53:21 -07:00
pq
1e50745df3 Constructor ordering. 2016-05-09 11:33:52 -07:00
Hans Muller
74c3e74fba Call it Flutter Gallery (#3801) 2016-05-09 11:00:54 -07:00
Devon Carew
a5b198e9b9 remove the --checked option (#3799) 2016-05-09 10:58:47 -07:00
pq
46d32794f9 Analyze update to use in-memory package map. 
Updates the analyze command to pass a package map to analysis rather than a file path.

This allows us to avoid creating a needless temporary `.packages` file and host directory and saves us a trip to disk to retrieve the contents when building our URI resolvers for analysis.
 2016-05-09 09:59:16 -07:00
Jason Simmons
2ea3c9471d Fix for how flutter refresh locates the Android package manifest (#3791) 2016-05-09 09:31:46 -07:00
Jason Simmons
09dde8718b Change the Android activity launch mode to singleTop (#3792) 2016-05-09 09:31:34 -07:00
pq
c973629ed7 Fixed braces. 2016-05-06 13:43:21 -07:00
pq
96de7c4dcc Fix analyzer error messages. 
Will have the result of restoring `[static warning]` to `[warning]`, etc.

(This is essentially how we handle it in the analyzer CLI.)
 2016-05-06 13:39:48 -07:00
pq
2df43d50d3 Merge branch 'master' into analysis_rework 2016-05-06 08:58:49 -07:00
Devon Carew
bd564a02af avoid sending analytics on ci systems (#3765) 
* avoid sending analytics on ci systems

* review comments
 2016-05-05 19:51:22 -07:00
Jason Simmons
4d0e6984c2 Build tool support for Android x86 targets in 32- or 64-bit modes (#3761) 2016-05-05 16:04:22 -07:00
pq
eb215c14ac Review cleanup. 2016-05-05 15:16:27 -07:00
Devon Carew
a999366482 remove the analyze --benhcmark-expected option (#3755) 2016-05-05 14:26:21 -07:00
pq
4311ddb461 Duplicate test fix. 2016-05-05 13:39:58 -07:00
pq
3b882fc449 Updated arg default handling and .dartignore support. 2016-05-05 13:25:59 -07:00
pq
e808125c5b Dead code cleanup. 2016-05-05 12:35:52 -07:00