github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
fea4a91ab6
Commit Graph

1169 Commits

Author SHA1 Message Date
Ian Hickson
f92f71feb9 Lock flutter tool while updating artifacts (#4476) 
This prevents multiple simultaneous runs of the analyzer from stomping
over each other (e.g. multiple runs of 'update-packages'). Certain
long-lived commands (like analyze, run, logs) are exempted once they've
done enough work to be safe from most stomping action.

This still doesn't make us entirely safe from craziness, e.g. if you're
half way through an 'update-packages' run and you call 'git pull', who
knows what state you'll end up in. But there's only so much one can do.

Fixes https://github.com/flutter/flutter/issues/2762
 2016-06-14 10:16:08 -07:00
Ian Hickson
2b2d782503 "--watch --flutter-repo" wasn't analyzing flutter (#4548) 2016-06-13 19:19:35 -07:00
Ian Hickson
2cdda9e679 Provide a way to save the analyzer results to disk (#4541) 2016-06-13 13:29:10 -07:00
Devon Carew
b6c3ae37f6 send supportsRestart flag when starting an app (#4513) 
* send supportsRestart flag when starting an app

* remove unused imports

* review comments
 2016-06-13 13:16:20 -07:00
Todd Volkert
2099d3789c Pull iOS build templates from flutter tools vs engine artifacts (#4526) 2016-06-13 12:30:08 -07:00
Ian Hickson
c9bcf1074e Analyzer was confused when you deleted files (#4528) 
Also, make it clear the screen between results so it's more obvious
what's going on when you have new results (especially when you have
fixed everything).
 2016-06-13 12:20:03 -07:00
Todd Volkert
d2ee6f7838 Rename app.so -> app.dylib (#4522) 2016-06-10 16:57:21 -07:00
Devon Carew
1ff3a2a039 show progress while running the analysis server (#4525) 2016-06-10 16:39:43 -07:00
Jason Simmons
484c36f145 Set the android:debuggable flag when building an APK in debug mode (#4523) 
See https://github.com/flutter/flutter/issues/4438
 2016-06-10 16:06:12 -07:00
Devon Carew
b2938f40e3 expose the devfs api (#4521) 2016-06-10 15:08:12 -07:00
Devon Carew
b5c8f2a43f print stack traces from the analysis server (#4507) 2016-06-10 06:48:16 -07:00
Kaiyuan Wang
8446ae3c87 Fix flutter drive crash issue when run in develop mode (#4492) 2016-06-09 12:39:14 -07:00
Adam Barth
c02c553867 Fix types for flutter test in checked mode (#4488) 
Fixes #4059
 2016-06-09 07:27:23 -07:00
Devon Carew
fcd68c8a21 Support route (#4470) 
* support --route in flutter run --resident

* also for the daemon app.start command
 2016-06-08 13:44:54 -07:00
Devon Carew
d3e5e48701 revmoe the debug:true param from the atom launch config (#4464) 2016-06-08 12:21:45 -07:00
Jason Simmons
0db04819dc More flexibility for defining the locations of assets packaged in an FLX (#4462) 
* Add a map of relative to absolute paths for assets located outside the app's
  source directory
* If a "packages" directory exists, obtain assets from there instead of
  using the packages/ prefix to indicate package map lookup
 2016-06-08 11:32:30 -07:00
Devon Carew
5c59862208 Update usage.dart (#4451) 
Update the analytics code.
 2016-06-08 09:38:12 -07:00
Adam Barth
440aa5ee2f Add -t support to flutter run on iOS (#4439) 2016-06-07 16:41:53 -07:00
Devon Carew
3ba17136b7 add a restart command to the daemon protocol (#4385) 
* refactor the --resident run option into a separate file

* update daemon to run --resident apps

* re-plumbing daemon start

* send app logs

* update tests

* review changes

* fix test runner

* remove PackageMap.createGlobalInstance; rely on the ctor

* review comments
 2016-06-07 12:13:35 -07:00
Chinmay Garde
68ba5bfd7c Suppress verbose output from ios-deploy when not in verbose mode. (#4423) 2016-06-07 12:02:08 -07:00
Devon Carew
958fb0f888 Update flutter_command_runner.dart (#4398) 2016-06-06 15:35:31 -07:00
Adam Barth
8f03ebe56b Teach FlutterPlugin.groovy about AOT builds (#4389) 
The `flutter.buildMode` property now controls whether to build in debug,
profiling, or release.
 2016-06-06 12:56:04 -07:00
Devon Carew
6c96e1a320 use the --resident option on flutter run by default (#4386) 2016-06-06 10:29:27 -07:00
Phil Quitslund
6d2d495369 Merge pull request #4348 from pq/fix_4091 
Fix flutter analyze defaults when files are specified (#4091).
 2016-06-06 10:00:55 -07:00
Adam Barth
29af5c0317 Set a sensible default framework path (#4370) 
This patch sets a default path for Flutter.framework that's sensible based on
the FLUTTER_MODE.
 2016-06-03 17:01:18 -07:00
Chinmay Garde
8756a094a9 Add a FLUTTER_MODE variable to the generated Xcconfig and fix snapshot generation on all targets. (#4362) 
Get rid of the DART_EXPERIMENTAL_INTERPRETER_FLAG.
 2016-06-03 13:55:57 -07:00
Devon Carew
26076d9efd Update utils.dart (#4364) 2016-06-03 13:21:16 -07:00
Devon Carew
7ae584bc02 handle 'last message repeated' from ios simulator (#4300) 2016-06-03 12:54:27 -07:00
pq
ce82bc1b15 Check for user specified args. 2016-06-03 12:52:43 -07:00
Adam Barth
8171aa86f0 Document how to build hello_services for iOS (#4354) 
This patch adds some sensible defaults to xcode_backend.sh and documents how to
build hello_services for iOS using Xcode.
 2016-06-03 12:20:54 -07:00
pq
305af8b873 Fix flutter analyze defaults when files are specified (#4091). 
Disables current package and current directory analysis when files are specified.

Fixes: https://github.com/flutter/flutter/issues/4091.
 2016-06-03 09:24:54 -07:00
Jason Simmons
d8d0d6b31b Resolve package references in font asset paths (#4334) 2016-06-02 15:05:41 -07:00
Eric Seidel
4c86b73027 wip 2016-06-02 14:17:21 -07:00
Jason Simmons
00c7734c8b Tools daemon handlers for discovering apps and forwarding device ports (#4324) 2016-06-02 14:00:27 -07:00
Adam Barth
612a097d1f Add --target support to flutter build ios (#4318) 
Fixes #4298
 2016-06-02 08:57:13 -07:00
Devon Carew
bc5d407477 fix an issue where the refresh benchmark would overwrite a completer (#4315) 2016-06-01 19:57:08 -07:00
Devon Carew
9e9dfc3d2d fix a race condition with isolate notification (#4286) 
* fix a race condition with isolate notification

* return a future
 2016-06-01 15:17:04 -07:00
Devon Carew
2a2bd7b6f4 fix an exception while parsing a services file (#4302) 2016-06-01 14:06:44 -07:00
Adam Barth
c26fcfdfaa Update xcodebuild for Generated.xcconfig (#4268) 
This patch updates how we generate xcconfig files to match what
xcode_backend.sh expects.
 2016-06-01 12:32:45 -07:00
Phil Quitslund
77b8e3273d Merge pull request #4271 from pq/0.27.4-alpha.9 
Update analyzer dep to 0.27.4-alpha.9
 2016-05-31 11:31:16 -07:00
Jason Simmons
49c4064132 Add Dart IO entry points to the snapshotter command line (#4257) 2016-05-31 10:51:28 -07:00
pq
985a7b91cf Update analyzer dep to 0.27.4-alpha.9 
Update analyzer dep to 0.27.4-alpha.9 to enjoy analyzer perf improvements (https://codereview.chromium.org/2011183004/) (and keep in sync with the SDK).

(This is a revisit to https://github.com/flutter/flutter/pull/4253.)
 2016-05-31 06:59:56 -07:00
Adam Barth
7de84709cf Address review comments on prior patch (#4270) 
I pulled the trigger to land the previous patch too quickly and missed a
number of comments.
 2016-05-30 14:47:49 -07:00
Devon Carew
7c47837c27 show build progress; print app sizes (#4263) 
* show build progress; print app sizes

* add todo

* review comments

* remove unused import
 2016-05-29 15:07:41 -07:00
Devon Carew
49affc4098 make the drive output prettier (#4260) 2016-05-27 22:36:07 -07:00
Devon Carew
111392d7c9 run pub get (w/ symlinks) for flutter drive (#4259) 
* run pub get (w/ symlinks) for flutter drive

* review comments
 2016-05-27 21:42:46 -07:00
Adam Barth
aee32698ac Add backend tools for extensible iOS apps (#4250) 
Instead of embedding Flutter.framework and BuildFlutterApp in the Xcode
project, we store these in flutter.git, where we can reference them.
 2016-05-27 15:30:42 -07:00
Devon Carew
c98ce02417 print the dartlang atom plugin version from flutter doctor (#4242) 2016-05-27 13:31:55 -07:00
Chinmay Garde
989a530350 Don't avoid linking with libSystem to work around issue in dyld. (#4241) 2016-05-27 11:24:10 -07:00
Todd Volkert
51d4ab3324 Fix install for iOS simulator, and add ability to uninstall (#4223) 2016-05-27 11:05:10 -07:00
Yegor
f544abd016 modernize flutter drive w.r.t. debug/profile/release options (#4217) 
* modernize `flutter drive` w.r.t. debug/profil/release options

* make error message prettier
 2016-05-27 10:02:36 -07:00
Devon Carew
ec7517766c Flutter run restart (#4105) 
* working on making a faster flutter run restart

* clean up todos; fire events on isolate changes

* use the Flutter.FrameworkInitialization event

* review comments
 2016-05-26 15:26:14 -07:00
Devon Carew
646b5350d1 resolve symlinks in paths to flutter (#4219) 
* resolve symlinks in paths to flutter

* review comments
 2016-05-26 14:41:33 -07:00
Devon Carew
d6aed1e7c9 add a --quiet option to flutter_tools (#4213) 2016-05-26 13:41:29 -07:00
Todd Volkert
239a717dcc Revert "Pass the local engine config through Xcode (#4190)" 
This reverts commit 8f69cccc18.
 2016-05-26 11:03:08 -07:00
Adam Barth
fde55a6f6a Update vector_math (#4201) 
The new version has an API change. Also, up our SDK requirements to be a
bit more realistic.
 2016-05-26 09:49:09 -07:00
Devon Carew
9cfa96608c dissallow -release mode on emulators (#4204) 
* dissallow -release mode on emulators

* have the help text print the default mode
 2016-05-26 09:14:51 -07:00
Todd Volkert
92ee807a3c Plumb --local-engine flag through to LOCAL_ENGINE in Local.xcconfig 
Fixes #4186
 2016-05-25 18:37:36 -07:00
Adam Barth
c69cff9428 Update test package (#4198) 2016-05-25 17:45:23 -07:00
Jason Simmons
5aa9a7fc53 Forward the observatory (but not the diagnostic server) when in profile mode (#4183) 2016-05-25 15:21:11 -07:00
Adam Barth
8f69cccc18 Pass the local engine config through Xcode (#4190) 
This passes the information through Xcode to the `flutter build aot` call via
the environment so that it picks up the right artifacts.

Fixes #4186
 2016-05-25 14:33:22 -07:00
Todd Volkert
0da58802cf Fix aot compiler and linker args 2016-05-25 14:32:57 -07:00
Adam Barth
b1b6271683 Use "call" instead of "invoke" (#4177) 
For consistency.

Fixes #4142
 2016-05-24 17:53:04 -07:00
Adam Barth
e8e9d4633c Workaround https://github.com/dart-lang/sdk/issues/26362 (#4171) 
When building AOT, we now run `pub get` instead of printing an error telling
the user to run `pub get`. We can remove this code once the bug reference above
is fixed (should be a couple days).
 2016-05-24 16:29:13 -07:00
Todd Volkert
cc8c78adf4 iOS tools cleanup (#4161) 
* iOS tools cleanup

1) Fix `flutter install` on both device and simulator to refer to the actual
   bundle and not just the .generated folder
2) Fix `flutter run` on device to actually run vs just installing

Still TODO:
1) Discovered that isAppInstalled on iOS simulator always reports true,
   meaning it'll never actually try to install the app.

Fixes #3947
Fixes #1823
 2016-05-24 16:25:40 -07:00
Adam Barth
2d726fc0c5 Build app.so instead of app.a on iOS (#4168) 
The app.a wasn't getting pulled into the main executable because we weren't
referencing any of its symbols. Instead, create a dylib that can be packaged
with the application and loaded at runtime.
 2016-05-24 15:49:53 -07:00
Adam Barth
e8a47b6d49 Add --interpreter to flutter build aot (#4159) 
This patch teaches flutter build aot to build `app.a` for use with the Dart
interpreter.
 2016-05-24 12:06:53 -07:00
Adam Barth
cb7a690815 Let flutter build aot select a target platform (#4154) 
Currently only android-arm and ios are supported target platforms.
 2016-05-24 11:21:07 -07:00
Adam Barth
f33596aacb Teach flutter to build app.a (#4141) 
On iOS, we use Xcode to build a static library that contains the precompiled
code. This code is currently unused, but it will be used by the new Xcode
harness to factor out as much complexity as possible into the flutter tool.
 2016-05-24 09:49:31 -07:00
Devon Carew
4764550f9f fail flutter analyze when there are errors (#4117) 2016-05-23 14:39:42 -07:00
Chinmay Garde
66fee3a622 Wire up ios-profile and ios-release. Switching between debug, profile and release starts the build process from scratch. (#4063) 2016-05-23 12:58:42 -07:00
Devon Carew
1ae0a76cf9 warn when flutter doesn't match the pubspec version (#4109) 2016-05-23 12:23:05 -07:00
Devon Carew
4962656b1d remove old command aliases (#4103) 2016-05-23 12:06:49 -07:00
Devon Carew
17b9c12b80 adjust adb logcat filter (#4104) 2016-05-23 12:04:07 -07:00
Ian Hickson
10c861d6e9 Track number of pending dartdocs too (#4088) 2016-05-20 16:47:44 -07:00
Ian Hickson
94636bd206 Cleanup based on new lints (#4052) 2016-05-20 14:08:46 -07:00
Todd Volkert
3042da9f6d Prefer getAdbPath(androidSdk) over androidSdk.adbPath (#4076) 
For developers with the platform tools installed but no SDK, it prevents
crashing in the flutter tool in favor of more user-friendly error messages
downstream.
 2016-05-20 10:45:35 -07:00
Devon Carew
3b3b0ff1bb make sdb getprop less verbose (#4053) 2016-05-19 14:10:09 -07:00
Devon Carew
95f838b072 Update trace.dart (#4055) 2016-05-19 14:06:40 -07:00
Phil Quitslund
3693a7c303 Merge pull request #4054 from pq/overriden_field 
Fix analyzer field overrides.
 2016-05-19 13:43:27 -07:00
pq
2a9d2b5f30 Fix analyzer field overrides. 
Cleans up 3 of the 4 violations of the `overriden_field` lint.

The last one is more interesting and I'll defer to someone closer to that code:

    [lint] Do not override fields. (packages/flutter/test/rendering/rendering_tester.dart, line 91, col 14)
 2016-05-19 13:12:04 -07:00
Eric Seidel
880f2f785e flutter test now works on mac as well as linux 
@chinmaygarde
 2016-05-19 13:10:15 -07:00
Devon Carew
a48b063a10 rebuild when the build type changes (#4032) 
* rebuild when the build type changes

* handle local engine builds

* also check the timestamp
 2016-05-19 12:49:40 -07:00
Phil Quitslund
8109bde6e3 Merge pull request #4036 from pq/comment_refs 
Cleanup dangling comment references.
 2016-05-19 11:19:55 -07:00
Devon Carew
0b5072c2ef fix check to ignore bots (#4034) 2016-05-19 10:51:31 -07:00
pq
1a6f499bc1 Cleanup dangling comment references. 
Quick pass at fixing a few dangling references as revealed by the new `comment_references` lint (https://github.com/dart-lang/linter/issues/240).

There's a bunch more to do here before we can turn it on by default (~430 lints as of now).  Many of them are a simple matter of adding an import (e.g., `dart:async` for library docs that reference `Future`) but others will require a bit of thought.  Probably best done by the folks writing the code. :)
 2016-05-19 10:21:38 -07:00
Chinmay Garde
376cb2eb38 Attach standard streams of the child sky_shell process so that logs from the shell show up. (#4024) 2016-05-18 16:58:46 -07:00
pq
addc888926 Update to new analyzer and linter. 
Notably, this will allow us to play with

* the fixed `public_member_api_docs` that now checks for documented getters when checking setters (https://github.com/dart-lang/linter/issues/237), and
* the new `comment_references` lint that ensures identifiers referenced in docs are in scope (https://github.com/dart-lang/linter/issues/240).
 2016-05-18 11:47:44 -07:00
pq
7163cf115d Revert "Update to new analyzer and linter." 
This reverts commit f91cf1c450.
 2016-05-18 11:45:25 -07:00
pq
f91cf1c450 Update to new analyzer and linter. 
Notably, this will allow us to play with

* the fixed `public_member_api_docs` that now checks for documented getters when checking setters (https://github.com/dart-lang/linter/issues/237), and
* the new `comment_references` lint that ensures identifiers referenced in docs are in scope (https://github.com/dart-lang/linter/issues/240).
 2016-05-18 11:44:43 -07:00
Jason Simmons
fc61060421 Log an error if the Android intent fails during flutter refresh (#3988) 2016-05-17 14:35:11 -07:00
Ian Hickson
f284c1a049 Fix tests (#3977) 
Also, make sure that broken tests actually break the bots.

And add a test to make sure that keeps happening.
 2016-05-17 12:45:37 -07:00
Jason Simmons
c192a7e4ca Replace the checked flag in DebuggingOptions with the build mode (#3901) 
This also fixes some related problems affecting "flutter run":
  * FLXes built during AndroidDevice.startApp need to match the build mode
  * APKs should always be rebuilt if the build mode uses AOT compilation
 2016-05-17 12:38:25 -07:00
pq
97ba6a1e0b Re-enable implementation_imports lint rule. 2016-05-17 11:02:10 -07:00
Phil Quitslund
a6b8980d3e Merge pull request #3954 from pq/summaries_off 
Back out SDK summaries.
 2016-05-17 09:03:15 -07:00
Phil Quitslund
04cdf71add Merge pull request #3955 from pq/type_annotate_public_apis_off 
Remove redundant type annotation lint.
 2016-05-17 09:02:27 -07:00
Collin Jackson
b4313b04b0 Merge pull request #3946 from collinjackson/apk 
Make flutter run generate identical apks to flutter build apk
 2016-05-17 07:30:10 -07:00
Collin Jackson
a312db482d remove the add-files argument to flutter run 2016-05-16 18:33:59 -07:00
Chinmay Garde
0e8f26dd6c Use the correct host toolchain when building from a local engine checkout on Mac. (#3956) 2016-05-16 17:05:39 -07:00
pq
464ccdfcac Remove redundant type annotation lint. 
SInce this is a subset of `always_specify_types` I think we can safely remove it.

In practice, if you violate you get doubly nagged:
```
[lint] Type annotate public APIs. (packages/flutter_tools/lib/src/dart/runner.dart, line 5, col 1)
[lint] Declare method return types. (packages/flutter_tools/lib/src/dart/runner.dart, line 5, col 1)
```

One warning is probably enough to get the message across? ;)
 2016-05-16 16:02:18 -07:00
pq
fddab5d800 Back out SDK summaries. 
Net-net: SDK summaries are not safe in the presence of SDK library embedders.

Context (and bug to track re-enablement) here: https://github.com/dart-lang/sdk/issues/26467.
 2016-05-16 15:57:45 -07:00
Collin Jackson
00e22284f2 Fix #3891 by making flutter run generate identical apks to flutter build apk 2016-05-16 15:53:18 -07:00
Ian Hickson
3252701753 Make it possible to run tests live on a device (#3936) 
This makes it possible to substitute 'flutter run' for 'flutter test'
and actually watch a test run on a device.

For any test that depends on flutter_test:

1. Remove any import of 'package:test/test.dart'.

2. Replace `testWidgets('...', (WidgetTester tester) {`
      with `testWidgets('...', (WidgetTester tester) async {`

3. Add an "await" in front of calls to any of the following:
    * tap()
    * tapAt()
    * fling()
    * flingFrom()
    * scroll()
    * scrollAt()
    * pump()
    * pumpWidget()

4. Replace any calls to `tester.flushMicrotasks()` with calls to
   `await tester.idle()`.

There's a guarding API that you can use, if you have particularly
complicated tests, to get better error messages. Search for
TestAsyncUtils.
 2016-05-16 12:53:13 -07:00
Devon Carew
483922d15c allow per-command analytics suppression (#3919) 
* allow per-command analytics suppression

* rev the usage package dep
 2016-05-15 20:06:27 -07:00
Chinmay Garde
a21dedc16f Enable targetting AOTC Android builds from Mac hosts. (#3911) 2016-05-13 17:03:03 -07:00
Devon Carew
cc5d1adcfc handle an exit code from android n (#3914) 
* handle an exit code from android n

* review comments
 2016-05-13 16:47:30 -07:00
Yegor
15decfca6e reenable --checked option in flutter drive (#3916) 2016-05-13 16:42:28 -07:00
pq
4dd548578f Re-enable one_member_abstracts lint (#3608). 2016-05-13 14:28:21 -07:00
Seth Ladd
20897c3f66 Box too big (#3884) 
* shrink analytics message to < 80 chars

* catch line ending
 2016-05-13 09:44:36 -07:00
Devon Carew
40c0d6ea12 Consolidate observatory code (#3892) 
* rename service_protocol.dart to protocol_discovery.dart

* add a wrapper around the obs. protocol

* use json-rpc in run

* consolidate obs. code; implement flutter run --benchmark

* review comments
 2016-05-12 18:15:23 -07:00
Jason Simmons
32846de9f8 Remove ArtifactStore and move flutterRoot into Cache (#3883) 2016-05-12 15:54:35 -07:00
Phil Quitslund
616d9e2ea8 Merge pull request #3880 from pq/void_setters 
Turn on `avoid_return_types_on_setters` and cleanup annotated setters.
 2016-05-12 12:28:15 -07:00
Jason Simmons
a590ee2671 Remove BuildConfigurations (#3879) 
Artifacts from local engine builds will be found based on the --local-engine flag
 2016-05-12 12:22:15 -07:00
pq
e54196d7fc Turn on avoid_return_types_on_setters and cleanup annotated setters. 
It's safe to remove the unneeded `void`s from setters since the blocking issues in the
`always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/).  We can also safely flip the bit on  `avoid_return_types_on_setters`.
 2016-05-12 11:45:30 -07:00
Devon Carew
7072c8f255 Update version.dart (#3873) 2016-05-11 19:58:34 -07:00
Chinmay Garde
f0a8ee2a86 Use debug artifacts on mac host and update engine revision. (#3875) 2016-05-11 17:07:12 -07:00
Jason Simmons
0f53f7966b Remove Toolchain and extend ToolConfiguration to locate host tools such as sky_snapshot (#3870) 
Host tools can be found in the artifact cache directory for the host platform.
If a developer wants to use a local engine build instead, then provide an
--engine-build flag that selects the specific engine build variant.
 2016-05-11 15:47:26 -07:00
Devon Carew
45db865079 be more lenient when looking for matching android sdk components (#3830) 
* be more lenient when looking for matching android sdk components

* use a null aware operator
 2016-05-11 15:34:24 -07:00
Chinmay Garde
29b8c804da Update bucket names for each target and host build configuration. (#3866) 2016-05-11 14:54:51 -07:00
Chinmay Garde
915f24866a Change bucket names for iOS and Mac based on buildbot updates. (#3863) 2016-05-11 13:41:44 -07:00
Devon Carew
6635f1cf9b re-enable --checked (#3857) 2016-05-11 12:26:46 -07:00
Jason Simmons
82dbd43e74 Fix the paths for local engine builds targeting the host platform (#3855) 2016-05-11 11:11:34 -07:00
Collin Jackson
e2ab858202 Fix #3825 crash installing onto certain Android devices 2016-05-11 09:32:35 -07:00
Devon Carew
826936cd33 use vendored dart sdk; check the expected version of flutter (#3831) 
* use vendored dart sdk; check the expected version of flutter

* search up directories looking for the flutter root
 2016-05-10 16:21:30 -07:00
Phil Quitslund
eec3fc60f1 Merge pull request #3838 from pq/sdk_summaries 
Turn on SDK summaries in flutter analyze.
 2016-05-10 15:22:33 -07:00
Devon Carew
52d0434bec create a flutter setup command (#3837) 2016-05-10 15:04:29 -07:00
pq
a8f96de47d Removed unused import. 2016-05-10 14:37:39 -07:00
pq
d11651d293 Turn on SDK summaries in flutter analyze. 
The latest dev build has stable summaries so we should start using them.

(Also ensures that analysis options are propogating to the SDK analysis context --- see:  https://github.com/dart-lang/sdk/issues/26129.)
 2016-05-10 14:31:00 -07:00
Devon Carew
067715e302 Send exit for flutter run --resident (#3829) 
* send ext.flutter.exit

* listen for help restart, quit

* refactor into a separate class
 2016-05-10 13:47:00 -07:00
Todd Volkert
810b3e32a6 Fix regexp that strips invalid characters from the project identifier 
Fixes #3835
 2016-05-10 13:24:20 -07:00
Todd Volkert
43c0c52225 Fix regexp that strips invalid characters from the Uniform Type Identifier 
Fixes #3835
 2016-05-10 13:08:29 -07:00
Jason Simmons
6ab77622e4 Update flutter_tools for the "unoptimized" engine build flag and the new output directory naming scheme (#3832) 2016-05-10 12:02:09 -07:00
pq
18d971d492 Remove gratuitous pub resolver from flutter analysis. 
Package mapping is already done by the `PackageDependencyTracker` so this extra check is at best not needed.  (At worst could cause an unneeded and costly call to `pub list-package-dirs`!)
 2016-05-09 12:21:18 -07:00
Phil Quitslund
cc93170894 Merge pull request #3798 from pq/package_map_cleanup 
Analyze update to use in-memory package map.
 2016-05-09 11:53:21 -07:00
pq
1e50745df3 Constructor ordering. 2016-05-09 11:33:52 -07:00
Hans Muller
74c3e74fba Call it Flutter Gallery (#3801) 2016-05-09 11:00:54 -07:00
Devon Carew
a5b198e9b9 remove the --checked option (#3799) 2016-05-09 10:58:47 -07:00
pq
46d32794f9 Analyze update to use in-memory package map. 
Updates the analyze command to pass a package map to analysis rather than a file path.

This allows us to avoid creating a needless temporary `.packages` file and host directory and saves us a trip to disk to retrieve the contents when building our URI resolvers for analysis.
 2016-05-09 09:59:16 -07:00
Jason Simmons
2ea3c9471d Fix for how flutter refresh locates the Android package manifest (#3791) 2016-05-09 09:31:46 -07:00
Jason Simmons
09dde8718b Change the Android activity launch mode to singleTop (#3792) 2016-05-09 09:31:34 -07:00
pq
c973629ed7 Fixed braces. 2016-05-06 13:43:21 -07:00
pq
96de7c4dcc Fix analyzer error messages. 
Will have the result of restoring `[static warning]` to `[warning]`, etc.

(This is essentially how we handle it in the analyzer CLI.)
 2016-05-06 13:39:48 -07:00
pq
2df43d50d3 Merge branch 'master' into analysis_rework 2016-05-06 08:58:49 -07:00
Devon Carew
bd564a02af avoid sending analytics on ci systems (#3765) 
* avoid sending analytics on ci systems

* review comments
 2016-05-05 19:51:22 -07:00
Jason Simmons
4d0e6984c2 Build tool support for Android x86 targets in 32- or 64-bit modes (#3761) 2016-05-05 16:04:22 -07:00
pq
eb215c14ac Review cleanup. 2016-05-05 15:16:27 -07:00
Devon Carew
a999366482 remove the analyze --benhcmark-expected option (#3755) 2016-05-05 14:26:21 -07:00
pq
4311ddb461 Duplicate test fix. 2016-05-05 13:39:58 -07:00
pq
3b882fc449 Updated arg default handling and .dartignore support. 2016-05-05 13:25:59 -07:00
pq
e808125c5b Dead code cleanup. 2016-05-05 12:35:52 -07:00
pq
71203e9a89 Analyzer dep commentary fix. 2016-05-05 12:15:26 -07:00
pq
a59a713f75 Analysis re-work to use analyzer APIs. 
Introduces a new Dart analysis wrapper that works directly with the analyzer API (in favor of shelling out to a separate process).

Some consequences:

  * we no longer need to fear parts (simplifying our dart file gathering)
  * we can filter by error code (when needed), rather than by error strings
  * no more IO scraping
  * no need to generate `main()` or to run with `--package-warnings`
  * we now specify an analyzer (and linter) version in the pubspec (we’ll want to make sure this doesn’t diverge too far from the analyzer shipped with the SDK but it does give us some room to play with experimental builds)
  * no more (re)scanning of error source files (and so no more source cache)
  * should generally be a bit simpler and easier to maintain
  * runs a bit faster :)
 2016-05-05 12:08:58 -07:00
Phil Quitslund
0e515631a1 Merge pull request #3739 from pq/eq_matcher_cleanup 
Prefer implict `equals` matcher in test expectations.
 2016-05-04 14:16:06 -07:00
Yegor
39e741dfb7 [tools] remove --flutter-repo flag in flutter test (#3728) 2016-05-04 14:08:16 -07:00
pq
79d1d3a7c4 Prefer implict equals matcher in test expectations. 
@Hixie: as per our conversation, a little more concise.
 2016-05-04 13:58:45 -07:00
Devon Carew
61c003734b checked mode fix; add type annotation (#3737) 2016-05-04 13:41:46 -07:00
Devon Carew
f34d31717c complain on missing entries in flutter.yaml (#3731) 
* complain on missing entries in flutter.yaml

* change to a hard failure
 2016-05-04 12:33:34 -07:00
Devon Carew
e365453eac better parsing of adb devices output (#3726) 
* better parsing of adb devices output

* re-order lines
 2016-05-04 12:32:46 -07:00
Devon Carew
e464a81998 remove the packages/flutter_tools/.analysis_options file (#3733) 2016-05-04 11:43:01 -07:00
Devon Carew
1d4cda5d13 fix the benchmark file written by the analyze command (#3725) 2016-05-04 10:01:39 -07:00
Devon Carew
713830964c make the usage text more visible (#3693) 
* make the usage text more visible

* update the look of the usage text
 2016-05-03 15:17:30 -07:00
Ian Hickson
961f5cd266 Fix framework-side time in profile data (#3706) 2016-05-03 14:45:22 -07:00
Collin Jackson
57d6e8514b Merge pull request #3701 from collinjackson/assets 
Support for putting assets in android/assets folder (like ios/Resources)
 2016-05-03 14:08:47 -07:00
Ian Hickson
4b6af7a42f Provide framework-only timing information (#3699) 
This makes it easier to generate charts that show the engine time and
the framework time separately.
 2016-05-03 13:51:22 -07:00
Collin Jackson
80ef81422d Support for putting assets in android/assets folder (like ios/Resources) 2016-05-03 13:32:35 -07:00
Devon Carew
00062761be filter an assertiond log message from ios (#3692) 2016-05-03 12:46:46 -07:00
Devon Carew
c9010c91f6 fix analysis errors (#3677) 
* fix analysis errors

* review comments; fix test

* re-add an export for debugPrint
 2016-05-03 09:09:00 -07:00
Eric Seidel
f58fa766c3 Add note about explicit pub get needed. 
@devoncarew @jason-simmons
 2016-05-02 16:14:35 -07:00
Jason Simmons
30d8dc1399 Check the adb install output for errors and stop "flutter run" if package installation fails (#3672) 2016-05-02 14:11:40 -07:00
Jason Simmons
f161f239ef Download Android AOT tools to the artifacts cache and build APKs using these tools (#3649) 
Also update the engine to a build where these tools have been uplaoded
 2016-05-02 11:40:32 -07:00
Adam Barth
21f1827bad Add a sensible error message when jarsigner is missing (#3665) 
Fixes #3624
 2016-05-02 10:27:34 -07:00
Devon Carew
66c868e492 Update pubspec.yaml 
Pick up a bug fix to the `usage` package.
 2016-04-30 08:19:36 -07:00
Jason Simmons
01a27ca4ae Build ahead-of-time compiled snapshots and incorporate them into Android APKs (#3592) 
This currently requires a local build of the engine.

Run "flutter build aot" to build an AOT snapshot.
Run "flutter build apk --profile" to build a "profile mode" APK that uses AOT.
 2016-04-29 13:44:01 -07:00
Devon Carew
60755f6d9c fix an issue parsing adb output (#3629) 2016-04-29 09:52:44 -07:00
Devon Carew
99114cd414 show more errors on missing jarsigner (#3626) 2016-04-28 22:48:01 -07:00
Yegor
81af593745 [tools] download traces only from non-resident runs (#3615) 2016-04-28 13:35:32 -07:00
Devon Carew
50b1b16db6 rev test to 0.12.13+1 to support 1.17.0-dev dart sdks (#3613) 2016-04-28 12:56:55 -07:00
Adam Barth
b7fd5426b5 Enable avoid_as lint (#3612) 
Related to #3608
 2016-04-28 11:07:39 -07:00
Devon Carew
26ed1e71f9 simplify the analysis benchmarking code (#3588) 
* simplify the analysis benchmarking code

* review comments
 2016-04-28 10:25:26 -07:00
Yegor
c2cccc7b3b [tools] teach flutter run to get startup trace info (#3589) 2016-04-27 17:58:20 -07:00
Devon Carew
b0dca79671 Flutter run (#3553) 
* rework flutter run

* fix npe with --debug-port

* connect to obs and exit when that conneciton closes

* update todos
 2016-04-27 14:43:42 -07:00
Devon Carew
b0ebc71695 clean up git commits (#3578) 2016-04-27 10:47:52 -07:00
Devon Carew
adac927501 add google analytics to flutter_tools (#3523) 
* add google analytics

* send in the run target type

* track device type targets

* use the real GA code

* review comments

* rev to usage 2.0

* rev to 2.2.0 of usage; add tests

* review comments
 2016-04-26 16:25:11 -07:00
Devon Carew
c69f4396e3 add a benchmarking mode to flutter analyze (#3569) 
* add a benchmarking mode to flutter analyze

* change arg names
 2016-04-26 14:09:16 -07:00
Jason Simmons
07951ee90f Add a profile build mode flag for building APKs with AOT compilation (#3526) 
This is currently hidden for development use.  It will select artifacts from
the android_{Debug,Release}_Deploy output in a local engine build.
 2016-04-25 13:36:31 -07:00
Ian Hickson
b1e684ea63 Fix crash in analyzer if preamble isn't set. (#3525) 2016-04-25 11:25:29 -07:00
Devon Carew
86723ab99e Better devices text (#3519) 
* improve text for devices

* nit

* tweak text
 2016-04-25 10:14:38 -07:00
Devon Carew
4e2657d25a exclude files from build/ when looking for asset variants (#3512) 
* exclude files from build/ when looking for asset variants

* exclude some dirs when creating flx files
 2016-04-25 10:14:31 -07:00
Devon Carew
ace1a64bfd don't print installing device twice (#3520) 2016-04-25 09:25:47 -07:00
Jason Simmons
cf56caa708 Add a flag to "flutter build apk" that can package additional files into the APK (#3474) 2016-04-21 16:02:08 -07:00
Devon Carew
731c5903c2 cache the source lines when running analyze (#3436) 2016-04-20 11:26:24 -07:00
Devon Carew
435fdbff25 move driver create test to the flutter_tools package (#3433) 
* move driver create test to the flutter_tools package

* review comments
 2016-04-20 10:48:27 -07:00
Ian Hickson
1b9476c4d9 Hide routes from the API when they're not needed. (#3431) 
The 'routes' table is a point of confusion with new developers. By
providing a 'home' argument that sets the '/' route, we can delay the
point at which we teach developers about 'routes' until the point where
they want to have a second route.
 2016-04-20 09:33:28 -07:00
Devon Carew
80fabfd3dd allow flutter create to re-gen over an existing project (#3419) 
* allow flutter create to re-gen over an existing project

* add a regression test
 2016-04-19 19:30:49 -07:00
Devon Carew
dd2bde1918 add a service extension for repaint rainbow (#3409) 
* add a service extension for repaint rainbow

* review comments
 2016-04-19 12:57:10 -07:00
Devon Carew
6f0bb20658 rename deploy to release (#3407) 2016-04-19 11:17:00 -07:00
Jason Simmons
8451b669c8 Collect trace data through the observatory HTTP interface (#3393) 2016-04-19 10:38:49 -07:00
Yegor
e7657b9462 [driver] "waitFor" command in place of broken "exists" (#3373) 
* [driver] "waitFor" command in place of broken "exits"

* [driver] wait using frame callback
 2016-04-19 09:49:22 -07:00
Devon Carew
1c0a966384 rename the --develop option to --debug (#3384) 
* rename the --develop option to --debug

* fail if both --debug and --deploy are specified
 2016-04-18 16:41:15 -07:00
Ian Hickson
a9eddd4860 Also analyze the driver host entry points. (#3395) 2016-04-18 16:33:03 -07:00
Ian Hickson
424a6b1d6a Handle files disappearing during analysis (#3390) 2016-04-18 15:19:32 -07:00
Devon Carew
29fdc7a464 rename the --release and --debug flags (#3382) 2016-04-18 13:04:59 -07:00
Devon Carew
325354f6be add a temporary .analysis_options for flutter_tools (#3376) 2016-04-18 09:50:19 -07:00
Phil Quitslund
246a2cb055 Merge pull request #3375 from pq/sdk_opt 
Analyze CLI option to specify a custom Dart SDK.
 2016-04-18 09:44:05 -07:00
pq
26519aab23 Fixed spacing. 2016-04-18 09:25:17 -07:00
pq
4ff0e842e2 Analyze CLI option to specify a custom Dart SDK. 
Handy for testing against specific local SDK builds.

(Note that the option is hidden.)
 2016-04-18 09:03:31 -07:00
Devon Carew
12cac94cda Use arm deploy (#3374) 
* download android-arm-deploy

* wire up --deploy to android-arm-deploy

* fix interpolation
 2016-04-18 09:01:43 -07:00
Devon Carew
f132acaf1d use the new cache code to locate more artifacts (#3361) 
* use the new cache code to locate more artifacts

* add todo

* review comments
 2016-04-15 21:08:03 -07:00
Devon Carew
4678c12098 find all repo packages (#3368) 
* find all repo packages

* .dartignore
 2016-04-15 20:25:57 -07:00
Yegor
9ce995f65e [driver] refactor API to finder objects (#3365) 2016-04-15 16:57:35 -07:00
Eric Seidel
711bf72620 Make update-packages cover dev/benchmarks. 
update-packages only looks one level down, instead of
changing that, I'm just adding dev/benchmarks explicitly.

This will unbreak the bots which are dying trying to
flutter drive dev/benchmarks/complex_layout without
pub get having been run there.

@yjbanov @devoncarew
 2016-04-15 12:35:02 -07:00
pq
de25ea22f7 Adding @optionalTypeArgs. 
With the new dev build we've got the updated linter and so can use the `@optionalTypeArgs` annotation (in `meta 0.12.0`).

Bonus: this lets us clean up one more Regexp in the `analyze` command! :)
 2016-04-14 10:03:46 -07:00
Devon Carew
b172dd5a1a run pub for analyze and test (#3310) 
* run pub for analyze and test

* don't run pub when doing repo analysis

* move logic for when to run pub into the commands

* re-write ternary expression
 2016-04-13 19:55:28 -07:00
Eric Seidel
341bd47624 Move flutter drive to use 8183 to not conflict with diagnostic server 
When @jason-simons added the diagnostic server on Android this
happened to conflict with flutter drive's usage of 8182.

We really should fix both of these port users to be dynamic
but this fixes https://github.com/flutter/flutter/issues/3291
for now.

@yjbanov
 2016-04-13 11:22:38 -07:00
Adam Barth
d9b73a2b7a Improve docs about why we pin analyzer (#3254) 2016-04-12 12:42:14 -07:00
Devon Carew
8849cd6b2d add a --deploy flag to build apk (#3249) 
* add a --deploy flag to build apk

* update command description

* use an enum instead of a bool param for build variants

* rename buildForDeploy flag to buildVariant

* review comments
 2016-04-12 09:21:17 -07:00
Devon Carew
b4173e20d4 fix to showing a progress display for long tasks (#3265) 2016-04-12 08:39:24 -07:00
pq
f270c3d069 Migrate enable-strict-call-checks flag to options file. 
As per https://github.com/dart-lang/sdk/issues/25723, moves last command-line flag to `.analysis_options`.
 2016-04-11 14:05:44 -07:00
Phil Quitslund
9b2d2ad9d2 Merge pull request #3245 from pq/lint_fixes 
Analyze Command lint cleanup.
 2016-04-11 13:17:59 -07:00
pq
937f0eaf12 Analyze Command lint cleanup. 
The push to dev-4 allows us to cleanup a few more bits:
  * `api_docs` lint message special casing (lint fixed)
  * `allowedIdentifiersPattern` (lint fixed)
 2016-04-11 11:18:15 -07:00
Devon Carew
2a33e3f0c0 make flutter upgrade less verbose (#3237) 
* more terse flutter upgrade

* fix an issue when updating and the engine update code has changed

* call flutter precache; add a --no-color hidden option

* fix a lint related to getters/setters
 2016-04-11 11:17:09 -07:00
Devon Carew
7ad1e38eac Fix windows crash (#3236) 
* better messaging about windows support

* fix lints
 2016-04-11 08:34:01 -07:00
Devon Carew
26906240e5 fix an issue parsing adb devices (#3235) 2016-04-11 07:50:03 -07:00
stevemessick
8847b86681 Add validity checks to create (#3215) 
* Add validity checks to create

* Adjust indent
 2016-04-08 20:37:50 -07:00
Devon Carew
1311ae6ffe add a target for android-x64 (#3224) 
* add a target for android-x64

* update armeabi-v7a to x86_64
 2016-04-08 14:04:46 -07:00
Adam Barth
e456d86327 Update engine (#3214) 
Also, update hello_android to use the new Java class names.
 2016-04-08 10:25:41 -07:00
Devon Carew
c00d61f6ec have flutter precache print if there's no work to do (#3213) 
* have flutter precache print if there's no work to do

* tweak precache
 2016-04-08 10:25:30 -07:00
Devon Carew
750796846c move services to using cache.dart (#3211) 2016-04-08 10:23:47 -07:00
Adam Barth
65b36f131d Remove pub package version skew (#3212) 
We need to pin the version of package:analyzer we use to avoid version skew
within our project.
 2016-04-08 10:08:13 -07:00
Jason Simmons
f7b1799a62 Do not check for an existing package map if a command is going to run "pub get" to update the package map (#3202) 
Also remove a redundant check for the --pub option in the run command
 2016-04-08 09:34:42 -07:00
Adam Barth
412ce9d295 Add flutter precache (#3207) 
This command explicitly populates the flutter tool's cache of binary artifacts.
Also, teach `flutter create` to update the cache in case its the first command
that a user runs.
 2016-04-08 08:51:44 -07:00
Adam Barth
dd5831cb36 Run pub get if flutter_tools.stamp changes (#3206) 
This will help folks run pub get after they upgrade their flutter.git
revision.
 2016-04-08 07:19:25 -07:00
Seth Ladd
84acea3627 Make analyzer happy, remove incorrect instruction (#3181) 
Closes https://github.com/flutter/flutter/issues/3149



Closes https://github.com/flutter/flutter/issues/3148
 2016-04-07 14:03:49 -07:00
Devon Carew
a729b02f1a move the engine download code to dart (#3180) 
* move the engine download code to dart

* fix populating the bin/cache/pkg dir
 2016-04-07 13:31:44 -07:00
Jason Simmons
9d022ed26d Add a command that can capture a Skia picture of a Flutter frame and send it to a file or skiaserve debugger (#3165) 2016-04-07 12:33:11 -07:00
Devon Carew
34a67329fd use --no-precompile (#3175) 
* use --no-precompile

* use the flutter bin cache's sdk
 2016-04-07 11:06:38 -07:00
Devon Carew
40598449ad add cache.dart to help manage the cache dir (#3168) 
* add cache.dart to help manage the cache dir

* sp
 2016-04-07 09:15:58 -07:00
Devon Carew
2383d605cd add the dart vm version to flutter doctor 
* add the dart vm version to flutter doctor

* drop the dart vm change
 2016-04-06 15:11:54 -07:00
Devon Carew
39efe4afef have flutter build emit better help text 2016-04-06 14:29:54 -07:00
Ian Hickson
798dfa2bc9 Fix analyzer warnings 
Fix some legit uses of GlobalKey to specify the type they want.



Fix some sketchy uses of GlobalKey in tests to fake it with "as

dynamic".



Remove some extraneous imports that made the build red.
 2016-04-06 14:14:34 -07:00
Chinmay Garde
b930f0d4ff Update engine and temporarily get rid of custom build directories in flutter build ios 2016-04-06 12:55:48 -07:00
Chinmay Garde
0bf68cc5cb Merge pull request #3140 from chinmaygarde/master 
Add a `--no-codesign` option to `ios build` to disable code signing.
 2016-04-06 12:33:03 -07:00
Devon Carew
9a4c2c681f add a dev/dartdoc.dart script to generate docs for the packages/ packages 
* add a dev/dartdoc.dart script to generate docs for the packages/ packages

* remove description

* rename readme

* change to using --include-external

* move docs to dev/docs
 2016-04-05 12:33:12 -07:00
Devon Carew
e9a24510bd fast fail update-packages 2016-04-05 10:22:36 -07:00
Devon Carew
653566dd23 simplify toolchain setup 2016-04-04 13:10:56 -07:00
Ian Hickson
5291b37fc7 Track how many public Flutter members lack docs 
* Enable the lint require documentation.

* Track how many public Flutter members lack docs

* Rename the .analysis_options file

This makes Atom happier in the flutter_tools package.
 2016-04-04 12:18:13 -07:00
Jason Simmons
379c563b62 Merge pull request #3034 from jason-simmons/gradle_flx_refresh 
Support "flutter refresh" in the Gradle-based sample project
 2016-04-01 12:39:04 -07:00
Devon Carew
18d29583d0 pubspec normalization; remove den 2016-04-01 08:33:22 -07:00
Adam Barth
d645bc74d7 Be explicit about the theme in the starter app 
This gives developers a breadcrumb they can follow to customize the
theme of their app. Previously, some customers were trying to set a
theme by manually configuring the colors of all their widgets.

Fixes #2980
 2016-03-30 23:05:48 -07:00
Collin Jackson
040ff9b037 Merge pull request #3009 from collinjackson/services 
add services to schema
 2016-03-30 12:54:01 -07:00