mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
5047690b53
Fixes https://github.com/flutter/flutter/issues/74114 This PR addresses the issue detailed here: https://github.com/flutter/flutter/issues/74114 . The boolean isExpanded returned by the expansion panel callback now reflects the state of the panel that the user is seeing. If it's expanded on screen then the callback returns true. When you close the panel the callback returns false. When another panel is open and you open a different one, the callback executes twice. It returns isExpanded == false for the panel you are closing and true for the panel that is being opened. I had to change the code in a couple existing tests because some tests are using the old behavior of the callback. This PR addresses feedback listed in closed PR -> https://github.com/flutter/flutter/pull/127876 . The reasone the original PR is closed is that I was having some struggles with git. A couple of the commits in this PR are just reverts of commits I meant not to happen. Pre-launch Checklist [ X] I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview) and followed the process outlined there for submitting PRs. [ X] I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene) wiki page, which explains my responsibilities. [ X] I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement). [ X] I signed the [CLA](https://cla.developers.google.com/). [ X] I listed at least one issue that this PR fixes in the description above. I updated/added relevant documentation (doc comments with ///). [ X] I added new tests to check the change I am making, or this PR is [test-exempt](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests). [ X] All existing and new tests are passing. |
||
|---|---|---|
| .. | ||
| backdrop_demo.dart | ||
| banner_demo.dart | ||
| bottom_app_bar_demo.dart | ||
| bottom_navigation_demo.dart | ||
| buttons_demo.dart | ||
| cards_demo.dart | ||
| chip_demo.dart | ||
| data_table_demo.dart | ||
| date_and_time_picker_demo.dart | ||
| dialog_demo.dart | ||
| drawer_demo.dart | ||
| elevation_demo.dart | ||
| expansion_panels_demo.dart | ||
| expansion_tile_list_demo.dart | ||
| full_screen_dialog_demo.dart | ||
| grid_list_demo.dart | ||
| icons_demo.dart | ||
| leave_behind_demo.dart | ||
| list_demo.dart | ||
| material.dart | ||
| menu_demo.dart | ||
| modal_bottom_sheet_demo.dart | ||
| overscroll_demo.dart | ||
| page_selector_demo.dart | ||
| persistent_bottom_sheet_demo.dart | ||
| progress_indicator_demo.dart | ||
| reorderable_list_demo.dart | ||
| scrollable_tabs_demo.dart | ||
| search_demo.dart | ||
| selection_controls_demo.dart | ||
| slider_demo.dart | ||
| snack_bar_demo.dart | ||
| tabs_demo.dart | ||
| tabs_fab_demo.dart | ||
| text_form_field_demo.dart | ||
| tooltip_demo.dart | ||