Commit Graph

700 Commits

Author SHA1 Message Date
David Iglesias
c4aaa394ac
[tool][web] Create an early web plugin_registrant for dartpad. (#106921) 2022-07-02 00:51:06 +00:00
Loïc Sharma
6026eea9a4
[Windows] Flow version information to the build output (#106145)
Previously developers had to edit their `Runner.rc` file to update their executable's version information. Now, version information will automatically be set from `flutter build`'s arguments or the `pubspec.yaml` file for new projects. 

Addresses https://github.com/flutter/flutter/issues/73652
2022-06-27 10:45:56 -07:00
Brandon DeRosier
097c162cce
Fix .packages breakage and roll engine to 83b9a591a3d5 (#106584)
* 9508a368d Roll Dart SDK from 692562354d6d to d3b8091c30f0 (1 revision) (flutter/engine#34273)

* a2985c034 Roll Fuchsia Linux SDK from F1U6IH2Nf... to aRT7s0Yct... (flutter/engine#34251)

* 54867f360 Roll Skia from bdd0205ae470 to 4345a2ea731a (1 revision) (flutter/engine#34268)

* 98221a22d Clean up text input configuration in clearTextInputClient (flutter/engine#34209)

* b9e02cc83 Adds a license check shard to CI (flutter/engine#34274)

* 1daf7ba98 [Impeller] Metal:Reset Encoder viewport and scissor rect in case the command specifies no opinion (flutter/engine#34252)

* 83b9a591a [Linux] remove duplicate clone_string() in favor of g_strdup() (flutter/engine#34031)

* Don't use .packages

* Another attempt

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
2022-06-24 17:27:17 -07:00
Jesús S Guerrero
ddd493b927
[flutter_tools] migrate project-validate to analyze --suggestions (#106149) 2022-06-24 18:43:07 +00:00
Danny Tuppeny
e2ef8cfe44
Pass app.started events to the DAP client + dart.debuggerUris for Profile mode (#106337) 2022-06-21 12:09:06 -07:00
Jonah Williams
db829c1e20
[flutter_tools] migrate more unit tests to null safety (#106153) 2022-06-17 21:34:27 -07:00
Loïc Sharma
2efa2e44fe
Add integration test for flutter build windows (#106053)
Add an integration test that verifies that `flutter build windows` produces the expected executable. In the future, this will be used to test that version information is properly stamped on the executable.

Part of https://github.com/flutter/flutter/issues/73652.
2022-06-17 17:14:18 -07:00
Sam Rawlins
f104be7ae9
Ignore body_might_complete_normally_catch_error violations (#105795) 2022-06-16 23:12:06 +00:00
Lau Ching Jun
d30ad47eda
Make flutter attach respect the --dds-port flag. (#105560) 2022-06-09 13:03:09 -07:00
Nils Reichardt
64db621980
Remove new keyword in a few files (#104438) 2022-06-06 16:08:06 -07:00
jensjoha
9929446ea3
Extra timing on hot reload (#104242)
This PR adds extra timings for a hot reload.
As an example, before a user might see

> Performing hot reload...                                                
> Reloaded 1 of 788 libraries in 554ms.

With this PR it would instead be something like

> Performing hot reload...                                                
> Reloaded 1 of 788 libraries in 554ms (compile: 33 ms, reload: 153 ms, reassemble: 310 ms).
2022-06-03 08:41:14 +02:00
Gary Qian
c02be8cd47
Support string compileSdkVersion for preview android SDKs (#104662) 2022-05-31 13:08:09 -07:00
Danny Tuppeny
147020366a
Fix issues running integration tests through DAP debug adapter (#104618)
* Fix issues running integration tests through DAP

These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own. This change disables DDS in the DAP layer and leaves it to Flutter (although it passes `--no-dds` on to Flutter if provided to the DAP process).

Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because of a change/fix that now includes a 'vmServiceUri' in the `test.startedProcess` event.
2022-05-26 09:36:30 +01:00
Michael Goderbauer
3fa355c97d
Remove dead code in tools tests (#104567) 2022-05-25 12:48:17 -07:00
Jenn Magder
a56c5e51ae
Migrate some test files to null safety (#104469) 2022-05-24 16:53:08 -07:00
Jesús S Guerrero
336aa267f9
[flutter_tools] General info project validator (#103653) 2022-05-24 16:28:10 -07:00
Jonah Williams
9f28b83c19
[flutter_tools] migrate some integration tests to null safety (#103560) 2022-05-13 09:39:10 -07:00
David Iglesias
1af8cc1183
[tools][web] Make Plugin Registrant file ephemeral. (#102185) 2022-05-11 17:54:11 -07:00
Gary Qian
e997a3abd2
Add tests for migrate command methods (#103466) 2022-05-11 11:09:08 -07:00
Gary Qian
90a8b0561d
[flutter_tools] MigrateUtils and MigrateManifest classes (#101937) 2022-05-09 15:23:50 -07:00
Danny Tuppeny
4ab68bd04d
Use consistent date instead of DateTime.now() in evaluation tests (#103269) 2022-05-08 19:32:14 +01:00
Jenn Magder
c6ced845e3
Remove custom unawaited, prefer dart:async version (#103212) 2022-05-07 08:49:04 -07:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() (#103226) 2022-05-06 16:04:13 -07:00
Gary Qian
1b16d23747
Add debug logging to deferred components test for deflaking (#103161) 2022-05-06 02:39:08 -07:00
Jenn Magder
36be63ba19
Embed Flutter and App frameworks for add-to-app on iOS (#102538) 2022-05-02 10:44:12 -07:00
Phil Quitslund
b5e7fb076c
[flutter_tools] rename local functions with _s (#102688) 2022-04-27 16:19:07 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
Kaushik Iska
aeaeded715
Add VMService command to get frame rasterization metrics (#100696) 2022-04-14 13:44:05 -07:00
Christopher Fujino
fd5356ff60
[flutter_tools] shard out two integration tests we want to run on macOS arm64 (#101769) 2022-04-13 12:09:11 -07:00
Christopher Fujino
355fd23a79
[flutter_tools] add test for dart binary arch (#101604) 2022-04-11 16:28:37 -07:00
Danny Tuppeny
675b961573
Unpause and remove breakpoints when detaching from Flutter process with DAP (#101695) 2022-04-11 21:15:37 +01:00
Daco Harkes
85aac37ccf
Add more debugging info to android_plugin_example_app_build_test (#101685) 2022-04-11 08:24:09 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import (#101600) 2022-04-08 12:56:45 -07:00
creativecreatorormaybenot
96add4192e
Use single quotes for dartSdkVersionBounds (#101270)
* Use single quotes for `dartSdkVersionBounds`

* Update update_packages_test.dart

* Update test_project.dart

* Update tests_project.dart

* Update compile_error_project.dart

* Update hot_reload_with_asset.dart

* Update break_on_framework_exceptions_test.dart

* Update basic_project.dart
2022-04-06 09:54:10 -07:00
keyonghan
95f4f473ff
[Revert] Skip overall_experience_test.dart: flutter run writes and clears pidfile appropriately (#101267)
* restore test

* use seed 20211102

* restore seed
2022-04-04 13:26:27 -07:00
Michael Goderbauer
dcde8163ce
migrate to super params (#100509) 2022-03-31 11:46:47 -07:00
Gary Qian
ead5b1c2f4
Retire v1 embedding compatibility from automatic multidex support (#100685) 2022-03-31 10:24:42 -07:00
Jenn Magder
231c1a4b55
Pass ARCHS build setting to flutter assemble on macOS (#100811) 2022-03-28 10:55:14 -07:00
Alex Li
543a7e8588
Android Q transition by default (#100812) 2022-03-25 22:25:07 -07:00
Danny Tuppeny
b39a9473f8
Handle Flutter.Error events and disable structure errors for noDebug mode (#100149) 2022-03-17 16:05:21 -07:00
Gary Qian
63ff7a199b
MigrateConfig and migrate integration testing base (#99092) 2022-03-16 11:10:22 -07:00
Christopher Fujino
bb4a5fa7ab
[flutter_tools] exec rather than spawn subprocess from bin/internal/shared.sh (#99871) 2022-03-14 13:35:18 -07:00
Greg Spencer
fa68ecf7c6
Fix the race condition in cache_test.dart (#99423)
This fixes a race condition in test/integration.shard/cache_test.dart which allowed the test to fail if the machine took a very long time to acquire a lock or launch a process.
2022-03-03 12:55:47 -08:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint (#98753) 2022-02-22 14:39:20 -08:00
Jenn Magder
262a963efb
flutter_build_null_unsafe_test print failed build output (#98310) 2022-02-11 22:00:18 -08:00
Daco Harkes
bb3275b934
Add debugging info to android_plugin_example_app_build_test (#98107) 2022-02-09 09:20:13 -08:00
Emmanuel Garcia
d2b5f34bc4
Revert "Fix how Gradle resolves Android plugin" (#98050) 2022-02-08 12:30:05 -08:00
Emmanuel Garcia
965397cfde
Fix how Gradle resolves Android plugin (#97823) 2022-02-07 11:05:14 -08:00
Danny Tuppeny
c659ad6ace
Add support for attachRequest in DAP, running "flutter attach" (#97652)
* Add support for attachRequest in DAP, which runs "flutter attach"

* Update DAP docs for attachRequest

* Improve doc comments

* Fix comments

* Remove noDebug from attach + create a getter for `debug`

* Fix indent
2022-02-07 18:54:07 +00:00
Lau Ching Jun
d7688ca093
Change all instance of throwing strings to throw specific error classes. (#97325) 2022-02-02 10:45:18 -08:00
Collin Jackson
10fbbafe09
[flutter_tools] Use proper project name in templates (#96373) 2022-02-02 06:50:14 -08:00
Jenn Magder
a599c23b2b
Disallow running on unsupported devices (#97338) 2022-02-01 16:13:03 -08:00
Caio Agiani
29b44f79d9
packages: fix typos recieve => receive (#97488) 2022-01-31 08:43:15 -08:00
Danny Tuppeny
4fa0e0d449
Make DAP tests more tolerant of output that didn't come from the app being tested (#97291)
Fixes #97238.
2022-01-29 10:03:31 +00:00
Danny Tuppeny
942de67838
Make remaining DAP tests null-safe (#97368) 2022-01-27 20:08:17 +00:00
Daco Harkes
0e2f51dfd0
FFI plugins (#96225) 2022-01-26 23:44:45 +01:00
Zachary Anderson
657bca4b7f
[tool] Use an arm64 Dart SDK on arm64 macOS (#97189) 2022-01-26 11:30:20 -08:00
Alexander Aprelev
752de49450
Fix hot-restart test by ensuring updated timestmamp is in the future. (#97247)
On Windows modified timestamps are round down to a second, which can lead to missed file updates.

Fixes https://github.com/flutter/flutter/issues/96677
2022-01-25 14:18:33 -08:00
Christopher Fujino
6b95add2fe
[flutter_tools] auto-migrate dev users to beta (#97028) 2022-01-25 11:00:14 -08:00
Christopher Fujino
78de12b82f
[flutter_tools] Fix bug in background_isolate_test.dart (#97170) 2022-01-25 09:55:10 -08:00
Jesús S Guerrero
75127a8007
[flutter_tools] support files in flutter analyze #96231 (#97021) 2022-01-24 17:10:16 -08:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Danny Tuppeny
9d64e94a87
Fix SDK versions for Flutter packages in analyze tests (#96950)
Fixes https://github.com/flutter/flutter/issues/96931.
2022-01-20 14:40:42 -08:00
keyonghan
792a40ed83
Skip flaky test: background_isolate_test.dart: Hot restart kills background isolates (#96678) 2022-01-14 16:20:20 -08:00
Zachary Anderson
65c6e88223
Revert "FFI plugins (#94101)" (#96122)
This reverts commit 5257f0290c.
2022-01-04 08:09:12 -08:00
Daco Harkes
5257f0290c
FFI plugins (#94101)
* Building shared C source code as part of the native build for platforms Android, iOS, Linux desktop, MacOS desktop, and Windows desktop.
* Sample code doing a synchronous FFI call.
* Sample code doing a long running synchronous FFI call on a helper isolate.
* Use of `package:ffigen` to generate the bindings.
2022-01-04 10:14:27 +01:00
嘟囔
4f5cc21be2
migrate some file to null safety (#92957) 2021-12-16 11:39:12 -08:00
嘟囔
6d1938e647
migrate integration.shard/vmservice_integration_test.dart to null safety (#92812) 2021-12-15 13:09:15 -08:00
Jenn Magder
6ab00756a8
Build Flutter iOS plugins with all valid architectures (#95293) 2021-12-14 16:49:06 -08:00
Lau Ching Jun
8186fb7435
Use XML format in PlistParser (#94863)
* Switch to use xml in PlistParser

* Review feedbacks: Change dynamic to Object, remove getValueFromFile
2021-12-13 18:22:29 -08:00
Anna Gringauze
d7466d8963
Update dwds and other packages (#94634) 2021-12-07 14:29:07 -08:00
Danny Tuppeny
b865e23aeb
Don't treat stderr output as failures during DAP test teardown (#94335) 2021-12-01 07:19:04 -08:00
Anna Gringauze
ca62470796
De-flake web tool tests (#93948) 2021-11-30 17:39:05 -08:00
Nate Bosch
6d1a840bc5
Roll packages, remove unnecessary overrides (#94172) 2021-11-24 14:43:05 -08:00
Danny Tuppeny
77fca35877
[DAP] Add a custom event to pass flutter.serviceExtensionStateChanged… (#93870) 2021-11-22 20:12:33 -08:00
Tarekk Mohamed Abdalla
fae84f6714
[gen_l10n] Add support for adding placeholders inside select (#92753) 2021-11-22 20:08:03 -08:00
Andrei Diaconu
924336fcee
Reland 3: Display Features (#93240) 2021-11-20 15:48:06 -08:00
Danny Tuppeny
99e85b1c5f
Disable pause-on-exceptions for (outgoing) isolates during hot restart (#93411) 2021-11-18 22:23:09 -08:00
Jenn Magder
e56c83a1ac
Migrate build_system targets to null safety (#92869) 2021-11-17 16:31:37 -08:00
Greg Spencer
52ae102f18
Adds tool warning log level and command line options to fail on warning/error output (#92031) 2021-11-10 16:13:04 -08:00
Camille Simon
977c35307f
Add warning for bumping Android SDK version to match plugins (#92451) 2021-11-09 12:58:07 -08:00
Zachary Anderson
2468f315e0
Revert "Reland: display features (#93117)" (#93204)
This reverts commit 9038fac960.
2021-11-06 22:46:46 -07:00
Andrei Diaconu
9038fac960
Reland: display features (#93117) 2021-11-05 15:54:25 -07:00
Emmanuel Garcia
15d0a8be1c
Pin to specific plugin version in multidex test (#93148) 2021-11-05 11:17:32 -07:00
Zachary Anderson
7779ad3c60
Revert "Reland engine display features (#89511)" (#93098)
This reverts commit 058dfd49a0.
2021-11-04 23:05:45 -07:00
Andrei Diaconu
058dfd49a0
Reland engine display features (#89511) 2021-11-04 18:37:55 -07:00
keyonghan
71e38aaa07
Skip overall_experience_test.dart: flutter run writes and clears pidfile appropriately (#93026) 2021-11-03 16:06:34 -07:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart (#92861) 2021-11-01 17:18:03 -07:00
嘟囔
38b0389121
feat: mirgate test_data/compile_error_project.dart to null safety (#92808) 2021-11-01 17:13:05 -07:00
嘟囔
bd935e5d4f
feat: migrate test_data/project.dart to null safety (#92646) 2021-10-29 11:38:05 -07:00
Danny Tuppeny
57dbf7f7e7
Add support for running tests through debug-adapter (#92587)
* Add support for running tests through debug-adapter

* Improve comments about stdout + remove pedantic
2021-10-28 11:34:05 +01:00
Danny Tuppeny
de966d8a49
Add a "flutter debug_adapter" command that runs a DAP server (#91802) 2021-10-27 06:48:06 -07:00
Christopher Fujino
44bf975115
remove Downloading ... stderr messages (#92211) 2021-10-20 17:13:02 -07:00
Jenn Magder
305a855f6d
Migrate integration test shard test data to null safety (#92147) 2021-10-20 14:58:05 -07:00
Gary Qian
0407aa4480
Reland "Add multidex flag and automatic multidex support (#90944)" (#92049) 2021-10-19 02:20:39 -07:00
Emmanuel Garcia
d7631275fe
Bump targetSdkVersion to 31 and organize static values (#91719) 2021-10-15 13:41:48 -07:00
Zachary Anderson
a9c31eca48
Revert "Add multidex flag and automatic multidex support (#90944)" (#91791)
This reverts commit 1d9edde079.
2021-10-13 23:09:50 -07:00
Gary Qian
1d9edde079
Add multidex flag and automatic multidex support (#90944) 2021-10-13 17:48:04 -07:00
Danny Tuppeny
5fd1d36ecc
Limit 10 second future modification-date in integration test to only where required for reloads (#91300)
This prevents all of the `flutter run` calls immediately re-running `flutter pub get` when it has already been run by test setup code.
2021-10-13 10:44:55 +01:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. (#91444) 2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. (#91332)" (#91438)
This reverts commit cb378edc9e.
2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. (#91332) 2021-10-07 09:53:03 -07:00
Littlegnal
1b73a35fba
Change project.buildDir in standalone subprojects property (#91030) 2021-10-01 17:18:05 -07:00
Ian Hickson
4315cdcf76
Some test cleanup for flutter_tools. (#90227) 2021-10-01 10:38:02 -07:00
Jason Simmons
2004afae06
Use async timeline events for the phases of the scheduler binding (#88825) 2021-09-10 10:17:05 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos (#89485) 2021-09-07 14:56:04 -07:00
Sigurd Meldgaard
bce366203a
Stop calling top level pub (#89032)
* Use `dart __deprecated_pub` instead of `pub` to invoke pub from tools

The top level `pub` commmand has been deprecated and will print
a message. It is however implemented via the __deprecated_pub command
that prints no message.
2021-08-30 10:40:10 -07:00
Zachary Anderson
cff3db1d8e
Account for additional warning text from the tool (#88902) 2021-08-25 14:55:42 -07:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos (#88707) 2021-08-23 12:27:07 -07:00
Ian Hickson
9f9aa46b7d
Update the timeouts since tests time out after 15 minutes not 30 seconds. (#88061) 2021-08-20 12:52:03 -07:00
Hans Muller
afe58fbab5
Revert "Reland "Android Q transition by default (#82670)" (#88409)" (#88482) 2021-08-18 20:22:04 -07:00
Jenn Magder
563c8f43e3
Verbosify every command in ios_content_validation_test (#88404) 2021-08-18 10:42:02 -07:00
Alex Li
df399f9a8d
Reland "Android Q transition by default (#82670)" (#88409)
* Reland "Android Q transition by default (#82670)"

This reverts commit 4053b4b16c.

* Fix `overall_experience_test.dart` for flutter_tools
2021-08-18 09:11:27 -07:00
Anna Gringauze
831d82c8ea
Fix race conditions in test_driver for tool tests (#88322) 2021-08-17 18:37:04 -07:00
Ian Hickson
7bedd0f122
Fix incorrect logging. (#88042) 2021-08-12 15:32:06 -07:00
Darren Austin
b08366ce7b
Updated skipped tests for flutter_tools. (#87925)
* Updated skipped tests for flutter_tools.

* Turned the flaky overall_experience test off as it was still failing on CI.
2021-08-10 22:22:08 -07:00
keyonghan
c5f4f58640
Skip flaky test debugger_stepping_test (#87670) 2021-08-04 12:20:04 -07:00
Anna Gringauze
33fd4f15a9
Fix race causing null dereference on getStack in web_tool_tests and CI flakes (#87278) 2021-07-29 16:59:02 -07:00
Greg Spencer
0bab3604b0
Make the startup lock message print to stderr. (#86520)
This changes the "Waiting for another flutter command to release the startup lock..." message output so that it appears on stderr instead of stdout. When it appears on stdout, it can mess up collection of the output. For instance, if you run flutter --version --machine and you're expecting JSON output, then you'll get non-JSON output even though the lock is released and you eventually would get what you're asking for.
2021-07-28 15:12:03 -07:00
Christopher Fujino
2d07436dbd
[flutter_tools] Port xcode backend to dart (#86753) 2021-07-27 14:39:05 -07:00
Greg Spencer
738ce43d97
Randomize tests, exclude tests that fail with randomization. (#86793)
* Randomize tests, exclude tests that fail with randomization.

* Disable some more tool tests
2021-07-26 23:40:49 -07:00
Jenn Magder
6881fca7b7
Respect plugin excluded iOS architectures (#86905) 2021-07-23 13:56:03 -07:00
Jonah Williams
7f26dbe0d4
[flutter] remove elevation checker (#86837) 2021-07-21 21:51:06 -07:00
Ahmed Ashour
f568d929db
[gen_l10n] Support plurals and selects inside string (#86167) 2021-07-21 12:41:06 -07:00
Zachary Anderson
8642a9c0f7
Quote arguments to flutter assemble in xcode_backend.sh (#86534) 2021-07-16 18:22:10 -07:00
Jonah Williams
b549e829e8
[flutter_tools] support trailing args (#86431) 2021-07-14 15:51:10 -07:00
Ian Hickson
1133921c4d
Add more debugging logs to overall_experience_test (#86368) 2021-07-13 16:56:06 -07:00
Jonah Williams
63a4013160
Revert "[flutter_tools] let the logger know about machine mode (#86116)" (#86363)
This reverts commit 53d8cba3ec.
2021-07-13 10:39:35 -07:00
Ian Hickson
d3c17acf9d
Run "pub global activate devtools" before overall_experience_test (#85812) 2021-07-12 14:36:05 -07:00
Jonah Williams
53d8cba3ec
[flutter_tools] let the logger know about machine mode (#86116) 2021-07-12 10:41:03 -07:00
Jonah Williams
7a0b4669fc
[flutter_tools] switch web integration tests to use html (#85325) 2021-07-12 09:01:04 -07:00
Ahmed Ashour
ef9da62325
Fix typo in test name (#86083) 2021-07-09 11:16:03 -07:00
Ahmed Ashour
a666925a02
Add newline at end of file (#86008) 2021-07-08 15:01:10 -07:00
Zachary Anderson
53125203ea
[flutter_tool] Pin DevTools to 2.4.0 (#86124) 2021-07-08 15:01:00 -07:00
Jonah Williams
b1b0d20a95
[flutter_tools] revert change to SETLOCAL ENABLEDELAYEDEXPANSION (#86000) 2021-07-07 11:10:37 -07:00
Ahmed Ashour
529a599ce6
Fix some indentation (#84967) 2021-07-01 13:41:04 -07:00
Filip Hracek
76d5e62f42
Add a more complete app template for Flutter (skeleton) (#83530) 2021-06-28 15:26:04 -07:00
Jonah Williams
d5c842c09e
[flutter_tools] make analyze once an integration test (#85336) 2021-06-25 12:06:04 -07:00
Jonah Williams
f04508a426
[flutter_tools] dont use SETLOCAL ENABLEDELAYEDEXPANSION unecessarily (#85288) 2021-06-24 22:21:01 -07:00
Jenn Magder
0de6bd41ba
Migrate iOS app deployment target from 8.0 to 9.0 (#85174) 2021-06-24 10:21:05 -07:00
chunhtai
50a2fad986
Remove namesless todo (#85151) 2021-06-23 14:29:14 -07:00
Greg Spencer
88f3811055
Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. (#84476)
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.

Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
2021-06-14 14:16:57 -07:00
Jenn Magder
80668d20f8
Fix assemble codesign flag (#84372) 2021-06-11 11:35:00 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors (#83744) 2021-06-02 10:14:06 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings (#83407) 2021-06-01 11:14:06 -07:00
Lau Ching Jun
fdb1fb184d
Add MultiRootFileSystem to better support using --filesystem-root. (#82991) 2021-05-24 22:04:02 -07:00
Jonah Williams
a217ab601a
[flutter_tools] remove getLocalEngineArtifacts from integration tests that cant use it (#83282) 2021-05-24 16:39:03 -07:00
Michael Goderbauer
c04f0a2b69
Enable vm:notify-debugger-on-exception for LayoutBuilder (#82835) 2021-05-21 18:39:13 -07:00
Jenn Magder
0d79013a81
Move globals.artifacts to globals_null_migrated, update imports (#83137) 2021-05-21 18:35:02 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint (#81153) 2021-05-19 09:54:02 -07:00
Jenn Magder
25c10d6a1c
Replace testUsingContext with testWithoutContext in a few places (#82498) 2021-05-13 23:09:03 -07:00
Jia Hao
08154b22ce
Revert "Init licenses for test bindings (#81961)" (#82337) 2021-05-13 21:29:03 -07:00
Michael Goderbauer
adb3f13819
Enable vm:notify-debugger-on-exception on handlePlatformMessage (#81987) 2021-05-13 11:54:04 -07:00
godofredoc
8eca86de9e
Revert "Disable flutter_build_with_compilation_error_test on Windows (#81951)" (#82401)
This reverts commit 577f5eb06c.
2021-05-13 10:48:45 -07:00
Kenzie Schmoll
766b4509c6
Add 'v' hotkey to open DevTools in the browser (#82227)
* Add 'v' hotkey to open DevTools in the browser
2021-05-13 09:54:10 -07:00
Jason Simmons
258158774e
Activate DevTools before running an integration test that uses DevTools (#82393) 2021-05-12 17:13:04 -07:00
Jia Hao
b3f7ebe069
Init licenses for test bindings (#81961) 2021-05-07 17:54:02 -07:00
Zachary Anderson
577f5eb06c
Disable flutter_build_with_compilation_error_test on Windows (#81951)
For https://github.com/flutter/flutter/issues/81837

https://github.com/flutter/flutter/issues/81950 to re-enabled
2021-05-05 21:25:51 -07:00
Ian Hickson
33b183e6c9
Fix extra blank lines in logger output (#81607) 2021-05-03 09:19:02 -07:00
Jonah Williams
2d711b8213
[flutter_tools] skip additional flaky test (#81555) 2021-04-30 17:59:03 -07:00
Michael Goderbauer
1b4f4482b7
Skip test that is not reliable on devicelab (#81509) 2021-04-29 14:55:33 -07:00
Ian Hickson
0021a08c4d
Always activate DevTools if it's not installed (#81242) 2021-04-28 17:14:02 -07:00
Ian Hickson
6beafa7b16
Apply style guide regarding createTempSync pattern (#81090) 2021-04-27 14:59:03 -07:00
Ian Hickson
a7eb2c8a1a
Use "aliases" in args to fix some technical debt (#81073) 2021-04-27 14:54:03 -07:00
Jenn Magder
8d3bc1846f
Migrate analyze_size to null safety (#81002) 2021-04-26 16:46:14 -07:00
Michael Goderbauer
a717e151b9
Enable vm:notify-debugger-on-exception for more use cases enabled by upstream fix (#81221) 2021-04-26 13:10:04 -07:00
Ian Hickson
f534aa0043
Fix race condition in overall_experience_test (#81091) 2021-04-26 11:29:03 -07:00
Ian Hickson
e5414695d4
Change --disable-dds to --no-dds to avoid double negatives (#80900)
Also, refactor internal code to do the same.

See https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-double-negatives-in-apis
2021-04-23 16:29:38 -07:00
Ian Hickson
598737adf2
Clean up the command line tool interactive help output. (#80903) 2021-04-22 19:34:02 -07:00
Jonah Williams
b30d97a64c
[flutter_tools] split host artifacts out of Artifacts (#80876) 2021-04-22 19:29:02 -07:00
Jonah Williams
d9638d25d7
migrate from jcenter to mavencentral (#80908) 2021-04-21 21:41:07 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Michael Goderbauer
2a8dba4af6
Treat some exceptions as unhandled when a debugger is attached (#78649) 2021-04-15 10:49:02 -07:00
Dan Field
0b65330199
Add an option to specify the output for code size intermediate files (#80310) 2021-04-13 14:09:04 -07:00
Jonah Williams
b7214a9a43
[flutter_tools] fix null check in crash reporter (#80382) 2021-04-13 14:04:25 -07:00
Jenn Magder
ed5b8febf2
Move gradle_non_android_plugin_test from its own test builders into tools integration.shard (#80161) 2021-04-13 13:53:50 -07:00
Jenn Magder
e29595d4b6
Remove crash_reporting and github_template from reporting library (#80139) 2021-04-09 15:24:15 -07:00
Jonah Williams
2bada6097b
[flutter_tools] add timeline ANR integration test (#79991) 2021-04-08 15:23:11 -07:00
Jenn Magder
b2afbd2f9c
Use testUsingContext in downgrade_upgrade_integration_test (#79975) 2021-04-07 22:20:24 -07:00
Jenn Magder
a2f67720ef
Migrate test/src/common to null safety (#79907) 2021-04-06 22:55:03 -07:00
Jenn Magder
ba764ebc38
Update Podfile.lock modified timestamp when pod install is run (#78823) 2021-04-06 15:54:02 -07:00
Ben Konyi
75a44a29ad
[ Web ] Register service extensions with DDS, not DWDS (#79479) 2021-04-02 18:19:04 -07:00
Sam Rawlins
288b94115d
Remove "unnecessary" imports. (#78666) 2021-04-01 19:59:03 -07:00
Jenn Magder
8ddc27e607
Split globals.dart into null sound and unsound libraries (#79016) 2021-03-31 16:55:20 -07:00
Jia Hao
9e3eadb98d
[flutter_tools] Support Integration Tests (#76200) 2021-03-30 19:29:02 -07:00
Michael Thomsen
2cdd51900c
Enable null safety by default in templates (#78619) 2021-03-30 10:16:05 +02:00
Jonah Williams
430626d0f3
[flutter_tools] use existing service implementations for web (#78995) 2021-03-29 21:44:03 -07:00
Jonah Williams
2eabb17215
[flutter_tools] migrate tool_backend.dart to null safety and add testing of exit conditions (#78988) 2021-03-24 15:23:21 -07:00
Jenn Magder
2e06ed0787
Add test for dart compilation error build output (#78381) 2021-03-19 15:33:46 -07:00
Michael Goderbauer
197b440e96
Migrate out custom ignore syntax to flutter_ignore (#78497) 2021-03-19 15:33:05 -07:00
Michael Goderbauer
a7e3b1a35d
Clean up ignores that are not ignoring anything (#78493) 2021-03-19 15:32:46 -07:00
Jenn Magder
d0a29dc10c
Allow local networking Info.plist insertion to fail (#78085) 2021-03-13 14:38:02 -08:00
Ahmed Saleh
740504d3e6
Refactor: use one subprojects property (#77942) 2021-03-12 16:28:03 -08:00
Jonah Williams
9f420ffb3e
[flutter_tools] io cleanups to simplify null safety migration (#77955) 2021-03-12 16:21:14 -08:00
Gary Qian
4d38ca6d46
Increase timeouts to fix build integration timeout flakes (#77566) 2021-03-10 12:30:25 -08:00
Jenn Magder
7b1aec70ae
Move iOS codesigning into assemble build target (#77664) 2021-03-09 11:45:16 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Gary Qian
ee41782732
[flutter_tools] Deferred components build system (#76192) 2021-03-04 18:09:02 -08:00
Jenn Magder
42c9e276d8
Increase dart migrate integration test timeout (#77192) 2021-03-03 18:58:52 -08:00
Jenn Magder
eee0dc8441
Exclude arm64 from valid iOS simulators (#73828) 2021-03-03 18:58:37 -08:00
Jenn Magder
3969e5b47b
Move iOS Flutter.framework thinning into copy assemble build target (#77007) 2021-03-01 15:45:02 -08:00
Jenn Magder
5bc100da31
Move iOS framework thinning into the tool (#76665) 2021-02-24 18:02:43 -08:00
Sam Rawlins
e43738824e
Remove unused imports of system libraries. (#76436) 2021-02-24 08:41:03 -08:00
Jia Hao
9e55af5246
[flutter_tools] Decouple FlutterPlatform from Process (#74236) 2021-02-17 10:06:04 -08:00
Ian Hickson
ce318b7b53
All arguments must be documented. (#75888) 2021-02-14 12:56:05 -08:00
Jonah Williams
bf132435e2
[flutter_tools] delete exit immediately test (#75927) 2021-02-12 15:28:24 -08:00
Jonah Williams
fb808b40f9
[flutter_tools] add package:http to forbidden imports test (#75925) 2021-02-12 14:23:08 -08:00
Ian Hickson
b1cc48748d
Only write the pid-file while listening to SIGUSR signals. (#74533) 2021-02-10 16:06:05 -08:00
Sam Rawlins
e8d52be500
Remove "unnecessary" imports in flutter_tools tests (#75012) 2021-02-09 09:46:07 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool (#75350)" (#75639)
This reverts commit 8b6baae44c.
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool (#75350)
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Dan Field
bc1cf49458
roll packages (#75370) 2021-02-04 11:41:03 -08:00
Shi-Hao Hong
16913b07e8
Relands "[gen-l10n] Fixes named and positional parameter issue with NumberFormat when type is specified" (#75346)
*  Added a new template for [NumberFo
rmat] with positional parameter(s)

* 🔨 Renamed [numberFormatTemplate] to [numberFormatNamedTemplate]

* [gen-l10n] Fixed generation error for namedParameters and optionalParameters

* [gen-l10n] Fixed string value generation for optional parameter

* [gen-l10n-test] Added new tests for `decimalPattern`, `percentPattern`, `scientificPattern` and formats with optional parameters.

* 🔨 Removed trailing whitespaces

* 🔨 replaced [_generateStringParameterValue] with [generateString]

* 🔨 Specified variable types in NumberFormat templates.

*  Added a new template for [NumberFo
rmat] with positional parameter(s)

* 🔨 Renamed [numberFormatTemplate] to [numberFormatNamedTemplate]

* [gen-l10n] Fixed generation error for namedParameters and optionalParameters

* [gen-l10n] Fixed string value generation for optional parameter

* [gen-l10n-test] Added new tests for `decimalPattern`, `percentPattern`, `scientificPattern` and formats with optional parameters.

* 🔨 Removed trailing whitespaces

* 🔨 replaced [_generateStringParameterValue] with [generateString]

* 🔨 Specified variable types in NumberFormat templates.

* [gen-l10n]  added test for parameter having special characters in string value.

* Accidental tab added to integration test

Co-authored-by: arish <arishsultan104@gmail.com>
2021-02-04 03:31:22 +08:00
Shi-Hao Hong
c12b53e073
Revert "[gen-l10n] Fixes named and positional parameter issue with NumberFormat when type is specified (#75209)" (#75306)
This reverts commit 917577b808.
2021-02-03 10:32:01 +08:00
Shi-Hao Hong
917577b808
[gen-l10n] Fixes named and positional parameter issue with NumberFormat when type is specified (#75209) 2021-02-02 17:06:05 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. (#74832)
* opt out the flutter tool

* oops EOF

* fix import

* Update tool_backend.dart

* Update daemon_client.dart

* fix more
2021-01-27 15:17:53 -08:00
Dan Field
d1538320d2
Roll packages to null safe (vm_service, test, etc.) (#74671) 2021-01-26 09:15:54 -08:00
Jia Hao
22f1700427
[flutter_tools] Make setting of CWD consistent for flutter test (#74622) 2021-01-25 22:34:03 -08:00
Jenn Magder
754bc4a594
Move android_plugin_example_app_build_test from devicelab to tool integration tests (#74685) 2021-01-25 19:23:53 -08:00
Kenzie Schmoll
c89d649847
Add connectedVmServiceUri service extension and set from flutter_tools (#74534)
* Add connectedVmServiceUri service extension and set from flutter_tools
2021-01-25 10:40:14 -08:00
Jonah Williams
fa0880c309
[flutter_tools] test toggle debugPaintsize (#74464) 2021-01-22 18:11:37 -08:00
Kenzie Schmoll
b45088c0cf
Print DevTools inspector links in RenderFlex Overflow errors (#74251) 2021-01-21 02:59:04 -08:00
Jenn Magder
57d695a5df
Skip flutter_immediately_exit_test (#74359) 2021-01-20 15:07:37 -08:00
Sigurd Meldgaard
178c87cc27
Avoid relative paths in .dart_tool/package_config.json when generate:true (#73944)
Instead of using package:package_config to write the .dart_tool/package_config the original json is modified and rewritten.

The .dart_tool/package_config.json file is read twice to simplify control flow.

This also avoids the issue of package:package_config writing directly to local filesystem.
2021-01-20 14:53:49 +01:00
Michael Goderbauer
cd57af1458
Tests that module/plugin/package templates can be migrated to null-safety (#74090) 2021-01-19 14:24:03 -08:00
Jonah Williams
a0be98020e
[flutter_tools] ensure pub get can run from partially valid state (#74249) 2021-01-19 12:29:07 -08:00
Jonah Williams
97e82d791b
[flutter_tools] verify successful dart migrate (#74079) 2021-01-15 17:09:04 -08:00
Dan Field
6a32859eb9
Revert integration_test in flutter create template (#74068)
* Revert "Add integration_test template to create template (#70240)"

This reverts commit d047d108eb.

* test
2021-01-15 13:13:46 -08:00
Jenn Magder
5830121106
Skip flaky flutter_immediately_exit test (#74055) 2021-01-15 11:12:24 -08:00
Jenn Magder
f63055a895
Revert "Exclude arm64 from valid iOS simulators (#73755)" (#73807)
This reverts commit 201e5e4ecb.
2021-01-12 13:02:46 -08:00
Jenn Magder
201e5e4ecb
Exclude arm64 from valid iOS simulators (#73755) 2021-01-12 10:35:24 -08:00
Jenn Magder
062022b950
Move ios_content_validation_test to pre-submit tools test (#73577) 2021-01-11 10:29:06 -08:00
Jenn Magder
f596fdc008
Revert "Exclude arm64 from valid iOS simulators (#73458)" (#73511)
This reverts commit 273630c09d.
2021-01-07 14:06:32 -08:00
Jenn Magder
273630c09d
Exclude arm64 from valid iOS simulators (#73458) 2021-01-07 13:03:52 -08:00
Shi-Hao Hong
a912030982
[gen_l10n] Use l10n.yaml file instead of command line arguments if it exists (#72950)
* Reorganize files

* Use l10n.yaml instead of command line args
2021-01-05 11:50:32 +08:00
Jenn Magder
f08b1ae637
Avoid broken symlinks in embedded Flutter frameworks (#73052) 2020-12-28 14:39:02 -08:00
Jenn Magder
7aacff2216
Exclude ARM from macOS builds (#72748) 2020-12-21 16:05:24 -08:00
Jenn Magder
1c18cf3da8
Move macOS Podfile logic into the tool (#72020) 2020-12-17 11:48:16 -08:00
creativecreatorormaybenot
9ff4326e1f
Test generated_plugin_registrant analysis & suppress long lines in web plugin registrant (#71981) 2020-12-16 22:19:05 -08:00
Sam Rawlins
0dc80621eb
Return null instead of empty in Future.catchError callbacks (#72409) 2020-12-16 10:38:04 -08:00
Kenzie Schmoll
94a30ddcbb
Add text to --analyze-size command output to launch DevTools with size data (#72295)
* Add text to --analyze-size command output to launch DevTools with size data.
2020-12-15 11:06:10 -08:00
Jenn Magder
a48a57d369
macos_content_validation_test integration test (#72114) 2020-12-11 13:52:02 -08:00
Dan Field
02eab12fd3
Reland "Add integration_test template to create template (#70240)" (#71660)" (#71740) 2020-12-07 13:38:03 -08:00
Jonah Williams
afb6b95593
[flutter_tool] fix incorrect coverage file generation (#71726) 2020-12-04 11:15:11 -08:00
Kate Lovett
8e05e59c29
Revert "Add integration_test template to create template (#70240)" (#71660)
This reverts commit d047d108eb.
2020-12-03 09:54:28 -06:00
Jonah Williams
81e1f7d1ed
[flutter_tools] mode code size output to ~/.flutter-devtools (#71601) 2020-12-02 17:19:57 -08:00
Dan Field
d047d108eb
Add integration_test template to create template (#70240) 2020-12-02 17:08:03 -08:00
Emmanuel Garcia
8dd0de7f58
Relands: Migrate template to Gradle 6.7 and AGP 4.1.0 (#71446) 2020-12-01 19:01:09 -08:00
Amir Hardon
7df04fdbd3
Revert "Migrate template to Gradle 6.7 and AGP 4.1.0 (#70808)" (#71096)
This reverts commit 8e73bab94c.
2020-11-23 12:27:36 -08:00
Emmanuel Garcia
8e73bab94c
Migrate template to Gradle 6.7 and AGP 4.1.0 (#70808) 2020-11-20 13:05:35 -08:00
Jenn Magder
c2d1203f26
Remove deprecated 'flutter build aot' (#70898) 2020-11-20 10:46:12 -08:00
Jonah Williams
f4e79e6828
[flutter_tools] add support for dart defines to flutter test (#70791) 2020-11-18 14:52:49 -08:00
Jenn Magder
e26c7f98ff
Force regeneration of old Podfile (#70735) 2020-11-18 13:33:04 -08:00
Shi-Hao Hong
94ca7b4ad2
[gen-l10n] NNBD generated code (#70415)
* NNBD gen-l10n generated code
2020-11-18 10:14:38 +08:00
Ben Konyi
f6bedddd9f
Support legacy behavior for --host-vmservice-port and --observatory-port with DDS (#70336)
Implements the following:
  - If both --host-vmservice-port and --dds-port are specified, use the current behavior
  - If only --host-vmservice-port is specified and dds is enabled, use that for the dds port
  - If only --dds-port is specified, use that for the dds port

Fixes https://github.com/flutter/flutter/issues/70332
2020-11-17 16:03:02 -08:00
Jonah Williams
0c79659900
[flutter_tools] make most integration tests null safe (#70334) 2020-11-12 10:23:03 -08:00
Anna Gringauze
edf26e756d
Move web integration tool tests to web.shard (#70226)
* Move web integration tool tests to web.shard

Web integration tool tests depend on DDC changes in SDK. This change
moves them to a separate shard and subshard so CI bot configurations
can run them separately.

In particular, with will allow running those tests on dart CI flutter
HHH web bot instead of a non-web one, allowing early detection and easy
classification of issues caused by SDK changes as VM- or Web related.

* Enabled verbose mode for flaky web_tool_tests

* Split out the test changes to be commited first
2020-11-11 15:42:15 -08:00
Emmanuel Garcia
21e802746b
Migrate Flutter Gallery test to null safety (#70116) 2020-11-09 12:29:14 -08:00
Michael Thomsen
168ad5dc4d
Roll engine and fix pubspecs that do not have a Dart SDK constraint (#70078) 2020-11-09 19:02:10 +01:00
Michael Thomsen
e4d94f7ccd
Revert "Migrate Flutter gallery test to null safety (#69048)" (#70023)
This reverts commit 7ba775a994.
2020-11-07 12:15:22 +01:00
Emmanuel Garcia
7ba775a994
Migrate Flutter gallery test to null safety (#69048) 2020-11-06 20:38:12 -08:00
Jonah Williams
a3f6ea6f38
[flutter_tools] split web integration tests into new shard (#69914) 2020-11-05 17:21:44 -08:00
Dan Field
cfcb9887c9
Do not use --first-parent when determining version on master (#69726) 2020-11-05 10:11:32 -08:00
Jonah Williams
7ceb20417c
disable hot reload web tests on CI due to flakes (#69802) 2020-11-04 12:36:33 -08:00
Anna Gringauze
5034d57546
Disable web expression evaluation tests (#69728)
Temporarily disable web expression evaluation tests,
until we figure out how to disable the only on non-web bot.
2020-11-03 23:36:54 -08:00
Jonah Williams
9383ec793b
mark flaky tests as flaky (#69633) 2020-11-02 18:15:20 -08:00
Jonah Williams
8291f4810f
[flutter_tools] add canvaskit hot reload integration test (#69550) 2020-11-02 10:40:46 -08:00
Shi-Hao Hong
4996f60b20
[gen_l10n] Fix unintended use of raw string in generateString (#69382)
* Fix failing tests from introducing raw string generation in gen_l10n tool
2020-10-31 19:24:53 +08:00
Jonah Williams
324b78eb12
[null-safety] enable null safety (#69440)
* [null-safety] enable null safety

* opt expression evaluation web test out of null safety
2020-10-30 15:26:22 -07:00
Shi-Hao Hong
7b0f38b117
Remove intl_translation from tool integration test (#69155) 2020-10-29 14:05:39 -07:00
Jonah Williams
470346f775
[flutter_tools] Reland: Stage web tests (#69264)
Enable web tool integration tests: expression evaluation, stepping, and basic hot restart
2020-10-29 09:56:28 -07:00
Jonah Williams
2ceb34e6fb
Revert "[flutter_tools] enable web integration tests (#69114)" (#69261)
This reverts commit d0cdfa4176.
2020-10-28 18:22:41 -07:00
Jonah Williams
d0cdfa4176
[flutter_tools] enable web integration tests (#69114)
* [flutter_tools] stage web integration tests
2020-10-28 17:31:44 -07:00
Alexandre Ardhuin
17cdf5559d
enable unnecessary_string_escapes and use_raw_strings (#68302) (#69025) 2020-10-26 12:42:05 -07:00
Jonah Williams
183fe75d58
[flutter_tools] reland: drive service (#68887)
Overhaul of flutter drive in order to deliver a better experience, namely:

* flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
* Removes web-initialize-platform as this is no longer used
* flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
* VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)

Web changes

* Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-26 10:11:30 -07:00
Jonah Williams
cb67513f29
[flutter_tools] Reland: simplify pub cache logic (#67589)
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.

Also takes an opportunity to fix the kernel snapshot depending on the .packages or package_config. Due to the generated: date field this causes extra rebuilds. Instead when pub get is run, write out an additional file with just the package contents and version.

Fixes #66777
Fixes #65723
2020-10-23 10:00:56 -07:00
Jonah Williams
1edec6fc20
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845)
This reverts commit 2e75f52ae4.
2020-10-22 19:39:33 -07:00
Jonah Williams
2e75f52ae4
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)
Overhaul of flutter drive in order to deliver a better experience, namely:

flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
Removes web-initialize-platform as this is no longer used
flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)
Web changes

Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-22 15:07:02 -07:00
Zachary Anderson
cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings (#68302)" (#68714)
This reverts commit ae06c19a37.
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin
ae06c19a37
enable unnecessary_string_escapes and use_raw_strings (#68302) 2020-10-21 16:34:24 +02:00
Jonah Williams
4b351ac1b4
[flutter_tools] do not allow attaching in release mode (#68071)
Do not allow attach in release mode, as there is not VM Service to connect to. Observed in crash reporting as thrown string which is changed to exception below.
2020-10-13 21:29:23 -07:00
Jonah Williams
9e70180f63
[flutter_tools] do not measure progress timeout (#67959)
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
2020-10-13 13:05:47 -07:00
Jonah Williams
ac614de7ac
[flutter_tools] validate that SkSL bundle path exists (#67883)
Fixes #61772

tool exit if there is no file at the path provided when building/running with sksl
2020-10-12 12:49:51 -07:00
Jonah Williams
bdb830a833
[flutter_tools] pretty print hot reload rejection error (#66701)
If the vm of an attached device rejects a hot reload, pretty print the reason. Suggest a hot restart so that users are aware that they do not have to detach and rebuild. Also resets the last compilation time, so a subsequent restart would still apply the last change. Adds an integration test for the const field removal.

Fixes #64027
2020-10-09 15:44:52 -07:00
Jonah Williams
5fa801718f
[flutter_tools] remove train and inject-plugins command (#67766)
The train command does nothing and was originally added to provide a no-output default for generating app-jit snapshots. The inject-plugins command is only for a repo-only analysis check, which is not necessary since we regenerate during pub get.

#29805
2020-10-09 15:43:39 -07:00
Jonah Williams
9a3a0dc18f
[flutter_tools] hot reload/restart update for asset manager change (#66742)
Do not upload all assets on initial devFS sync. This should increase the reliability of the initial connection, even in the face of flaky devfs behavior, in addition to a moderate perf improvement.

Updates fast-start to build assets as part of the initial bundle

Requires flutter/engine#21436
Requires flutter/engine#21586
Requires flutter/engine#21611
2020-10-09 12:25:15 -07:00
Jonah Williams
973404a27f
[flutter_tools] support powershell style help request (#67493) 2020-10-08 14:06:58 -07:00
Jonah Williams
a4e0e2a8ee
Revert "[flutter_tools] remove all pub caching logic (#66776)" (#67572)
This reverts commit 76cbc462d2.
2020-10-07 15:30:46 -07:00
Jonah Williams
76cbc462d2
[flutter_tools] remove all pub caching logic (#66776)
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter, as well as problems with detecting the correct language version. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.
2020-10-07 13:11:07 -07:00
Jonah Williams
13bf341584
[flutter_tools] update build rules to depend on subset of package_config contents (#67165)
Split from #66776

Even if pub does not change the packge_config contents, it will still update a timestamp in one of the fields. This causes unnecessary rebuilds. To fix this, generate an additional file when running pub get that only contains the relevant fields and then update the KernelSnapshot rule to depend on it only.
2020-10-07 08:46:11 -07:00
Jonah Williams
6180a4c179
[flutter_tools] fix documentation, globals, and todos in the android codebase (#66980)
Cleans up some undocumented classes and re-organizes the AndroidDevices class to avoid the need for the static testing only member. Adds a script for tracking globals.
2020-10-05 15:47:57 -07:00
Jonah Williams
fe22d196fc
[flutter_tools] prevent running analyze-size with split-debug-info (#66983)
Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags.

Fixes #66962
2020-09-30 11:15:49 -07:00
Jonah Williams
e819f292b3
[flutter_tools] do not require a dependency on devtools server (#66842)
Re-arrange the implementation of the devtools launcher so that google3 is not required to depend on any devtools packages. Also renames the build_runner folders to isolated to better clarify their intention.
2020-09-29 18:15:56 -07:00
Marcus Tomlinson
5f76bfb4af
Add the ability to inject a bootstrap script (#66897) 2020-09-29 19:24:21 +01:00
Ben Konyi
65a81c7cd3
Roll package:dds to 1.4.0 and update error handling (#66836) 2020-09-29 10:28:17 -07:00
Jonah Williams
76698a5026
[flutter_tools] dont crash if attach is given a bad debug uri (#66358) 2020-09-22 12:03:21 -07:00
Jonah Williams
a19f5baccc
[flutter_tools] connect widget cache from frontend_server (#65951) 2020-09-19 11:02:04 -07:00