github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
f98184e487
Commit Graph

4381 Commits

Author SHA1 Message Date
Christopher Fujino
14d8534c3e
add usbmuxd (#52500) 2020-03-12 17:36:01 -07:00
Jonah Williams
1bf9d6f4f7
[flutter_tools] remove globals in AndroidDevices (#52505) 2020-03-12 15:51:26 -07:00
Zachary Anderson
0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown (#52491) 2020-03-12 14:01:01 -07:00
Jonah Williams
d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479) 
Reland of #52149
 2020-03-12 12:48:05 -07:00
Finn
9e848f3c78
Add ignore public member api docs in template (#52422) 2020-03-12 10:36:02 -07:00
Christopher Fujino
38a8845481
move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Dmitry Ratushnyy
1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson
04a1b78b75
Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476) 
This reverts commit edd03a1af8.
 2020-03-12 09:02:31 -07:00
Jonah Williams
edd03a1af8
[flutter_tools] Update background isolates when performing hot reload/restart (#52149) 
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
 2020-03-11 15:52:04 -07:00
Jonah Williams
6804cef587
[flutter_tools] throw exception instead of string from startApp (#52365) 
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
 2020-03-11 09:41:52 -07:00
Emmanuel Garcia
4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams
ea3563ea4d
[flutter_tools] update visual studio and validator to remove globals, update test cases (#51680) 
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
 2020-03-10 16:49:23 -07:00
Zachary Anderson
53dce17b35
[flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Zachary Anderson
78b45fb1b2
[flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson
7f564b7436
[flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams
5d289721fc
[flutter_tools] handle null value from sdk version (#52351) 
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
 2020-03-10 14:23:18 -07:00
Zachary Anderson
605debfcff
[flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Zachary Anderson
733fc20073
[flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams
fdb7bd3c0f
[flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams
2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state (#52325) 
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
 2020-03-10 11:35:52 -07:00
Jonah Williams
377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173) 
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
 2020-03-10 11:34:40 -07:00
Jenn Magder
fdd023fa59
Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams
60d0fef17a
[flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams
3191af1332
[flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams
88b39402ac
[flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Jonah Williams
bc43b41d99
[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261) 
This option was defaulting to on, which was tickling some benchmarks
 2020-03-09 17:19:14 -07:00
Angjie Li
665d380f81
Add Android Chrome support to Flutter Web Driver. (#51677) 
* Support Android Chrome for Flutter Web Driver.
 2020-03-09 13:01:07 -07:00
Dan Field
e13e17009d
Reland fix --version (#52141) 2020-03-06 21:38:35 -08:00
Dan Field
db1f33fd70
Revert "Local engine build mode (#52043)" (#52152) 
This reverts commit 4d05ed5deb.
 2020-03-06 16:57:18 -08:00
Jonah Williams
c1112d3f7e
[flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds (#52044) 2020-03-06 14:53:36 -08:00
Christopher Fujino
2e18cd347e
Fix simctl process exceptions not being caught (#51916) 2020-03-06 13:16:01 -08:00
Jonah Williams
e7d70fbf75
Revert "Fix version command for certain git workflows (#52062)" (#52128) 
This reverts commit 20bf43b9eb.
 2020-03-06 12:58:00 -08:00
Jenn Magder
a14ac4e3c8
Bump recommended CocoaPods version to 1.8 (#52071) 2020-03-06 12:14:42 -08:00
Jenn Magder
f6a55125d2
Add usage event for failed iOS project migration (#51879) 2020-03-06 12:14:29 -08:00
Zachary Anderson
6c408a0567
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#52021) 
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception

* Add armv7f to getIOSArchForName
 2020-03-06 10:22:12 -08:00
Dan Field
20bf43b9eb
Fix version command for certain git workflows (#52062) 2020-03-05 23:51:02 -08:00
Dan Field
4d05ed5deb
Local engine build mode (#52043) 2020-03-05 23:46:02 -08:00
Jonah Williams
d2f889b4f0
[flutter_tools] Reduce context usage in analyze command and tests (#49589) 2020-03-05 17:20:54 -08:00
Jonah Williams
bafa03e5b5
[flutter_tools] Remove mocking and simplify Dart target tests (#50688) 2020-03-05 17:19:15 -08:00
Jonah Williams
8872d1d8c4
[flutter_tools] Reland: supports tree-shake-icons for web builds (#52054) 2020-03-05 17:18:44 -08:00
Jenn Magder
b8472f25ab
Update Maven URL to https (#52042) 2020-03-05 16:00:34 -08:00
Jonah Williams
ad16823e4c
[flutter_tools] support new SDK structure for sdkmanager (#51980) 2020-03-05 13:59:20 -08:00
Jonah Williams
c411f588c6
Revert "[flutter_tools] supports tree-shake-icons for web builds (#51808)" (#52045) 
This reverts commit aed961993d.
 2020-03-05 13:02:22 -08:00
Jonah Williams
ee476a7bd1
Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714)" (#52041) 
This reverts commit ee60eeea3e.
 2020-03-05 12:51:42 -08:00
Jonah Williams
ee60eeea3e
[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714) 2020-03-05 12:38:40 -08:00
Jonah Williams
aed961993d
[flutter_tools] supports tree-shake-icons for web builds (#51808) 
* [flutter_tools] supports tree-shake-icons for web builds

* Update compile.dart

* fix icon_tree_shaker
 2020-03-05 12:35:04 -08:00
Jonah Williams
1bf6f0232e
[flutter_tools] support coverage and machine together (#51988) 2020-03-05 12:34:37 -08:00
Jonah Williams
bbf913bc4c
[flutter_tools] resolve requests to web directory in debug mode (#51995) 2020-03-05 12:34:03 -08:00
Jonah Williams
374f85c976
[flutter_tools] pin exact build_runner version (#52033) 2020-03-05 11:09:41 -08:00
Alexandre Ardhuin
c2ae654ddf
enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Jenn Magder
db94472aeb
Skip iOS project migration when script is already embedding frameworks (#51963) 2020-03-04 16:12:13 -08:00
Jenn Magder
dc33334675
Update iOS project migration help URL (#51973) 2020-03-04 16:12:02 -08:00
Jenn Magder
cbbb7ec5a7
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51774)" (#51960) 
This reverts commit 57c6721cd5.
 2020-03-04 12:40:15 -08:00
Flutter GitHub Bot
57c6721cd5
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51774) 2020-03-04 11:41:02 -08:00
Ben Konyi
3edd3eb4a2
Updated package:test, package:test_core, package:coverage, package:package_config (#51946) 
This is required to roll forward package:vm_service to 3.0.0 and is
blocking a DevTools release.
 2020-03-04 11:40:52 -08:00
Zachary Anderson
a5bd678585
Revert "Write FLUTTER_BUILD_MODE when using a local engine (#51687)" (#51943) 
This reverts commit 9b4b7d7ee0.
 2020-03-04 08:56:53 -08:00
Dan Field
9b4b7d7ee0
Write FLUTTER_BUILD_MODE when using a local engine (#51687) 2020-03-04 07:36:55 -08:00
Christopher Fujino
2c846af1a0
Fix _checkPodCondition not handling CocoaPodsStatus.brokenInstall (#51676) 2020-03-03 17:55:02 -08:00
Konstantin Scheglov
fb953b719f
Cast to List<dynamic> and cast(). (#51591) 2020-03-03 14:49:02 -08:00
stuartmorgan
f9c118b6b2
Exit for missing Windows plugin projects (#51838) 
Exit, rather than crash, if a Windows plugin is missing its project.

Fixes #51743
 2020-03-03 22:43:42 +01:00
stuartmorgan
8d8439f8e3
Add pre-stable support for create on Linux (#51832) 
Adds initial support for `flutter create` of apps and plugins. This is derived from the current FDE example app and sample plugin, with a few changes:
- Added template values where it makes sense.
- Moved some likely-to-change values into separate files for now, to simplify the delete/recreate cycle that will be necessary until it's stable.
- Added some minor Makefile flag handling improvements

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the `create` output about the fact that it won't be stable.
 2020-03-03 22:42:52 +01:00
Jenn Magder
e491544588
Move embedding and linking Flutter frameworks into the tool (#51453) 
* Move embedding and linking Flutter frameworks into the tool

* Unused import

* Migrate

* Rename run, add comments, remove typedef

* Add status log to tell the user what we did

* Remove Podfile migration, create IOSMigration superclass

* word-smiting

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* for space

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
 2020-03-03 12:11:28 -08:00
Shi-Hao Hong
d2c734a36f
Simple repeating word fixes (#51871) 2020-03-03 11:13:07 -08:00
Greg Spencer
1ba4f1f509
Add Linux and Windows target platforms (#51519) 
This PR adds the linux and windows target platform enum values, along with automatically setting the defaultTargetPlatform to the appropriate value on those platforms.

Fixes #31366
 2020-03-03 04:38:04 -08:00
zsunkun
fdbd1b14ff
fix pom file not found when run app with local engine (#51468) 2020-03-02 19:09:01 -08:00
Jonah Williams
3489da9328
[flutter_tools] no more MockLogger in tests (#51684) 2020-03-02 16:23:56 -08:00
Zachary Anderson
914bd76979
[flutter_tools] Handle errors on the std{out,err}.done future (#51660) 2020-02-28 22:31:01 -08:00
Jonah Williams
9b4159c5ee
[flutter_tools] support run -d chrome test scripts (#51658) 2020-02-28 14:21:02 -08:00
Jonah Williams
515027a91c
[flutter_tools] allow configuring libraries spec path for the web compilation (#51590) 2020-02-28 11:26:02 -08:00
Jonah Williams
42ae15f44e
[flutter_tools] remove LinuxWorkflow from injection and clean up tests (#51597) 2020-02-28 10:27:27 -08:00
Zachary Anderson
b32ee2f15c
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567)" (#51616) 
This reverts commit 9de7787f25.
 2020-02-27 22:57:13 -08:00
stuartmorgan
33bb1faf5b
Reland: Always use new plugin schema for plugin template (#49832) 
Now that the new schema is supported on the stable channel, and the old
schema is considered legacy, the template should always create plugins
using the new schema.
 2020-02-27 22:48:25 -08:00
Zachary Anderson
9de7787f25
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567) 2020-02-27 22:46:23 -08:00
Jonah Williams
e00d424de5
[flutter_tools] clean-ups to linux doctor test (#51593) 2020-02-27 15:15:35 -08:00
Jenn Magder
4fb9ce8414
Clean App.framework, Generated.xcconfig, flutter_export_environment.sh (#51532) 2020-02-27 12:18:06 -08:00
Jonah Williams
080dfb5eb3
[flutter_tools] swap mustache dependency for mustache_template (#51578) 2020-02-27 11:23:41 -08:00
stuartmorgan
dd2756c36a
Generate a makefile for Linux plugins (#51520) 
When generating the plugin registrant for Linux, also generate a
makefile that can be included in the app-level Makefile to manage all of
the plugin targets and flags, exporting them in a few known variables
for use in the outer makefile.

Part of #32720
 2020-02-27 09:45:22 -08:00
Jonah Williams
3b5668c996
[flutter_tools] hide usage of package:mustache behind interface (#51500) 2020-02-27 09:17:42 -08:00
Jonah Williams
08d079f6c2
[flutter_tools] wire up complete support for Dart obfuscation (#50509) 2020-02-27 08:58:33 -08:00
Zachary Anderson
483f49962c
Revert "[flutter_tool] Where possible, catch only subtypes of Exception (#51440)" (#51539) 
This reverts commit f1cd47ef5c.
 2020-02-26 23:42:19 -08:00
Zachary Anderson
f1cd47ef5c
[flutter_tool] Where possible, catch only subtypes of Exception (#51440) 2020-02-26 21:45:02 -08:00
Jonah Williams
80619f100f
[flutter_tools] remove globals from plist parser and update tests (#51444) 2020-02-26 18:31:42 -08:00
Jenn Magder
e31521eab5
Validate empty pubspec plugin section (#51503) 2020-02-26 15:44:35 -08:00
Lynn
2243c42ebc
Fix flutter doctor (pluginsPath) check for Mac (#50324) 2020-02-26 13:41:03 -08:00
Jonah Williams
65a7941228
[flutter_tools] reduce globals in web validator and chrome launcher (#51443) 2020-02-26 10:37:52 -08:00
Jonah Williams
55072246d0
[flutter_tools] remove build script from tool package (#50690) 2020-02-26 08:25:04 -08:00
Jonah Williams
53457c2241
[flutter_tools] Reland initialize frontend_sever with build (#51477) 2020-02-26 08:06:03 -08:00
Jonah Williams
421056ee54
Revert "[flutter_tools] initialize frontend server with build (#49405)" (#51476) 
This reverts commit 59cc3cdf01.
 2020-02-26 07:24:18 -08:00
Alexandre Ardhuin
a4054938ce
unnecessary multiline strings (#50806) 2020-02-25 18:12:17 -08:00
Zachary Anderson
bc4bd7bd55
[flutter_tools] Don't try to run pub before the version command (#51436) 2020-02-25 17:19:47 -05:00
stuartmorgan
22c807773a
Automatically add plugin projects to Windows .sln (#51246) 
Adds utility code for managing list of plugin projects within a solution file, updating them as the plugins change.

This is a prototype of an approach to solution-level portion of Windows plugin tooling; it may not be what the final plugin handling on Windows uses, but it makes things much better in the short term, and gives us a baseline to evaluate other possible solution management systems against.

Part of #32719
 2020-02-25 14:16:27 -08:00
Nate Bosch
9228b87eb3
Don't use a default test randomize ordering seed (#51018) 
Fixes #51010

The test package differentiates between passing and not passing this
argument. A previous version had a bug that treated passing `0`
identically to not passing the argument, and the flutter test runner
relied on this bug by always passing a value and using a default of `0`.

- Remove the argument defaults throughout to make it clear that `null`
  is a valid value and the default.
- Remove the argument defaulting on the argument parser.
- Update the wording of the usage for this argument, this will also be
  updated on the `package:test` side.
 2020-02-25 13:01:40 -08:00
Zachary Anderson
d73dd6b356
[flutter_tools] Rework iOS vmservice handshake failure usage event (#51419) 2020-02-25 15:22:17 -05:00
Christopher Fujino
704fb4cbc7
Remove usage of ideviceinstaller in favor of ios-deploy (#50772) 2020-02-25 09:09:40 -08:00
Jonah Williams
59cc3cdf01
[flutter_tools] initialize frontend server with build (#49405) 2020-02-24 14:21:33 -08:00
Jonah Williams
3411129cc5
[flutter_tools] don't fix chrome window size, add more logs (#51346) 2020-02-24 12:26:05 -08:00
Jonah Williams
7572ec47bd
[flutter_tools] add more search paths for source maps (#51307) 2020-02-24 10:40:08 -08:00
Dan Field
4df8fdb7df
update cache for flutter test/fast command (#51235) 2020-02-22 18:24:03 -08:00
Angjie Li
5ee4147283
Allow developers to run flutter driver web test directly (#51084) 2020-02-22 16:49:03 -08:00
Jonah Williams
bb74a328b5
[flutter_tools] adds etag/cache control header to debug asset server (#51143) 2020-02-21 14:15:54 -08:00
Jonah Williams
25a813110d
[flutter_tools] reload dart_sdk when sources update (#51067) 2020-02-20 12:26:47 -08:00
Alexandre Ardhuin
7d7ac7c32b
start multiline strings with newline (#50825) 2020-02-20 10:16:28 +01:00
Jacob MacDonald
dda7a618ec
add support for the builders configuration for web (#50988) 2020-02-19 19:01:04 -08:00
Jonah Williams
6d0b1ef868
[flutter_tools] include LICENSE files as build dependencies (#50945) 2020-02-19 18:56:04 -08:00
Jenn Magder
85b54d4c0c
Change DeviceManager.getAllConnectedDevices() return value from Stream to List (#51015) 2020-02-19 17:40:24 -08:00
Francisco Magdaleno
6815e72086
Revert "[flutter_tools] move engine unpack to the flutter tool (#50707)" (#51076) 
This reverts commit 0a623e879c.
 2020-02-19 13:55:48 -08:00
Jonah Williams
0a623e879c
[flutter_tools] move engine unpack to the flutter tool (#50707) 2020-02-19 13:36:04 -08:00
Angjie Li
11549e45a3
Use Async WebDriver for WebFlutterDriver. (#50835) 2020-02-19 13:31:10 -08:00
Martin Kustermann
d2947571bd
Ensure to close connection to VM after collecting coverage (#50943) 2020-02-18 12:39:37 -08:00
Jacob MacDonald
11589ca20d
serve the generated main.dart file so source_maps work for it (#50976) 2020-02-18 12:36:03 -08:00
Jonah Williams
67362ce5e0
[flutter_tools] fix debug stack traces (#50872) 2020-02-18 11:28:02 -08:00
Jonah Williams
57acc68740
[flutter_tools] ensure zoned errors are caught in new web runner (#50895) 2020-02-18 11:27:14 -08:00
Jonah Williams
3bb4ba61bd
[flutter_tools] use uri resolution for asset requests (#50844) 2020-02-14 21:46:03 -08:00
Jonah Williams
238dac141b
Revert "[flutter_tools] More Linux version detail (#50739)" (#50840) 
This reverts commit c725f107a1.
 2020-02-14 16:10:47 -08:00
Jonah Williams
ea4d969ecc
[flutter_tools] move dwds imports to not require g3 visibility (#50823) 2020-02-14 14:56:03 -08:00
Zachary Anderson
bf32974189
[flutter_tools] Handle asynchronous errors writing to stdio (#50779) 2020-02-14 10:38:02 -08:00
Zachary Anderson
c268b6c3d4
[flutter_tools] Collect more information in ios-handshake failure event (#50804) 2020-02-14 09:40:52 -08:00
Yegor
b34046903b
Fix stack trace parsing on non-debug builds; add e2e tests (#50652) 
* Fix stack trace parsing on non-debug builds; add e2e tests
 2020-02-13 18:34:08 -08:00
Zachary Anderson
c725f107a1
[flutter_tools] More Linux version detail (#50739) 2020-02-13 14:49:11 -08:00
Jonah Williams
9431229e4c
[flutter_tools] remove globals from depfile usage (#50710) 2020-02-13 13:59:40 -08:00
stuartmorgan
f4177a6dde
Generate a Property Sheet for Windows plugins (#50740) 
Generates a Property Sheet for Windows builds containing link and include path
information for any included plugins. This allows automating part of the process
of integrating plugins into the build that is currently manual.

To support this change, refactored msbuild_utils into a PropertySheet class so that
it can be used to make different property sheets.
 2020-02-13 12:53:28 -08:00
Jonah Williams
e2554a9202
Add "flutter downgrade" command (#50506) 2020-02-13 11:56:45 -08:00
Jonah Williams
550c82d5d4
[flutter_tools] initialize web stack trace formatter (#50680) 2020-02-13 10:03:02 -08:00
Jonah Williams
d3a41816d1
[flutter_tools] ensure all source maps load correctly for release and profile (#50702) 2020-02-13 10:01:04 -08:00
Zachary Anderson
450fc25c1e
[flutter_tool] Disable analytics on more bots (#50669) 2020-02-13 09:58:03 -08:00
stuartmorgan
7bdd4757ec
Create plugin symlinks for Windows and Linux (#50599) 
This makes ephemeral symlinks to each plugin, for use by build systems.
This is similar to the logic implemented in the Podfile on iOS and
macOS, but managed internally to the Flutter tool.

Exploration for addressing #32719 and #32720
Related to #41146
 2020-02-12 16:23:27 -08:00
Dan Field
24f8f799da
add an --enable-vmservice flag (#50663) 2020-02-12 14:52:09 -08:00
Zachary Anderson
b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots (#50641) 2020-02-12 10:58:02 -08:00
sjindel-google
3aa72cc2f2
Use ELF for AOT snapshots on Fuchsia. (#50468) 2020-02-12 10:53:04 -08:00
Zachary Anderson
1903ce012e
Revert "[flutter_tools] Disable analytics for more bots (#50579)" (#50622) 
This reverts commit 0a38f29c0d.
 2020-02-11 22:47:41 -08:00
Jenn Magder
7c24ebc79b
Map arm64e devices to arm64 devices (#50612) 2020-02-11 19:43:43 -08:00
Jonah Williams
5406258fc6
[flutter_tools] fix crash when IsolateRef returns sentinel (#50611) 2020-02-11 16:03:45 -08:00
Jenn Magder
bfbb347682
Use BUILD_LIBRARY_FOR_DISTRIBUTION build setting for generating add-to-app frameworks (#50536) 2020-02-11 15:53:02 -08:00
Zachary Anderson
0a38f29c0d
[flutter_tools] Disable analytics for more bots (#50579) 2020-02-11 15:48:02 -08:00
Jonah Williams
18f38cd45b
Switch flutter_tools to use frontend_server for web compilation (#50365) 2020-02-11 15:43:46 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Jenn Magder
e002698c35
Turn back on macOS shard Cirrus caching (#50496) 2020-02-11 10:37:53 -08:00
Jonah Williams
fa44a1cf37
[flutter_tools] fix path escaping on in depfile generation (#50538) 2020-02-11 09:31:58 -08:00
Jonah Williams
568172793c
Add "flutter symbolize" command (#49465) 2020-02-10 14:18:03 -08:00
Zachary Anderson
c23d9cd4ce
[flutter_tools] Print emojis in Windows Terminal (#50446) 2020-02-10 10:23:35 -08:00
Jenn Magder
082ae838bd
Fall back to global cache and platform if null when injected into constructor (#50370) 2020-02-07 15:28:45 -08:00
Jenn Magder
4411d8e64e
Update minimum version to Xcode 11.0 (#50371) 2020-02-07 14:35:01 -08:00
Jenn Magder
48a9bd56b1
Revert "Update minimum version to Xcode 11.0 (#50315)" (#50369) 
This reverts commit 2b7582ef61.
 2020-02-07 13:59:21 -08:00
Jenn Magder
2b7582ef61
Update minimum version to Xcode 11.0 (#50315) 2020-02-07 13:57:24 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Alexandre Ardhuin
5c28e3eeea
unnecessary escapes fixes (#50178) 
* unnecessary escapes fixes

* replace some strings with raw strings

* update regexp

* address review comments
 2020-02-07 06:35:50 +01:00
David Iglesias
b8199abd15
[flutter_tools] Prevent web ServiceWorker from modifying fetch requests. (#50312) 2020-02-06 18:43:03 -08:00
Jonah Williams
82410a5ae7
[flutter_tools] support iOS and macOS with split-debug-info and tree-shake-icons (#50296) 2020-02-06 18:39:34 -08:00
Harry Terkelsen
0fc1c6f6d7
[flutter_tool] Make the registrant import relative to the entrypoint (#50302) 2020-02-06 17:08:02 -08:00
Jonah Williams
181cdec079
[flutter_tools] remove automatic multiroot scheme (#50284) 2020-02-06 17:05:41 -08:00
Zachary Anderson
6bfff984de
[flutter_tools] Handle AndroidStudio validator crash (#50282) 2020-02-06 16:03:02 -08:00
Levi Lesches
149e06232b
Add option to clear the terminal by pressing "c" (#50034) 2020-02-06 15:53:04 -08:00
Jenn Magder
a9b8d360cf
Remove ideviceinfo, idevice_id artifacts (#50248) 2020-02-06 15:50:26 -08:00
Jenn Magder
2512163ebe
Allow Android to be missing from multi-platform manifest (#50304) 2020-02-06 15:50:03 -08:00
Christopher Fujino
e6e14b0dd2
Have android validator suggest ANDROID_SDK_ROOT instead of deprecated ANDROID_HOME (#49846) 2020-02-06 14:03:03 -08:00
Jonah Williams
db901ce5dd
[flutter_tools] remove dependencies checks that are no longer relevant in assemble-land (#50225) 2020-02-06 13:59:18 -08:00
Jonah Williams
69ecca554d
[flutter_tools] iOS fallback discovery protocol (#49735) 2020-02-06 13:58:03 -08:00
Gityuan
b8dd6bdd19
support endless recorder for timeline (#47419) 2020-02-06 12:33:01 -08:00
Jenn Magder
a0665aba49
Reland Replace ideviceinfo and idevice_id with xcdevice (#50252) 2020-02-06 11:38:47 -08:00
Nate Bosch
8159178238
Remove usages of StackTraceMapper (#50153) 
* Remove usages of StackTraceMapper

This class will be replaced with a function type in `test_api`, clean up
usages ahead of time.

In `build_script.dart` the only reference to `StackTraceMapper` is in
the `browser_test.dart` file, but since nothing would call
`setStackTraceMapper` from that import it should be safe to remove the
definition. After reading a serialized mapper from the
`test.browser.mapper` channel, it was ignored.

In `flutter_web_platform.dart` we only were reading from `_mappers`,
never putting values in, so we can remove it entirely. The `load()`
function was never called with a `mapper` argument.
 2020-02-06 10:34:50 -08:00
Lau Ching Jun
81525fa1a6
Support downloading font-subset for all platforms (#50240) 2020-02-06 10:33:02 -08:00
Jenn Magder
ce6fbf6668
Revert "Replace ideviceinfo and idevice_id with xcdevice (#49854)" (#50243) 
This reverts commit 3aa7a80053.
 2020-02-05 18:00:31 -08:00
Emmanuel Garcia
eb4b6dc91b
Retry Gradle command when failing to download a resource (#50223) 2020-02-05 17:48:04 -08:00
Jonah Williams
da4b5d68c4
[flutter_tools] support --split-debug-info option in android builds (#49650) 2020-02-05 17:45:24 -08:00
Jonah Williams
de7908f9e9
[flutter_tools] Reland flutter assemble for iOS (#50229) 2020-02-05 17:44:06 -08:00
Jonah Williams
91c342e213
[flutter_tools] force page refresh when hot restarting in profile/release mode (#50215) 2020-02-05 17:43:05 -08:00
Jenn Magder
3aa7a80053
Replace ideviceinfo and idevice_id with xcdevice (#49854) 2020-02-05 17:37:25 -08:00
Jonah Williams
4d2ce7be2c
Revert "[flutter_tools] Reland migrate xcode_backend.sh to flutter assemble (#50200)" (#50228) 
This reverts commit 868b0e6d97.
 2020-02-05 15:57:49 -08:00
Jonah Williams
868b0e6d97
[flutter_tools] Reland migrate xcode_backend.sh to flutter assemble (#50200) 2020-02-05 13:04:22 -08:00
Alexandre Ardhuin
94c7e823be
remove unnecessary string escapes (#50096) 2020-02-05 08:00:32 +01:00
Dan Field
4b8efad99b
Font subset in the tool (#49737) 2020-02-04 20:34:24 -08:00
Mehmet Oguz Derin
a4093edbcf
Fix Path Separator in Service Workers (#50154) 2020-02-04 20:18:01 -08:00
Jenn Magder
4485a65e60
Add -destination generic/platform=iOS to "build ios-framework" xcodebuild (#50140) 2020-02-04 18:08:03 -08:00
Zachary Anderson
103b12fc11
[flutter_tools] Isolate userHomePath, other cleanups (#50125) 2020-02-04 18:03:03 -08:00
Jonah Williams
52d5744ea2
Revert "[flutter_tools] Migrate xcode_backend.sh to flutter assemble (#49842)" (#50151) 
This reverts commit c2353b2911.
 2020-02-04 15:02:55 -08:00
Jonah Williams
64b82f50ad
[flutter_tools][web] serve dummy service_worker and manifest file in run mode (#50115) 2020-02-04 14:19:26 -08:00
Jonah Williams
c2353b2911
[flutter_tools] Migrate xcode_backend.sh to flutter assemble (#49842) 2020-02-04 14:19:08 -08:00
Jenn Magder
d00a39cbdd
Remove dead code IMobileDevice.isWorking (#50084) 2020-02-04 14:18:20 -08:00
Jenn Magder
6e605f3fdc
Run "build ios-framework" processes async (#49657) 2020-02-04 14:17:53 -08:00
Mehmet Fidanboylu
0c5ae7d656
Use the FlutterVersion defined in context (#50040) 2020-02-03 20:43:02 -08:00
Jonah Williams
50eeda2495
[flutter_tools] fix frontend server generated entrypoint (#50036) 2020-02-03 20:38:03 -08:00
Zachary Anderson
ef62d53222
[flutter_tools] Fix crash on null Android apiVersion (#50029) 2020-02-03 14:48:02 -08:00
Jonah Williams
b24bca1383
[flutter_tools] add missing period to end of filter (#50038) 2020-02-03 14:33:08 -08:00
Zachary Anderson
390ed1cd81
[flutter_tools] Move homeDirPath to FileSystemUtils (#49909) 2020-02-03 14:33:03 -08:00
Zachary Anderson
2c51efef29
[flutter_tools] Make Config context-free (#49834) 2020-01-31 12:51:20 -08:00
Prerak Mann
688948b778
switching channel prompts to run flutter upgrade (#49511) 2020-01-31 09:33:29 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations (#49622) 2020-01-31 18:30:21 +01:00
Greg Spencer
6ee8b6546b
Revert "Always use new plugin schema for plugin template (#48258)" (#49827) 
This reverts commit 9d4a35b because it appears to break

the gradle_non_android_plugin_test.
 2020-01-30 12:46:12 -08:00
stuartmorgan
9d4a35ba8b
Always use new plugin schema for plugin template (#48258) 
Now that the new schema is supported on the stable channel, and the old
schema is considered legacy, the template should always create plugins
using the new schema.
 2020-01-30 11:30:31 -08:00
Zachary Anderson
92f7e16312
[flutter_tools] Make OperatingSystemUtils context-free (#49740) 2020-01-29 17:51:31 -08:00
Jenn Magder
02dc0ab37f
Remove unnecessary BuildableIOSApp from "build ios-framework" (#49659) 2020-01-29 14:27:43 -08:00
Jenn Magder
d85ea51384
Move iMobileDevice to globals (#49724) 2020-01-29 13:51:16 -08:00
Jonah Williams
cb3b7ab487
[flutter_tools] simplify symbol logic for iOS (#49628) 2020-01-29 13:43:23 -08:00
Terry Lucas
1b4d321b34
Fix Flutter tool to use correct adb parameter and collect Realtime value. (#49701) 
* Fix parameter to adb to be _package.id instead of package._launchActivity.
 2020-01-29 10:01:17 -08:00
Jonah Williams
22fc215260
[flutter_tools] hide assembly gen_snapshot warning (#49662) 2020-01-29 09:06:33 -08:00
Emmanuel Garcia
466681cad8
Improve error message when a plugin sets an invalid android package (#48104) 2020-01-28 17:48:26 -08:00
Emmanuel Garcia
1c6cc23903
Sanitize host before calling pm (#49644) 2020-01-28 16:44:58 -08:00
Mouad Debbar
8366b2721a
[web] Serve dart files correctly when running "flutter test" in Chrome (#49325) 2020-01-28 15:08:02 -08:00
Jonah Williams
dd98046fe5
Revert "[flutter_tools] remove alternative build aot code path (#49577)" (#49641) 
This reverts commit d1e25bf233.
 2020-01-28 13:21:56 -08:00
Jonah Williams
d1e25bf233
[flutter_tools] remove alternative build aot code path (#49577) 2020-01-28 13:08:04 -08:00
Jonah Williams
33e61d1cd6 [flutter_tools] open chrome with unresolve hostname (#49625) 2020-01-28 12:53:03 -08:00
Jonah Williams
3bd4c69fd8
Revert "Sanitize host before calling pm (#49591)" (#49623) 
This reverts commit c592b54678.
 2020-01-28 10:14:08 -08:00
Emmanuel Garcia
c592b54678
Sanitize host before calling pm (#49591) 2020-01-28 08:17:11 -08:00
Zachary Anderson
68ed5c2baf [flutter_tool] Hide unsafe std{out,err} operations (#49561) 2020-01-28 07:58:02 -08:00
Dan Field
fabeb2a16f
Revert string interp (#49602) 2020-01-28 07:56:51 -08:00
Jonah Williams
c341d4b78f [flutter_tools] Discover pubspec.yaml in parent directories (#48548) 2020-01-27 21:48:01 -08:00
Jonah Williams
3233252cb1
[flutter_tools] only apply --strip to iOS gen_snapshot in release mode (#49596) 2020-01-27 19:36:12 -08:00
Jonah Williams
afa24b1a18
[flutter_tools] only strip when bitcode is enabled (#49595) 2020-01-27 19:10:27 -08:00
Jenn Magder
fdb0225f8c
Revert "[flutter_tools] move dsym generation logic into dart build process (#49491)" (#49592) 
This reverts commit 2a91a7501c.
 2020-01-27 18:37:21 -08:00
Zachary Anderson
74c1be6ff1 [flutter_tool] Make base/net.dart context free (#49575) 2020-01-27 17:53:02 -08:00
Jonah Williams
2a91a7501c
[flutter_tools] move dsym generation logic into dart build process (#49491) 2020-01-27 17:48:33 -08:00
chunhtai
123de155a6 add more devices into whitelist (#49569) 2020-01-27 17:48:03 -08:00
Jonah Williams
11621cc798
[flutter_tools] remove dwarf stripping now that linked issue is fixed (#49563) 2020-01-27 17:41:55 -08:00
Jonah Williams
ace2c2297f
[flutter_tools] Generate correct entrypoint module name for experimental web compiler (#49486) 2020-01-27 17:41:29 -08:00
Jenn Magder
7f715628b0 Replace FlutterVersion.instance with FlutterVersion context fetch in global.dart (#49462) 2020-01-27 17:38:01 -08:00
Dan Field
8b2993337a
revert #48985 (#49572) 2020-01-27 14:36:02 -08:00
Jonah Williams
31cd3c7b80 [flutter_tools] fast start off by default (#49554) 2020-01-27 13:13:02 -08:00
Jonah Williams
dc084b9097 [flutter_tools] handle plugins for entrypoints outside of main (#49459) 2020-01-27 13:08:02 -08:00
Jonah Williams
347823234f [flutter_tools] Apply --no-causal-async-stacks and --lazy-async-stacks to profile/release builds (#49377) 2020-01-27 10:43:03 -08:00
Jenn Magder
7feb7dddf1
Inject platform into build ios-framework command (#49463) 2020-01-27 10:32:50 -08:00
Jenn Magder
91f7902aad Move Xcode context fetch to global.dart (#49458) 2020-01-25 11:18:02 -08:00
Prerak Mann
a66e9569b5 sort channels by stability upon running flutter channel (#48427) 2020-01-25 11:03:03 -08:00
Zachary Anderson
93a5b7d419 [flutter_tool] Don't crash on a failure to write to std{out,err} (#49380) 2020-01-25 01:23:01 -08:00
Jonah Williams
2f59919496 [flutter_tools] Reland fast start by default for Android (#49315) 2020-01-24 19:18:01 -08:00
Jenn Magder
acdaffc493
Suppress upgrade message with --machine (#49408) 2020-01-24 10:50:54 -08:00
Alexandre Ardhuin
92cbaa3efe remove unnecessary string interpolations (#49352) 2020-01-23 20:43:01 -08:00
Jason Simmons
3f97315720 [flutter_tools] Do not use the logcat -T flag on Android versions before Lollipop (#49327) 2020-01-23 20:18:01 -08:00
Zachary Anderson
d9f071fd0a [flutter_tool] Don't crash when writing to pub stdin fails (#49323) 2020-01-23 20:13:01 -08:00
Jonah Williams
7faf2d73c7 [flutter_tools] implement build aot in terms of assemble for iOS (#49224) 2020-01-23 20:03:01 -08:00
Jacob MacDonald
adc8680645 update incremental web compiler bootstrapping to use the new module names (#49073) 2020-01-23 18:33:01 -08:00
Christopher Fujino
0c2f51fca7 Fix concurrent modification error (#48916) 2020-01-23 18:23:03 -08:00
Jenn Magder
9d2910847e
Remove App.framework copy during build ios-framework (#49321) 2020-01-23 18:21:25 -08:00
Jonah Williams
ef15eac821 [flutter_tools] Remove context from Xcode and most of Xcodeproj (#48661) 2020-01-23 15:03:03 -08:00
Mouad Debbar
a1fa1a3d26 [web] Wire the "--start-paused" flag correctly for web (#49310) 2020-01-22 14:58:46 -08:00
Jonah Williams
d68278e3ea
[flutter_tools] rollback to dwds 0.8.5, fix versioning (#49301) 2020-01-22 11:05:07 -08:00
Emmanuel Garcia
2b8c75d55c
Copy the local engine repo in the output directory (#49276) 2020-01-22 10:57:14 -08:00
Jenn Magder
8a3c98633a
Disallow empty platforms and specific platforms when parsing manifest for plugins (#49262) 2020-01-22 10:52:23 -08:00
Emmanuel Garcia
320c19e4b9 Fix build aar instructions (#49265) 2020-01-21 20:03:02 -08:00
Dan Field
525855d595 download font-subset (#49234) 2020-01-21 16:53:02 -08:00
Angjie Li
f0a175f41d Use flutter_tools to start WebDriver browser. (#49228) 2020-01-21 16:48:02 -08:00
Jenn Magder
d8092d999a
Fix YamlMap cast error (#49253) 2020-01-21 16:43:16 -08:00
Alexandre Ardhuin
3800bb7b10 fix missing spaces in adjacent strings (#49159) 2020-01-21 16:43:03 -08:00
Jenn Magder
2a7d57791d Generate bitcode for plugin frameworks for flutter build ios-framework (#49102) 2020-01-21 16:38:03 -08:00
Jonah Williams
2ebe9da454
Revert "[flutter_tools] Reland enable fast-start by default for Android (#48851)" (#49227) 2020-01-21 09:51:08 -08:00
Jonah Williams
1ac01b30ca
[flutter_tools] Reland enable fast-start by default for Android (#48851) 2020-01-21 08:59:26 -08:00
Jonah Williams
e340c19905 [flutter_tools] resolve host address in the flutter tool for web server (#48992) 2020-01-21 08:58:01 -08:00
Jenn Magder
ac7b307803 Don't pre-cache Android artifacts with --no-android flag (#49009) 2020-01-20 23:23:02 -08:00
Zachary Anderson
dc94e479d1 [flutter_tool] Don't crash on failed stamp file update (#49080) 2020-01-17 15:18:01 -08:00
Anthony
b67d5ec6e9 [a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985) 2020-01-17 15:13:01 -08:00
Francisco Magdaleno
fcf341e4f3
Reland "[flutter_tools] Removes the need of a no-op plugin implementations #48614" (#49085) 2020-01-17 14:43:34 -08:00
Zachary Anderson
e8222aaf9a [flutter_tool] Don't crash on Android emulator startup failure (#48995) 2020-01-17 09:28:01 -08:00
Jenn Magder
b225cb8d53
Revert "[flutter_tools] Removes the need of a no-op plugin implementations (#48614)" (#49005) 
This reverts commit 5eb394e084.
 2020-01-16 16:19:54 -08:00
Jonah Williams
ea43f24e68
[flutter_tools] let experimental compiler support plugins (#48979) 2020-01-16 13:32:49 -08:00
Francisco Magdaleno
5eb394e084
[flutter_tools] Removes the need of a no-op plugin implementations (#48614) 2020-01-16 12:42:05 -08:00
Jason Simmons
63016c8900 [flutter_tools] Handle special characters during conversion of asset manifest paths into URIs (#48829) 2020-01-15 16:43:02 -08:00
stuartmorgan
1be332eb8b Require Visual Studio 2019 for Windows (#48844) 2020-01-15 08:43:03 -08:00
Jonah Williams
63c65e5cdb
[flutter_tools] Clean up build_aot code post assemble migration (#48771) 2020-01-14 19:07:15 -08:00
Jonah Williams
ad9476dc9e
[flutter_tools] Remove context from Artifacts class (#48776) 2020-01-14 16:47:34 -08:00
Jonah Williams
bc6f270c58
Revert "[flutter_tools] Enable fast start by default for Android (#48746)" (#48836) 
This reverts commit d5b0b3c8d1.
 2020-01-14 13:23:03 -08:00
Jonah Williams
d5b0b3c8d1
[flutter_tools] Enable fast start by default for Android (#48746) 2020-01-14 12:38:53 -08:00
Emmanuel Garcia
b9733522dd
Implement takeScreenshot and add driver test for Fuchsia (#48611) 2020-01-14 12:29:09 -08:00
Andrew Davies
52e0d980cb [tools] Rename dev_finder to device-finder. (#48610) 
dev_finder name is deprecated. device-finder is preferred.
Functionality remains identical, this is an aesthetic change.

This change was generated via:
$ find . -not -path '*/\.*' -type f -exec sed -i 's/(^import.*)!dev_finder/device-finder/g' {} \;
 2020-01-14 09:41:16 -08:00
Zachary Anderson
29490887e0
Reland: [flutter_tools] File system utilities (#48757) 
* Reland: [flutter_tools] File system utilities

* Remove unused imports
 2020-01-14 09:40:39 -08:00
xster
9eb9ea0ffa
Let the tool warn about all old API plugins (#48282) 2020-01-13 21:30:42 -08:00
Jonah Williams
79c286705c
[flutter_tools] Refactor Environment and FileStore to be context-free (#48759) 2020-01-13 19:25:35 -08:00
Jonah Williams
9f145f6ced [flutter_tools][web] Add basic service worker generation support to web applications (#48344) 2020-01-13 17:13:02 -08:00
Zachary Anderson
ef62092b9b
Revert "[flutter_tools] File system utilities (#48738)" (#48755) 
This reverts commit 0349660622.
 2020-01-13 14:30:37 -08:00
Jacob MacDonald
03a59bff03
Serve packages uris in flutter_tools dev web server (#48743) 
* support mapping /packages/<package>/<path> requests to package:<package>/<path> uris in the web device file server
 2020-01-13 13:21:57 -08:00
Zachary Anderson
0349660622
[flutter_tools] File system utilities (#48738) 2020-01-13 13:17:45 -08:00
Zachary Anderson
23a3d1014f
[flutter_tool] Make BotDetector context free (#48605) 2020-01-13 10:12:06 -08:00
Ian Hickson
e2b169ebd3 Apply void_checks lint. (#48267) 2020-01-13 10:03:01 -08:00
Zachary Anderson
4d096c434f [flutter_tool] Make CommandHelp context free (#48584) 2020-01-10 16:53:01 -08:00
Emmanuel Garcia
fca5917519 Test hot reload targeting a Fuchsia device (#48472) 2020-01-10 14:38:01 -08:00
Zachary Anderson
8b139a8c41
[flutter_tool] Use the delegate's toString in the ErrorHandlingFileSystem (#48597) 2020-01-10 14:35:49 -08:00
Zachary Anderson
67a68e9fa6
[flutter_tools] Fix analytics opt out event (#48585) 2020-01-10 14:35:19 -08:00
Tim Sneath
5280dda15b Improve toolchain text (#48102) 2020-01-10 14:28:03 -08:00
Emmanuel Garcia
ec2d58335a Make subcommands return success instead of null (#48100) 2020-01-10 11:28:01 -08:00
Jonah Williams
5d30c0970a
[flutter_tools][web] Add support for web app manifests and arbitrary resource files (from web/) (#48316) 2020-01-10 09:37:20 -08:00
Jonah Williams
749589d896
[flutter_tools] Remove context usage from status and clean up test cases (#48446) 2020-01-10 09:36:49 -08:00
Alexandre Ardhuin
82262d8896 format operator== according to flutter style guide (#48449) 2020-01-09 08:23:02 -08:00
Zachary Anderson
23ce192a8f Reland: Reword flutter run help screen. (#48423) 2020-01-09 08:18:03 -08:00
Zachary Anderson
07161e8267
[flutter_tool] Don't use context in ProcessUtils (#48444) 2020-01-08 15:20:32 -08:00
stuartmorgan
58d6c425e4
Check for desktop project files before building (#48350) 
Moves the checks that projects have been configured for desktop to a lower level, where they will cover more codepaths (e.g., 'run'), and improves them to check for native build projects, rather than just directories, to catch cases where the directory exists (e.g., due to accidental creation of generated files).

Also adds links to the error messages pointing to instructions on adding desktop support to a project.

Fixes #47145
 2020-01-08 12:39:49 -08:00
Jonah Williams
f7b8d62cbc
[flutter_tool] Refactor Logger and Terminal to (mostly) no longer depend directly on context (#47269) 2020-01-08 12:35:12 -08:00
Tim Sneath
6b66412136 Update first-run information URLs (#48154) 2020-01-08 12:33:03 -08:00
Zachary Anderson
a1bf03f87a
Revert "Esarbanis flutter run help (#48314)" (#48351) 
This reverts commit 866fa64dce.
 2020-01-07 15:06:40 -08:00
Jonah Williams
bf6c4c4a41
[flutter_tools]web]Add support for --csp mode to build web (#48319) 2020-01-07 12:20:03 -08:00
Zachary Anderson
866fa64dce
Esarbanis flutter run help (#48314) 
* Reword flutter run help screen.

* As per Hixie request, added Efthymios Sarmpanis to the AUTHORS file

* fix test

Co-authored-by: Efthymis Sarmpanis <e.sarbanis@gmail.com>
 2020-01-07 12:10:08 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Jonah Williams
2221a9f514
[flutter_tool] Cache the path context in the flutter tool (#48250) 
recomputing the path context in the getter violates flutter repo style guide and adds a small but measurable overhead to all path operations
 2020-01-06 13:57:13 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable (#47398) 2020-01-06 11:04:20 -08:00
Jenn Magder
0aed0b61a1
Add newlines between plugin names in GitHub template (#46937) 2020-01-03 17:53:54 -08:00
Devon Carew
c924f499f5
ignore a (potentially) unused import in generated code (#47593) 2020-01-03 11:04:03 -08:00
Angjie Li
9df1790f24 Flutter Web Driver Support (#47890) 2020-01-02 19:48:01 -08:00
Jenn Magder
dc99d61e5d Remove simulator arch in Profile and Release, App.xcframework (#48002) 2020-01-02 13:03:01 -08:00
Jenn Magder
a6c3ffe10c Allow Xcode project Info.plist to be moved (#47993) 2020-01-02 12:03:02 -08:00
Dan Field
24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081) 
This reverts commit 04ea3183ce.
 2020-01-02 11:47:28 -08:00
Francisco Magdaleno
04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080) 
This reverts commit e768c92fbc.
 2020-01-02 09:25:59 -08:00
Ian Hickson
e768c92fbc
Add many more global analyses. (#47875) 
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
 2019-12-30 17:12:19 -08:00
Francisco Magdaleno
f2f9d0e4fd
Revert "Flutter Web Driver Support (#47470)" (#47698) 
This reverts commit cc1c9649c4.
 2019-12-23 15:20:11 -08:00
Jenn Magder
9861a1c045
flutter build ios-framework generate Flutter.podspec (#47556) 2019-12-23 13:12:36 -08:00
Alexandre Ardhuin
4adad2c652
update list of lints (#47661) 2019-12-23 18:40:56 +01:00
Jenn Magder
85e9be36bf
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266)" (#47568) 
This reverts commit 648a5d8a1e.
 2019-12-20 17:45:16 -08:00
Angjie Li
cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Jenn Magder
648a5d8a1e
Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266) 2019-12-19 14:18:10 -08:00
Dan Field
41a911099b comments (#47473) 2019-12-19 13:48:02 -08:00
Jonah Williams
3fe6668849
[flutter_tool] ensure extraGenSnapshotArguments are forwarded to gen_snapshot from Android builds (#47059) 2019-12-19 13:44:21 -08:00
Dan Field
0a9ff388bf Revert "Use platform appropriate filepaths" (#47395) 2019-12-18 18:08:02 -08:00
Lau Ching Jun
2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389) 
This reverts commit 1ef0eadb45.
 2019-12-18 17:02:31 -08:00
Jenn Magder
9184f4d6fb
Build iOS frameworks with relative output path (#47369) 2019-12-18 15:31:54 -08:00
Dan Field
b23238890a Pipe through test-randomize-ordering-seed (#47243) 2019-12-18 13:58:01 -08:00
Lau Ching Jun
7850e2525f
Is executable doesn't mean a+x (#47359) 2019-12-18 12:21:46 -08:00
Angjie Li
1ef0eadb45 Flutter Web Driver Support (#45951) 
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
 2019-12-18 10:45:39 -08:00
Zachary Anderson
d328e0cea0 [flutter_tool] Improve iOS mDNS failure error message (#47348) 2019-12-18 09:23:00 -08:00
Emmanuel Garcia
9884f9980f Change meaning of a plugin not supporting the android platform (#47015) 2019-12-17 19:48:01 -08:00
Jenn Magder
65ad8d805a
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928)" (#47264) 
This reverts commit e54e301d50.
 2019-12-17 17:20:57 -08:00
Jenn Magder
e54e301d50 Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928) 2019-12-17 16:13:01 -08:00
Emmanuel Garcia
a15a81be21
Fix androidSdk NPE (#47187) 2019-12-17 14:10:36 -08:00
Jenn Magder
1cdf0f44db
Only set flutter run usage values for targeted device platforms (#46931) 2019-12-17 14:09:34 -08:00
Alek Åström
853c8c569f [flutter_tools] Add violating plugin name to validation errors (#46601) 2019-12-17 14:08:03 -08:00
George Wright
56f4eaf58c
Re-enable --no-link-platform for JIT mode (#47242) 2019-12-17 17:05:32 -05:00
Jonah Williams
0a2d8e0cce
[flutter_tool] Remove direct usage of package:linter in the flutter_tools (#47174) 2019-12-16 18:37:20 -08:00
Jonah Williams
a723c94650
[flutter_tool] restructure ProjectFileInvalidator to no longer directly depend on context (#45739) 2019-12-16 18:12:04 -08:00
Zachary Anderson
a72cca137d
[flutter_tool] Print a helpful message on some mDNS failures (#47157) 2019-12-16 14:57:29 -08:00
Todd Volkert
fc9b30a4f1
Revert "flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917)" (#46999) 
This reverts commit f28592018d.

It broke forbidden_imports_test, which uses a custom ignore directive.
 2019-12-13 12:23:12 -08:00
Sam Rawlins
f28592018d flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917) 2019-12-13 12:03:02 -08:00
Jonah Williams
0497235c20
[flutter_tool] experimental resident web runner is not debuggable (#46916) 2019-12-12 19:05:48 -08:00
Jenn Magder
dfa6eb31a0
Revert "flutter run FULL_PRODUCT_NAME (#46838)" (#46925) 2019-12-12 17:34:54 -08:00
Jenn Magder
7a7e2bb247 flutter run FULL_PRODUCT_NAME (#46838) 2019-12-12 17:03:01 -08:00
Jonah Williams
5ba2830c83
[flutter_tool][gallery] Standardize target platform override behavior in tool and update flutter gallery to support it (#46206) 2019-12-12 15:20:52 -08:00
Jonah Williams
23b7853dfd
[flutter_tool] remove ability to disable Fingerprinter with DISABLE_FLUTTER_BUILD_CACHE env variable (#46913) 2019-12-12 15:12:53 -08:00
Jonah Williams
8ca55605c8
[flutter_tool] forward device-vmservice-port to iOS device launch arguments (#46822) 2019-12-12 13:55:42 -08:00
Jonah Williams
592a842b86
[flutter_tool] fix NPE in daemon caused by returning null connection info from experimental web runner (#46909) 2019-12-12 13:55:09 -08:00
Emmanuel Garcia
a467932d5b
Skip plugins that don't have an android impl when building AARs (#46835) 2019-12-12 12:38:09 -08:00
Danny Tuppeny
4944622b5d
Support URL tunnelling (pass dwds UrlEncoder through to editors via daemon) (#44271) 
* Prposal for supporting URL tunnelling

* Update daemon.md

* Add the ability for daemon to call clients to expose URLs

* Fix dwds mock in web_fs tests

* Fix type error

* Remove build_runner import from run

* Move appStartedTime back to after the app has started

* Remove nested DI scope and pass urlTunneller down

* Fix import

* Tweak TODO

* Fix existing tests

* Fix spec to use result instead of params for response object

* Fix exposeUrl to use a url field, as spec'd

* Test that the daemon's exposeUrl sends a request and handles the response
 2019-12-12 18:43:58 +00:00
Lau Ching Jun
535526b03c
Enable web for some of the golden tests (#46820) 
* Make golden test timeout longer, some tests are flaky if the timeout is too short

* Enable some golden tests for web
 2019-12-12 10:36:41 -08:00
Sean Freiburg
418b814555 Add buildNumber param to "flutter build aar" command (#46291) 2019-12-12 10:28:01 -08:00
Emmanuel Garcia
354f80b84a
Check and give execute permission to Gradle if needed (#46748) 2019-12-11 16:36:03 -08:00
Jonah Williams
8b88c8296f
remove test_api dependency from flutter_tools/base/io (#46796) 2019-12-11 13:31:30 -08:00
Jonah Williams
d0e5824040
[flutter_tool] Update require.js artifact location for tests (#46787) 2019-12-11 12:56:58 -08:00
Zachary Anderson
895ffc80dc
[flutter_tool] Handling of certain unrecoverable filesystem errors (#46617) 2019-12-11 12:54:36 -08:00
Jonah Williams
01953a1015
[flutter_tool] fix NPE in log reader for web server device (#46729) 2019-12-10 16:14:48 -08:00
Koichi Ishida
4938ea0385 Fix typo in gradle tools exit message (#46580) 2019-12-10 13:41:31 -05:00
Jonah Williams
bda9d90804
[flutter_tool] Reland: support --fast-start for Android applications (as an opt-in) (#46140) 2019-12-10 10:26:14 -08:00
Jonah Williams
81aa2710d2
[flutter_tool] add a vmservice API for hot ui requests (#45649) 2019-12-09 21:31:34 -08:00
Jonah Williams
523ac7b6f5
[flutter_tool] Always re-copy Framework/podspec when regenerating iOS module project (#45877) 2019-12-09 21:18:09 -08:00
Jonah Williams
d0526d3f92
[flutter_tool] Prevent accidental calls to io.exit in unit tests (#46639) 2019-12-09 18:58:29 -08:00
Christopher Fujino
0268510480 Fix analytics regression (#46242) 2019-12-09 15:13:02 -08:00
Jonah Williams
63cc4ad3aa
Revert "[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210)" (#46630) 
This reverts commit b698c9d72e.
 2019-12-09 13:13:59 -08:00
Jonah Williams
b698c9d72e
[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210) 2019-12-09 13:01:37 -08:00
Lau Ching Jun
c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Amr Yousef
237c478683 Update iOS build signing error message (#45835) 2019-12-06 10:41:06 -08:00
Jonah Williams
e6fa5717d1
fix release web builds where the target file is not under lib (#46179) 2019-12-05 15:57:12 -08:00
Jenn Magder
fb69a393b8
Add bitcode and architectures to App.framework build ios framework command (#46130) 2019-12-05 12:16:54 -08:00
Zachary Anderson
e98acc7d1d [flutter_tool] Print version info on a no-op upgrade. (#46109) 2019-12-05 12:16:48 -08:00
Zachary Anderson
99684ce159 [flutter_tool] Make Device.dispose() abstract (#46006) 2019-12-05 08:48:00 -08:00
Jenn Magder
d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138) 
This reverts commit 2a113165c0.
 2019-12-04 18:12:57 -08:00
Jonah Williams
2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
Emmanuel Garcia
9e94eb93bc
Remove flutterBuildPluginAsAarFeature flag (#46101) 2019-12-04 15:42:08 -08:00
Christopher Fujino
dfc108c66c improve resetChanges() dartdoc (#46008) 2019-12-04 09:58:01 -08:00
Zachary Anderson
4484ae4043 [flutter_tool] Do not continue with a no-op 'upgrade' (#46011) 2019-12-03 20:08:24 -08:00
Emmanuel Garcia
09126abb22
Enable Android embedding v2 on the beta, dev and stable channel (#46040) 2019-12-03 17:43:00 -08:00
Jonah Williams
b96d818c19
Remove record/replay/bug report functionality from the tool (#45999) 2019-12-03 13:24:45 -08:00
Jonah Williams
c95dafc4c6
Add printTrace when vscode package.json parsing fails (#45998) 2019-12-03 09:56:04 -08:00
Jonah Williams
0dace48932
Add comments to package scheme fix (#45997) 2019-12-03 09:55:50 -08:00
Jonah Williams
0b2bf99491
Reland: Update macOS configuration settings (#45966) 2019-12-03 08:13:08 -08:00
Jonah Williams
8a9897c84c
Revert "update macOS configuration settings (#45920)" (#45965) 
This reverts commit 3b2042a028.
 2019-12-02 21:34:41 -08:00
Jonah Williams
9708e7d16a
use package-scheme imports for generated web entrypoint (#45934) 2019-12-02 21:10:08 -08:00
Jonah Williams
3b2042a028
update macOS configuration settings (#45920) 2019-12-02 21:06:38 -08:00
Jonah Williams
b63683b6cd
Update configuration for flutter features (#45914) 2019-12-02 17:06:41 -08:00
Jonah Williams
8cf20f3be7
Dont crash on malformed packages.json (#45786) 2019-12-02 17:04:37 -08:00
Emmanuel Garcia
8c25328014
Handle case where lastLogcatTimestamp is null (#45937) 2019-12-02 15:02:11 -08:00
Dan Field
088fa24463
Set the LANG when invoking cocoapods (#45710) 2019-12-02 13:26:32 -08:00
Kaushik Iska
3994872073
Sample driver test working on Fuchsia (#45652) 
* [flutter_driver] [fuchsia] Validate existance of cmx for driver tests

Also added an example driver test that can run on Fuchsia devices.

Fixes: https://github.com/flutter/flutter/issues/45624

* update packages for stock example

* fix licenses
 2019-12-02 12:56:16 -08:00
Emmanuel Garcia
475ee89879
Make Android log reader read any recent logs (#45743) 2019-11-27 17:52:36 -08:00
Jenn Magder
e2642fd6c0
Do not delete output directory during flutter build ios-framework (#45740) 2019-11-27 17:48:19 -08:00
Ian Hickson
449f4a6673
License update (#45373) 
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
 2019-11-27 15:04:02 -08:00
Jonah Williams
59ca523b2c
Support web-server/profile/release mode with incremental compiler support for web (#45713) 2019-11-27 13:32:45 -08:00
Jonah Williams
598f2ab0fb
Cleanups to resident runner and flutter device classes (#45673) 2019-11-27 13:11:04 -08:00
Zachary Anderson
e4b809b7c8
[flutter_tool] Crash less when git fails during 'version' (#45628) 2019-11-27 10:18:43 -08:00
Danny Tuppeny
4741e9c3fe
Retry Xcode builds if they fail due to concurrent builds running (#45608) 
* Retry Xcode builds if they fail due to concurrent builds running

Fixes #40576.

* Add tests for concurrent iOS launches

* Increase number of retries to account for the initial build being slow
 2019-11-27 09:44:05 +00:00
Greg Spencer
245d1b51ce
Add macOS to TargetPlatform (#43457) 
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
 2019-11-26 18:32:34 -08:00
Jonah Williams
831163f0d0
Register memory info command on vmservice for Android devices (#45568) 2019-11-26 14:49:56 -08:00
Jenn Magder
7d8f82051b
Suggest GitHub template when flutter tool crashes (#45360) 
* On flutter tool crash suggest GitHub template

* Shorten GitHub URLs

* Whitespace

* Wording tweak from @InMatrix

* Review edits
 2019-11-26 14:06:31 -08:00
Christopher Fujino
dc68d5700b
Fix flutter run cache (#45267) 2019-11-26 09:02:34 -08:00
Jonah Williams
84ce3f6097
Serve web source maps in release runner (#45318) 2019-11-25 17:09:36 -08:00
Jenn Magder
8eb6a925f9
Always compile with isysroot on iOS to point to SDK root (#45436) (#45560) 2019-11-25 12:49:18 -08:00
Jonah Williams
1888fa3526
Allow flutter run to run release/profile x64 (#45511) 2019-11-25 12:04:17 -08:00
Emmanuel Garcia
81724bd60f
Fallback to protocol discovery if mdns returns null (#45439) 2019-11-25 11:51:54 -08:00
Michael Klimushyn
901eb0fc81
Add a note to generated plugins files (#45557) 
There has been some confusion about whether or not
.flutter-plugins-dependencies should be tracked in version control or
not. Added a comment to both it and .flutter-plugins explaining that
it's generated and shouldn't be.

.flutter-plugins-dependencies is parsed through JSON, and the JSON spec
doesn't support comments. So unfortunately the note is living in an
arbitrary "_info" key instead of an obvious top level comment.
 2019-11-25 11:47:20 -08:00
Jenn Magder
4cc10a1fb8
Revert "Always compile with isysroot on iOS to point to SDK root (#45436)" (#45555) 
Analyzer warning.
 2019-11-25 10:46:42 -08:00
Jenn Magder
6b11f18bc0
Always compile with isysroot on iOS to point to SDK root (#45436) 2019-11-25 10:27:22 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools (#45153) 
* implicit-casts:false on flutter_tools

* use castStringKeyedMap

* address review comments

* address review comments

* fix issues after rebase
 2019-11-24 06:54:43 +01:00
Emmanuel Garcia
b6e92003c8
Add .flutter-plugins-dependencies to the project, which contains the app's plugin dependency graph (#45379) 2019-11-22 15:02:20 -08:00
Jonah Williams
b54bb6abbb
Dont crash if the tool cannot delete asset directory during debugging (#45407) 2019-11-22 14:06:05 -08:00
Jonah Williams
35b571ccfc
Revert "Improve time to development by initializing frontend_server concurrently with platform build (#45236)" (#45422) 2019-11-22 13:36:12 -08:00
Jonah Williams
c63c576bca
Reland handle corrupt config file (#45414) 2019-11-22 12:26:51 -08:00
Jonah Williams
60869e0a93
Improve time to development by initializing frontend_server concurrently with platform build (#45236) 2019-11-22 12:26:31 -08:00
xster
942707591d
Revert "catch parse error from corrupt config (#45319)" (#45412) 2019-11-22 10:56:16 -08:00
Jonah Williams
6640c8b9b4
catch parse error from corrupt config (#45319) 2019-11-22 10:09:23 -08:00
Jonah Williams
497ae83c82
Fix experimental incremental web compiler for Windows (#45286) 2019-11-22 10:08:38 -08:00
Yegor
aa3943316b
Fix dartDefines in daemon mode (#45317) 
* de-null dartDefines in daemon mode
* remove daemonCommand; pipe through dartDefines into Daemon
* pass dartDefiles in attach; add test for --machine mode
 2019-11-22 08:57:14 -08:00
Greg Spencer
a60bf8e23a
Spell check of Flutter docs (#45200) 
No code changes, just comments: I spell-checked all the comments in the repo.
 2019-11-22 08:43:55 -08:00
Amir Hardon
e43a69a9fe
Allow a no-op default_package key for a plugin platform (#45364) 2019-11-21 16:37:34 -08:00
Zachary Anderson
05226d2a61
Reland: [flutter_tool] Fuchsia AOT builds (#45350) 
* Reland: [flutter_tool] Fuchsia AOT builds

* Fixes
 2019-11-21 12:55:39 -08:00
Jonah Williams
785e557a43
remove Flags (#45320) 2019-11-21 12:52:52 -08:00
Zachary Anderson
0216953674
Revert "[flutter_tool] Fuchsia AOT builds (#45187)" (#45349) 
This reverts commit a57dddd217.
 2019-11-21 09:41:46 -08:00
Zachary Anderson
a57dddd217
[flutter_tool] Fuchsia AOT builds (#45187) 2019-11-21 08:32:58 -08:00
Emmanuel Garcia
5df4b7db23
Reland: Attach looks at future observatory URIs (#45307) 2019-11-20 18:51:25 -08:00
Amir Hardon
53c7ca7d5a
Allow unknown fields in pubspec plugin section (#45303) 2019-11-20 17:00:46 -08:00
Jonah Williams
106b8eb9c0
Revert "Reduce some direct package:archive usage (#44608)" (#45291) 
This reverts commit 6b5634fed3.
 2019-11-20 14:45:32 -08:00
Jonah Williams
6b5634fed3
Reduce some direct package:archive usage (#44608) 2019-11-20 13:32:14 -08:00
Emmanuel Garcia
fb5e49082b
Revert "Attach looks at future observatory URIs (#45228)" (#45237) 
This reverts commit 2135e9fb1e.
 2019-11-19 23:14:25 -08:00
Emmanuel Garcia
2135e9fb1e
Reland: Attach looks at future observatory URIs (#45228) 2019-11-19 21:43:52 -08:00
Jonah Williams
c724504142
Update Android CPU device detection (#45139) 2019-11-19 19:04:17 -08:00
Emmanuel Garcia
7a0911b47a
Revert "Attach looks at future observatory URIs (#44637)" (#45211) 
This reverts commit 6d77996d6a.
 2019-11-19 16:47:39 -08:00
Emmanuel Garcia
6d77996d6a
Attach looks at future observatory URIs (#44637) 2019-11-19 15:11:41 -08:00
Danny Tuppeny
37eec86294
Allow web server device to use extension if started with --start-paused (#44263) 
* Allow web server device to use extension if started with --start-paused

* Fix comment

* Remove browser-launch option that allowed using Chrome without launching Chrome

The web-server device should now be used if you don't want to launch a browser.

* Add tests for WebServerDevice with --start-paused

* Fixes from rebase

* More fixes from rebase

* Fix from rebase

* Fix condition for page refresh in non-debug builds

* Make dwds conditions match with a new getter

* Add missing .device
 2019-11-19 20:11:53 +00:00
Jonah Williams
df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jonah Williams
e236196037
cache sdkNameAndVersion logic for web devices (#45145) 2019-11-19 09:36:24 -08:00
Alexandre Ardhuin
0df8812681
fix type errors (#45151) 2019-11-19 09:28:24 +01:00
Alexandre Ardhuin
adc7351046
implicit-casts:false on flutter_tools/lib (#44447) 
* implicit-casts:false on flutter_tools/lib

* address review comments

* use castStringKeyedMap

* introduce {bool,string,strings}Arg

* fix ci
 2019-11-19 07:57:42 +01:00
Jonah Williams
58438fca3f Provide specific field to accept depfiles in target class (#44481) 
* add depfile slot to Target class

* Update source.dart

* Update source.dart
 2019-11-18 14:09:40 -08:00
Jonah Williams
a7367b650b
Don't log stack traces to console on build failures (#44966) 2019-11-18 14:04:11 -08:00
Christopher Fujino
ff84b3e66d catch IOSDeviceNotFoundError in IOSDevice.startApp() (#45011) 2019-11-18 13:53:55 -08:00
Danny Tuppeny
81f6ba84b9
Switch from using app.progress to app.webLaunchUrl for passing web launch urls (#44268) 
* Switch from using app.progress to app.url for passing web launch urls

* Update daemon.md

* Change app.url -> app.webLaunchUrl

* Add tests for app.webLaunchUrl event

* Update tests with recent changes after rebasing
 2019-11-18 18:10:15 +00:00
Jonah Williams
2a576b774c
remove no-gen-bytecode flag (#43908) 2019-11-15 13:15:05 -08:00
Zachary Anderson
29c026fac4
[flutter_tool] Don't crash when failing to delete downloaded artifacts (#44933) 
* [flutter_tool] Don't crash when failing to delete downloaded artifacts

* Add space

* Add more spaces.
 2019-11-15 10:05:45 -08:00
Zachary Anderson
afe4830a9d
[flutter_tool] Various fixes for 'run' for Fuchisa. (#44920) 2019-11-14 12:39:48 -08:00
Jenn Magder
55530d905a
Add -runFirstLaunch hint text (#44870) 2019-11-14 10:45:47 -08:00
Danny Tuppeny
5376e90fda
Print a message when modifying settings that you may need to reload IDE/editor (#44574) 
* Print a message when modifying settings that you may need to reload IDEs/editors

* Add a test for `flutter config` output

* Remove blank line
 2019-11-14 17:54:22 +00:00
Jonah Williams
e77c24ef91
Update package test (#44882) 2019-11-14 09:31:36 -08:00
Zachary Anderson
a4cc799d15
[flutter_tool] Update Fuchsia SDK (#44457) 2019-11-14 09:11:26 -08:00
Jenn Magder
e57ab1f263
Add module to create template help text (#44638) 2019-11-13 18:28:45 -08:00
Jenn Magder
6498f64399
Catch and display version check errors during doctor (#44868) 2019-11-13 18:23:05 -08:00
Jonah Williams
e3cb2c3fcf
Reland: Allow specifying device-vmservice-port and host-vmservice-port (#44853) 2019-11-13 16:02:46 -08:00
Jonah Williams
985da83139
Revert "Allow specifying device-vmservice-port and host-vmservice-port (#44027)" (#44843) 
This reverts commit c0af77bf87.
 2019-11-13 14:35:07 -08:00
Emmanuel Garcia
0019599411
Build AAR for all build variants by default (#44797) 2019-11-13 13:27:10 -08:00
Jonah Williams
c0af77bf87
Allow specifying device-vmservice-port and host-vmservice-port (#44027) 2019-11-13 13:01:41 -08:00
Emmanuel Garcia
f766871eb9
Forward ProcessException to error handlers (#44783) 2019-11-13 10:02:46 -08:00
Jonah Williams
2779361b38
Ensure web-server does not force usage of dwds (#44744) 2019-11-12 15:24:45 -08:00
Jonah Williams
3383b564a1
Always link desktop platforms (#44753) 2019-11-12 15:24:18 -08:00
Jenn Magder
47f71ba3c3
Release startup lock during long-lived build ios framework (#44625) 2019-11-12 15:14:29 -08:00
xster
9e0df259df
Show a warning when a module uses a v1 only plugin (#44499) 2019-11-11 15:56:43 -08:00
Yegor
e7073f9a1f
add --dart-defines option (#44083) 2019-11-09 17:08:53 -08:00
Ian Hickson
f4da9f72eb
Deprecation cleanup in flutter_tools (#44469) 
One deprecated member was no longer used; removed it.

The other probably shouldn't be deprecated, because it's not the
parser that's deprecated so much as the format it's parsing. The code
itself will live on until we decide to stop supporting the format,
it's not like people calling the member should use something else.
 2019-11-08 16:31:34 -08:00
Jonah Williams
9fa0f3b2ea
fix test for null flutter root (#44468) 2019-11-08 14:38:44 -08:00
Jonah Williams
978fada33c
Refactor flutter.gradle to use assemble directly (#43876) 
Removes multiple re-entrant calls of bundle and aot and replaces them with a single call to assemble. This restores full caching and will allow follow-up performance improvements when building multiple ABIs
 2019-11-08 12:41:24 -08:00
Jonah Williams
cc51ad5d08
Reland: enable usage of experimental web compiler (#44400) 2019-11-07 20:13:02 -08:00
Jonah Williams
7535ef735f
Revert "Enable usage of experimental incremental compiler for web (#43576)" (#44396) 
This reverts commit e5d6d92498.
 2019-11-07 16:32:20 -08:00
Jonah Williams
e5d6d92498
Enable usage of experimental incremental compiler for web (#43576) 2019-11-07 16:29:51 -08:00
Emmanuel Garcia
2c80bc973d
Flip enable-android-embedding-v2 flag (#44369) 2019-11-07 15:18:56 -08:00
Zachary Anderson
12c190f746
[flutter_tool] Stream artifact downloads to files (#44360) 2019-11-07 14:01:57 -08:00
Emmanuel Garcia
b0ad6072ef
Don't print how to consume AARs when building plugins as AARs (#44301) 2019-11-07 10:18:55 -08:00
Afzaal Ahmad Zeeshan
9492dcc7cc Update create.dart (#43764) 
Changed the placements of the operands to make it more readable.
 2019-11-07 10:17:03 -08:00
Emmanuel Garcia
cb614d1339
Fix v1 embedding support heuristic for plugins (#44214) 2019-11-07 08:24:19 -08:00
xster
d2e87a5d2c
Build ios framework (#44065) 2019-11-06 14:54:15 -08:00
Alexander Markov
cf6a8d6a47
Do not pass obsolete --strong option to front-end server (#44278) 2019-11-06 14:46:10 -08:00
Emmanuel Garcia
bb8cf609ec
Build local maven repo when using local engine (#44243) 2019-11-06 12:52:37 -08:00
Jonah Williams
383e90eb13
Use platform appropriate filepaths when constructing asset bundle (#44221) 2019-11-06 12:50:18 -08:00
Jonah Williams
aa333fda25
link platform should be true for profile (#44279) 2019-11-06 12:21:41 -08:00
Kaushik Iska
8e8add524e
[flutter_tool] Screenshot command must require device only for _kDeviceType (#44227) 
There are cases where we have access to the observatory without having a device connection accessible.
 2019-11-06 10:59:29 -08:00
James D. Lin
1f0c3d462e
Make ProjectFileInvalidator injectable (#44200) 
Allow ProjectFileInvalidator to be overridden with a different
implementation.

I stole this from https://github.com/flutter/flutter/pull/39217.
 2019-11-05 21:40:48 -08:00
Michael Klimushyn
02aac5072c
Revert "Exit tool if a plugin supports the embedding v2 but the app doesn't (#44026)" 
This missed some plugins that _do_ support the v1 embedding
(shared_preferences as one known case) so caused unexpected breakages.

This reverts commit b94c1a41ca.
 2019-11-05 14:38:09 -08:00
Kaushik Iska
7dceec21f7
[flutter_tool] --flutter_runner will download the debug symbols (#44119) 
This makes the flutter tool download the debug symbols for Flutter and Dart runners to be used in Fuchsia dev environment.
 2019-11-05 14:07:48 -08:00
xster
ba26f926c7
Add Android embedding version analytics (#44043) 2019-11-05 12:38:42 -08:00
Jonah Williams
e5af60c83e
Remove flutter.yaml migration code (#44146) 2019-11-05 12:28:03 -08:00
Zachary Anderson
372fe290e4
[flutter_tool] Update analytics policy, send event on disable (#43217) 2019-11-05 10:43:52 -08:00
Jonah Williams
0f6c093d68
Remove Source.behavior, fix bug in depfile invalidation (#43945) 
* remove Source.behavior, fix bug in depfile invalidation

* more cleanup of assets

* Add skip

* address comments

* Update build_system.dart
 2019-11-04 16:37:43 -08:00
Emmanuel Garcia
76957c9da8
build aar prints how to consume the artifacts (#44127) 2019-11-04 16:28:27 -08:00
Emmanuel Garcia
b94c1a41ca Exit tool if a plugin supports the embedding v2 but the app doesn't (#44026) 2019-11-04 13:37:51 -08:00
Jonah Williams
3422540bc4
copy chrome preferences to seeded data dir (#44032) 2019-11-04 09:09:20 -08:00
Jonah Williams
df0501c7d3
remove services code (#44052) 2019-11-04 09:08:57 -08:00
Jonah Williams
5e1bb20c83
support --no-resident on the web (#44028) 2019-11-04 09:08:40 -08:00
Jonah Williams
f1186b0758
Asset server fix for sourcemaps (#44017) 2019-11-01 22:33:52 -07:00
Emmanuel Garcia
ade8dfac3d
Move the plugin registrant to io.flutter.plugins and add the @Keep annotation (#44011) 2019-11-01 16:58:26 -07:00
Jenn Magder
2e7d9130b2
Observe logging from VM service on iOS 13 (#43915) 2019-11-01 14:37:17 -07:00
Jonah Williams
71740bef74
remove listDartSources (#43950) 2019-11-01 11:06:24 -07:00
Emmanuel Garcia
dea35da040
Log additional Android build failures (#43941) 2019-11-01 10:06:23 -07:00
Jonah Williams
a60a47ae2c
Serve correct mime type on release dev server (#43907) 2019-10-31 14:57:34 -07:00
Emmanuel Garcia
175b37247d
Refactor gradle.dart (#43479) 2019-10-31 13:19:15 -07:00
Jonah Williams
79323f7c13
Ensure target platform is passed is always passed to assemble (#43862) 2019-10-30 19:40:19 -07:00
Jonah Williams
79bc6cafc5
implement build aot with assemble for Android target platforms (#43282) 2019-10-30 15:23:25 -07:00
Zachary Anderson
d0d8e6edcb
[flutter_tool] Teach the tool about local engine Fuchsia artifacts (#43759) 2019-10-30 14:11:18 -07:00
Jonah Williams
417449e2f3
Deflake flutter tool logger test (#43800) 2019-10-30 13:09:26 -07:00
Jonah Williams
349d694fb7
Revert "Added a null check for ranges in the sourceReport map. (#43667)" (#43827) 
This reverts commit 0dc5ea4a95.
 2019-10-30 10:57:35 -07:00
Efthymis Sarmpanis
c5b3b3ac26 Flutter doctor should require java 1.8+ (#41989) 2019-10-30 10:40:27 -07:00
Nate Bosch
7cf362fc31 Handle onError callback with optional argument (#43436) 
Check for a binary callback first since a function with an optional
second argument will match both typedefs.

Remove documentation around a synchronous error following some other
error or value - a synchronous error can never follow a value or an
asynchronous error. If there is a synchronous error it will _always_ be
the first thing to happen.

Add a test for a unary error handler and an error handler with an
optional stack trace argument.
 2019-10-30 10:39:50 -07:00
Larry McKenzie
0dc5ea4a95 Added a null check for ranges in the sourceReport map. (#43667) 2019-10-30 10:35:45 -07:00
stuartmorgan
f6f6e86eb8
Split desktop config fallback variable by platform (#43758) 
The environment variable for all desktop platforms is currently
ENABLE_FLUTTER_DESKTOP to allow backward compatibility with existing
workflows. However, this is actually causing issues since 'flutter
config' provides a better experience (most importantly, IDEs will work
correctly, which is generally not the case with the environemnt
variable). Currently people following old (third-patry) instructions
don't realize that they are missing available functionality, so aren't
looking for the current instructions.

In adddition, this will be confusing as different platform graduate to
channels other than master at different times.

To resolve both issues, the environment variable fallback is now
separate for each desktop platform, and follows a naming scheme
consistent with the web environment variable.
 2019-10-29 21:43:25 -07:00
Jonah Williams
50da3bd062
check if libimobiledevice executables exist (#43767) 2019-10-29 21:35:51 -07:00
Jonah Williams
b1aff28593
pass --no-gen-bytecode to aot kernel compiler invocations (#43753) 2019-10-29 16:05:54 -07:00
Emmanuel Garcia
7e60a65ff0
Don't read AndroidManifest.xml if it doesn't exit (#43669) 2019-10-29 16:05:13 -07:00
Christopher Fujino
261594e785
add libzip cache artifact (#43677) 2019-10-29 14:29:00 -07:00
liyuqian
c523149819
Reland "Enable dump-skp-on-shader-compilation in drive (#43022)" (#43455) 
This reverts commit b9eb3f717a.

We fixed the issue by updating the constructors.
 2019-10-29 14:20:22 -07:00
Jonah Williams
331d19ff4b
Add reloadMethod RPC (#43725) 2019-10-29 13:21:06 -07:00
Jonah Williams
1d7afd9c1d
Don't indefinitely persist file hashes, handle more error conditions (#43602) 2019-10-29 13:20:51 -07:00
Jenn Magder
01dc19b93f
Pass environment variables through to xcodebuild (#43553) 2019-10-28 19:58:06 -07:00
Jonah Williams
19e551c7a6
Remove Poller class from flutter_tools (#43685) 2019-10-28 19:35:43 -07:00
Jonah Williams
e25cd84a06
Catch failed startup error from build_daemon (#43598) 2019-10-28 15:58:14 -07:00